2cce5c52c2
The new ObjectPtr design makes non-inlined helper functions a little more expensive because "this" is always a pointer where pass-by-value would be more efficient, which is an issue for functions whose size puts them right at the threshold of getting inlined or not. String::Get falls into this category when called from RegExpFlagsFromString. In this case, we can do even better than restoring inlineability by fine-tuning the control flow a bit. This should repair the regression in crbug.com/910573 Bug: chromium:910573 Change-Id: Ie6b68ef01cd978ec502d8d6c1da788c77422dce7 Reviewed-on: https://chromium-review.googlesource.com/c/1369087 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58234}
45 lines
1.1 KiB
JavaScript
45 lines
1.1 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
function benchName(bench, setup) {
|
|
var name = bench.name;
|
|
if (setup) name += "/" + setup.name;
|
|
return name;
|
|
}
|
|
|
|
function slowBenchName(bench, setup) {
|
|
return benchName(bench, setup) + " (Slow)";
|
|
}
|
|
|
|
function slow(setupFunction) {
|
|
return () => {
|
|
setupFunction();
|
|
// Trigger RegExp slow paths.
|
|
const regExpExec = re.exec;
|
|
re.exec = (str) => regExpExec.call(re, str);
|
|
};
|
|
}
|
|
|
|
function createHaystack() {
|
|
let s = "abCdefgz";
|
|
for (let i = 0; i < 3; i++) s += s;
|
|
return s;
|
|
}
|
|
|
|
function createBenchmarkSuite(name) {
|
|
return new BenchmarkSuite(
|
|
name, [1000],
|
|
benchmarks.map(([bench, setup]) =>
|
|
new Benchmark(benchName(bench, setup), false, false, 100000, bench,
|
|
setup)));
|
|
}
|
|
|
|
function createSlowBenchmarkSuite(name) {
|
|
return new BenchmarkSuite(
|
|
"Slow" + name, [1000],
|
|
benchmarks.map(([bench, setup]) =>
|
|
new Benchmark(slowBenchName(bench, setup), false, false, 0, bench,
|
|
slow(setup))));
|
|
}
|