f36ecaf3a4
By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. Review URL: https://codereview.chromium.org/1053143005 Cr-Commit-Position: refs/heads/master@{#28215}
76 lines
3.1 KiB
JavaScript
76 lines
3.1 KiB
JavaScript
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --allow-natives-syntax --noalways-opt
|
|
|
|
// Test that a -0 result doesn't cause deopt loops
|
|
function noDeoptLoop(x) {
|
|
return Math.ceil(x);
|
|
}
|
|
assertEquals(1, noDeoptLoop(0.4));
|
|
assertEquals(1, noDeoptLoop(0.4));
|
|
assertEquals(1, noDeoptLoop(0.4));
|
|
%OptimizeFunctionOnNextCall(noDeoptLoop);
|
|
assertEquals(1, noDeoptLoop(0.4));
|
|
assertEquals(1, noDeoptLoop(0.4));
|
|
assertEquals(-Infinity, 1/noDeoptLoop(-0.0));
|
|
assertEquals(-Infinity, 1/noDeoptLoop(-0.0));
|
|
assertUnoptimized(noDeoptLoop);
|
|
assertEquals(-Infinity, 1/noDeoptLoop(-0.0));
|
|
assertEquals(-1.0, 1/noDeoptLoop(-1.0));
|
|
assertEquals(Infinity, 1/noDeoptLoop(0));
|
|
%OptimizeFunctionOnNextCall(noDeoptLoop);
|
|
assertEquals(-Infinity, 1/noDeoptLoop(-0.0));
|
|
assertEquals(-Infinity, 1/noDeoptLoop(-0.1));
|
|
assertOptimized(noDeoptLoop);
|
|
%ClearFunctionTypeFeedback(noDeoptLoop);
|
|
%DeoptimizeFunction(noDeoptLoop);
|
|
|
|
// Test that ceil that goes megamorphic is handled correctly.
|
|
function notCeil(x) {
|
|
return -x;
|
|
}
|
|
function testMega(f, x) {
|
|
return f(x);
|
|
}
|
|
assertEquals(8, testMega(Math.ceil, 7.4));
|
|
assertEquals(8, testMega(Math.ceil, 7.4));
|
|
assertEquals(8, testMega(Math.ceil, 7.4));
|
|
assertEquals(-7.4, testMega(notCeil, 7.4));
|
|
|
|
// Make sure that we can learn about ceil specialization from Cranskhaft, which
|
|
// doesn't insert soft deopts for CallICs.
|
|
function crankCeilLearn(x) {
|
|
return Math.ceil(x);
|
|
}
|
|
%OptimizeFunctionOnNextCall(crankCeilLearn);
|
|
assertEquals(12, crankCeilLearn(11.3));
|
|
assertOptimized(crankCeilLearn);
|
|
assertEquals(-Infinity, 1/crankCeilLearn(-0.0));
|
|
assertOptimized(crankCeilLearn);
|
|
assertEquals(-Infinity, 1/crankCeilLearn(-0.75));
|