Leszek Swirski 94cd8b6459 Revert "Reland "Improve error messages for property access on null/undefined"" ... This reverts commit 8b18c5e6a5. Reason for revert: Still failing: https://test-results.appspot.com/data/layout_results/V8_Blink_Linux/12469/blink_web_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html Original change's description: > Reland "Improve error messages for property access on null/undefined" > > This is a reland of 24c626c1f7 > > Original change's description: > > Improve error messages for property access on null/undefined > > > > Only print the property name when accessing null/undefined if we can > > convert it to a string without causing side effects. > > If we can't, omit the property name in the error message. > > This should avoid confusion when the key is an object with toString(). > > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object > > Object]' anymore, which was misleading since the property accessed would > > be 'a', but we can't evaluate the key without side effects. > > > > Bug: v8:11365 > > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75250} > > Bug: v8:11365 > Change-Id: Ie2312337f4f1915faa31528a728d90833d80dbd1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979599 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75571} Bug: v8:11365 Change-Id: Ic4137f0d70fa9b10ca70fa921b98ea7e1499f11b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008217 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75577}		2021-07-06 09:46:11 +00:00
..
bugs/harmony	[debug-wrapper] migrate some scope related tests	2016-12-14 07:20:33 +00:00
debug	Revert "Reland "Improve error messages for property access on null/undefined""	2021-07-06 09:46:11 +00:00
protocol	[debugger] basic test infrastructure for new debugger test api.	2016-10-21 06:38:05 +00:00
regress	[d8][mjsunit][tools] Improve d8 file API	2021-06-01 13:37:57 +00:00
wrapper	[debugger] Various break-related functionality in test wrapper	2016-10-28 08:18:34 +00:00
BUILD.gn	[build] Add data deps for d8 test suites	2018-03-26 13:44:58 +00:00
debugger.status	[mips][sparkplug] Port Sparkplug to mips and mips64	2021-06-11 10:53:43 +00:00
OWNERS	Use relative paths to OWNERS files	2019-08-12 13:52:52 +00:00
test-api.js	[debug][cleanup] Use consistent StepInto and StepOver naming.	2021-06-01 11:26:57 +00:00
testcfg.py	[test] Remove module pragma in favor of .mjs	2019-06-27 13:25:48 +00:00