3002ff44ee
Prior to this CL, call counts at function scope were taken from the FeedbackVector::invocation_count field. This had two major drawbacks: 1. for generator functions, these count the number of resumptions instead of the number of calls; and 2. the invocation count is not maintained in optimized code. The solution implemented here is to add a dedicated call counter at function scope which is incremented exactly once each time the function is called. A minor complication is that our coverage output format expects function-scope counts in the dedicated CoverageFunction object, and not as a CoverageBlock. Thus function-scope block counts are initially marked with magic positions, and later recognized and rewritten during processing. This CL thus fixes reported generator function call counts and enables optimizations in block coverage modes (more to come in a follow-up). Drive-by: Don't report functions with empty source ranges. Bug: v8:6000,v8:9148,v8:9212 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Idbe5edb35a595cf12b6649314738ac00efd173b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613996 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61574}
51 lines
1.8 KiB
JavaScript
51 lines
1.8 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --no-always-opt --opt
|
|
// Flags: --no-stress-flush-bytecode --turbo-inlining
|
|
// Files: test/mjsunit/code-coverage-utils.js
|
|
|
|
if (isNeverOptimizeLiteMode()) {
|
|
print("Warning: skipping test that requires optimization in Lite mode.");
|
|
testRunner.quit(0);
|
|
}
|
|
|
|
%DebugToggleBlockCoverage(true);
|
|
|
|
TestCoverage(
|
|
"optimized and inlined functions",
|
|
`
|
|
function g() { if (true) nop(); } // 0000
|
|
function f() { g(); g(); } // 0050
|
|
f(); f(); %OptimizeFunctionOnNextCall(f); // 0100
|
|
f(); f(); f(); f(); f(); f(); // 0150
|
|
`,
|
|
[{"start":0,"end":199,"count":1},
|
|
{"start":0,"end":33,"count":16},
|
|
{"start":50,"end":76,"count":8}]
|
|
);
|
|
|
|
// This test is tricky: it requires a non-toplevel, optimized function.
|
|
// After initial collection, counts are cleared. Further invocation_counts
|
|
// are not collected for optimized functions, and on the next coverage
|
|
// collection we and up with an uncovered function with an uncovered parent
|
|
// but with non-trivial block coverage.
|
|
TestCoverage("Partial coverage collection",
|
|
`
|
|
!function() { // 0000
|
|
function f(x) { // 0050
|
|
if (x) { nop(); } else { nop(); } // 0100
|
|
} // 0150
|
|
f(true); f(true); // 0200
|
|
%OptimizeFunctionOnNextCall(f); // 0250
|
|
%DebugCollectCoverage(); // 0300
|
|
f(false); // 0350
|
|
}(); // 0400
|
|
`,
|
|
[{"start":52,"end":153,"count":1},
|
|
{"start":111,"end":121,"count":0}]
|
|
);
|
|
|
|
%DebugToggleBlockCoverage(false);
|