ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
56 lines
2.3 KiB
C++
56 lines
2.3 KiB
C++
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/v8-isolate.h"
|
|
#include "src/heap/heap.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace v8 {
|
|
|
|
TEST(ResourceConstraints, ConfigureDefaultsFromHeapSizeSmall) {
|
|
const size_t KB = static_cast<size_t>(i::KB);
|
|
const size_t MB = static_cast<size_t>(i::MB);
|
|
const size_t pm = i::Heap::kPointerMultiplier;
|
|
v8::ResourceConstraints constraints;
|
|
constraints.ConfigureDefaultsFromHeapSize(1 * MB, 1 * MB);
|
|
ASSERT_EQ(i::Heap::MinOldGenerationSize(),
|
|
constraints.max_old_generation_size_in_bytes());
|
|
ASSERT_EQ(3 * 512 * pm * KB,
|
|
constraints.max_young_generation_size_in_bytes());
|
|
ASSERT_EQ(0u, constraints.initial_old_generation_size_in_bytes());
|
|
ASSERT_EQ(0u, constraints.initial_young_generation_size_in_bytes());
|
|
}
|
|
|
|
TEST(ResourceConstraints, ConfigureDefaultsFromHeapSizeLarge) {
|
|
const size_t KB = static_cast<size_t>(i::KB);
|
|
const size_t MB = static_cast<size_t>(i::MB);
|
|
const size_t pm = i::Heap::kPointerMultiplier;
|
|
v8::ResourceConstraints constraints;
|
|
constraints.ConfigureDefaultsFromHeapSize(100u * MB, 3000u * MB);
|
|
ASSERT_EQ(3000u * MB - 3 * 8192 * pm * KB,
|
|
constraints.max_old_generation_size_in_bytes());
|
|
ASSERT_EQ(3 * 8192 * pm * KB,
|
|
constraints.max_young_generation_size_in_bytes());
|
|
ASSERT_EQ(100u * MB - 3 * 512 * pm * KB,
|
|
constraints.initial_old_generation_size_in_bytes());
|
|
ASSERT_EQ(3 * 512 * pm * KB,
|
|
constraints.initial_young_generation_size_in_bytes());
|
|
}
|
|
|
|
TEST(ResourceConstraints, ConfigureDefaults) {
|
|
const size_t KB = static_cast<size_t>(i::KB);
|
|
const size_t MB = static_cast<size_t>(i::MB);
|
|
const size_t pm = i::Heap::kPointerMultiplier;
|
|
const size_t hlm = i::Heap::kHeapLimitMultiplier;
|
|
v8::ResourceConstraints constraints;
|
|
constraints.ConfigureDefaults(2048u * MB, 0u);
|
|
ASSERT_EQ(512u * hlm * MB, constraints.max_old_generation_size_in_bytes());
|
|
ASSERT_EQ(3 * 4096 * pm * KB,
|
|
constraints.max_young_generation_size_in_bytes());
|
|
ASSERT_EQ(0u, constraints.initial_old_generation_size_in_bytes());
|
|
ASSERT_EQ(0u, constraints.initial_young_generation_size_in_bytes());
|
|
}
|
|
|
|
} // namespace v8
|