1c2c2f43cd
Removes all accesses to the Isolate during bytecode generation and the bytecode pipeline. Adds an DisallowIsolateAccessScope which is used to enforce this invariant within the BytecodeGenerator. BUG=v8:5203 Review-Url: https://codereview.chromium.org/2242193002 Cr-Commit-Position: refs/heads/master@{#38716}
294 lines
12 KiB
C++
294 lines
12 KiB
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/interpreter/interpreter-intrinsics.h"
|
|
#include "test/cctest/interpreter/interpreter-tester.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace interpreter {
|
|
|
|
namespace {
|
|
|
|
class InvokeIntrinsicHelper {
|
|
public:
|
|
InvokeIntrinsicHelper(Isolate* isolate, Zone* zone,
|
|
Runtime::FunctionId function_id)
|
|
: isolate_(isolate),
|
|
zone_(zone),
|
|
factory_(isolate->factory()),
|
|
function_id_(function_id) {}
|
|
|
|
template <class... A>
|
|
Handle<Object> Invoke(A... args) {
|
|
CHECK(IntrinsicsHelper::IsSupported(function_id_));
|
|
BytecodeArrayBuilder builder(isolate_, zone_, sizeof...(args), 0, 0);
|
|
builder.CallRuntime(function_id_, builder.Parameter(0), sizeof...(args))
|
|
.Return();
|
|
InterpreterTester tester(isolate_, builder.ToBytecodeArray(isolate_));
|
|
auto callable = tester.GetCallable<A...>();
|
|
return callable(args...).ToHandleChecked();
|
|
}
|
|
|
|
Handle<Object> NewObject(const char* script) {
|
|
return v8::Utils::OpenHandle(*CompileRun(script));
|
|
}
|
|
|
|
Handle<Object> Undefined() { return factory_->undefined_value(); }
|
|
Handle<Object> Null() { return factory_->null_value(); }
|
|
|
|
private:
|
|
Isolate* isolate_;
|
|
Zone* zone_;
|
|
Factory* factory_;
|
|
Runtime::FunctionId function_id_;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
TEST(IsJSReceiver) {
|
|
HandleAndZoneScope handles;
|
|
|
|
InvokeIntrinsicHelper helper(handles.main_isolate(), handles.main_zone(),
|
|
Runtime::kInlineIsJSReceiver);
|
|
Factory* factory = handles.main_isolate()->factory();
|
|
|
|
CHECK_EQ(*factory->true_value(),
|
|
*helper.Invoke(helper.NewObject("new Date()")));
|
|
CHECK_EQ(*factory->true_value(),
|
|
*helper.Invoke(helper.NewObject("(function() {})")));
|
|
CHECK_EQ(*factory->true_value(), *helper.Invoke(helper.NewObject("([1])")));
|
|
CHECK_EQ(*factory->true_value(), *helper.Invoke(helper.NewObject("({})")));
|
|
CHECK_EQ(*factory->true_value(), *helper.Invoke(helper.NewObject("(/x/)")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Undefined()));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Null()));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("'string'")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("42")));
|
|
}
|
|
|
|
TEST(IsArray) {
|
|
HandleAndZoneScope handles;
|
|
|
|
InvokeIntrinsicHelper helper(handles.main_isolate(), handles.main_zone(),
|
|
Runtime::kInlineIsArray);
|
|
Factory* factory = handles.main_isolate()->factory();
|
|
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("new Date()")));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("(function() {})")));
|
|
CHECK_EQ(*factory->true_value(), *helper.Invoke(helper.NewObject("([1])")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("({})")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("(/x/)")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Undefined()));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Null()));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("'string'")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("42")));
|
|
}
|
|
|
|
TEST(IsJSProxy) {
|
|
HandleAndZoneScope handles;
|
|
|
|
InvokeIntrinsicHelper helper(handles.main_isolate(), handles.main_zone(),
|
|
Runtime::kInlineIsJSProxy);
|
|
Factory* factory = handles.main_isolate()->factory();
|
|
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("new Date()")));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("(function() {})")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("([1])")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("({})")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("(/x/)")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Undefined()));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Null()));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("'string'")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("42")));
|
|
CHECK_EQ(*factory->true_value(),
|
|
*helper.Invoke(helper.NewObject("new Proxy({},{})")));
|
|
}
|
|
|
|
TEST(IsRegExp) {
|
|
HandleAndZoneScope handles;
|
|
|
|
InvokeIntrinsicHelper helper(handles.main_isolate(), handles.main_zone(),
|
|
Runtime::kInlineIsRegExp);
|
|
Factory* factory = handles.main_isolate()->factory();
|
|
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("new Date()")));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("(function() {})")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("([1])")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("({})")));
|
|
CHECK_EQ(*factory->true_value(), *helper.Invoke(helper.NewObject("(/x/)")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Undefined()));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Null()));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("'string'")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("42")));
|
|
}
|
|
|
|
TEST(IsTypedArray) {
|
|
HandleAndZoneScope handles;
|
|
|
|
InvokeIntrinsicHelper helper(handles.main_isolate(), handles.main_zone(),
|
|
Runtime::kInlineIsTypedArray);
|
|
Factory* factory = handles.main_isolate()->factory();
|
|
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("new Date()")));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("(function() {})")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("([1])")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("({})")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("(/x/)")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Undefined()));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Null()));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("'string'")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("42")));
|
|
|
|
CHECK_EQ(
|
|
*factory->true_value(),
|
|
*helper.Invoke(helper.NewObject("new Uint8Array(new ArrayBuffer(1));")));
|
|
CHECK_EQ(
|
|
*factory->true_value(),
|
|
*helper.Invoke(helper.NewObject("new Uint16Array(new ArrayBuffer(2));")));
|
|
CHECK_EQ(
|
|
*factory->true_value(),
|
|
*helper.Invoke(helper.NewObject("new Int32Array(new ArrayBuffer(4));")));
|
|
}
|
|
|
|
TEST(IsSmi) {
|
|
HandleAndZoneScope handles;
|
|
|
|
InvokeIntrinsicHelper helper(handles.main_isolate(), handles.main_zone(),
|
|
Runtime::kInlineIsSmi);
|
|
Factory* factory = handles.main_isolate()->factory();
|
|
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("new Date()")));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("(function() {})")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("([1])")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("({})")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("(/x/)")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Undefined()));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.Null()));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("'string'")));
|
|
CHECK_EQ(*factory->false_value(), *helper.Invoke(helper.NewObject("42.2")));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("4294967297")));
|
|
CHECK_EQ(*factory->true_value(), *helper.Invoke(helper.NewObject("42")));
|
|
}
|
|
|
|
TEST(Call) {
|
|
HandleAndZoneScope handles;
|
|
Isolate* isolate = handles.main_isolate();
|
|
Factory* factory = isolate->factory();
|
|
InvokeIntrinsicHelper helper(isolate, handles.main_zone(),
|
|
Runtime::kInlineCall);
|
|
|
|
CHECK_EQ(Smi::FromInt(20),
|
|
*helper.Invoke(helper.NewObject("(function() { return this.x; })"),
|
|
helper.NewObject("({ x: 20 })")));
|
|
CHECK_EQ(Smi::FromInt(50),
|
|
*helper.Invoke(helper.NewObject("(function(arg1) { return arg1; })"),
|
|
factory->undefined_value(),
|
|
handle(Smi::FromInt(50), isolate)));
|
|
CHECK_EQ(
|
|
Smi::FromInt(20),
|
|
*helper.Invoke(
|
|
helper.NewObject("(function(a, b, c) { return a + b + c; })"),
|
|
factory->undefined_value(), handle(Smi::FromInt(10), isolate),
|
|
handle(Smi::FromInt(7), isolate), handle(Smi::FromInt(3), isolate)));
|
|
}
|
|
|
|
TEST(IntrinsicAsStubCall) {
|
|
HandleAndZoneScope handles;
|
|
Isolate* isolate = handles.main_isolate();
|
|
Factory* factory = isolate->factory();
|
|
InvokeIntrinsicHelper to_number_helper(isolate, handles.main_zone(),
|
|
Runtime::kInlineToNumber);
|
|
CHECK_EQ(Smi::FromInt(46),
|
|
*to_number_helper.Invoke(to_number_helper.NewObject("'46'")));
|
|
|
|
InvokeIntrinsicHelper to_integer_helper(isolate, handles.main_zone(),
|
|
Runtime::kInlineToInteger);
|
|
CHECK_EQ(Smi::FromInt(502),
|
|
*to_integer_helper.Invoke(to_integer_helper.NewObject("502.67")));
|
|
|
|
InvokeIntrinsicHelper has_property_helper(isolate, handles.main_zone(),
|
|
Runtime::kInlineHasProperty);
|
|
CHECK_EQ(*factory->true_value(),
|
|
*has_property_helper.Invoke(
|
|
has_property_helper.NewObject("'x'"),
|
|
has_property_helper.NewObject("({ x: 20 })")));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*has_property_helper.Invoke(
|
|
has_property_helper.NewObject("'y'"),
|
|
has_property_helper.NewObject("({ x: 20 })")));
|
|
|
|
InvokeIntrinsicHelper sub_string_helper(isolate, handles.main_zone(),
|
|
Runtime::kInlineSubString);
|
|
CHECK(sub_string_helper
|
|
.Invoke(sub_string_helper.NewObject("'foobar'"),
|
|
sub_string_helper.NewObject("3"),
|
|
sub_string_helper.NewObject("6"))
|
|
->SameValue(*sub_string_helper.NewObject("'bar'")));
|
|
}
|
|
|
|
TEST(ValueOf) {
|
|
HandleAndZoneScope handles;
|
|
Isolate* isolate = handles.main_isolate();
|
|
Factory* factory = isolate->factory();
|
|
InvokeIntrinsicHelper helper(handles.main_isolate(), handles.main_zone(),
|
|
Runtime::kInlineValueOf);
|
|
|
|
CHECK_EQ(Smi::FromInt(1234), *helper.Invoke(helper.NewObject("1234")));
|
|
CHECK_EQ(Smi::FromInt(5678),
|
|
*helper.Invoke(helper.NewObject("new Object(5678)")));
|
|
|
|
CHECK_EQ(*factory->true_value(), *helper.Invoke(helper.NewObject("true")));
|
|
CHECK_EQ(*factory->false_value(),
|
|
*helper.Invoke(helper.NewObject("new Object(false)")));
|
|
|
|
CHECK(helper.Invoke(helper.NewObject("'foobar'"))
|
|
->SameValue(*helper.NewObject("'foobar'")));
|
|
CHECK(helper.Invoke(helper.NewObject("new Object('foobar')"))
|
|
->SameValue(*helper.NewObject("'foobar'")));
|
|
}
|
|
|
|
TEST(ClassOf) {
|
|
HandleAndZoneScope handles;
|
|
Isolate* isolate = handles.main_isolate();
|
|
Factory* factory = isolate->factory();
|
|
InvokeIntrinsicHelper helper(handles.main_isolate(), handles.main_zone(),
|
|
Runtime::kInlineClassOf);
|
|
CHECK_EQ(*helper.Invoke(helper.NewObject("123")), *factory->null_value());
|
|
CHECK_EQ(*helper.Invoke(helper.NewObject("'true'")), *factory->null_value());
|
|
CHECK_EQ(*helper.Invoke(helper.NewObject("'foo'")), *factory->null_value());
|
|
CHECK(helper.Invoke(helper.NewObject("({a:1})"))
|
|
->SameValue(*helper.NewObject("'Object'")));
|
|
CHECK(helper.Invoke(helper.NewObject("(function foo() {})"))
|
|
->SameValue(*helper.NewObject("'Function'")));
|
|
CHECK(helper.Invoke(helper.NewObject("new Date()"))
|
|
->SameValue(*helper.NewObject("'Date'")));
|
|
CHECK(helper.Invoke(helper.NewObject("new Set"))
|
|
->SameValue(*helper.NewObject("'Set'")));
|
|
CHECK(helper.Invoke(helper.NewObject("/x/"))
|
|
->SameValue(*helper.NewObject("'RegExp'")));
|
|
}
|
|
|
|
} // namespace interpreter
|
|
} // namespace internal
|
|
} // namespace v8
|