438e7ec6dc
This is a reland of5c3092718e
(the CL was reverted because of a Chromium test that is now fixed) Original change's description: > Reland "[asmjs] Properly validate asm.js heap sizes" > > This is a reland of5d69010e26
> > Original change's description: > > [asmjs] Properly validate asm.js heap sizes > > > > Enforce both engine limitations and spec (http://asmjs.org/spec/latest/) > > limitations on the size of asm.js heaps. > > > > R=clemensh@chromium.org > > CC=mstarzinger@chromium.org > > > > Bug: chromium:873600 > > Change-Id: I104c23bbd0a9a7c494f97f8f9e83ac5a37496dfd > > Reviewed-on: https://chromium-review.googlesource.com/1174411 > > Commit-Queue: Ben Titzer <titzer@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#55163} > > Bug: chromium:873600 > Change-Id: Id24070bda3aafb9e1a32af0732a1b18f633ef932 > Reviewed-on: https://chromium-review.googlesource.com/1179681 > Commit-Queue: Ben Titzer <titzer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55193} Bug: chromium:873600 Change-Id: I6eca2a89589070837b109278f964fc8e9a0fd6f1 Reviewed-on: https://chromium-review.googlesource.com/1183081 Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55249}
93 lines
2.4 KiB
JavaScript
93 lines
2.4 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
let kMinHeapSize = 4096;
|
|
|
|
(function TestLeftRight() {
|
|
function Module(stdlib, foreign, heap) {
|
|
"use asm";
|
|
var HEAP32 = new stdlib.Int32Array(heap);
|
|
function f(i) {
|
|
i = i | 0;
|
|
return HEAP32[i << 2 >> 2] | 0;
|
|
}
|
|
return { f:f }
|
|
}
|
|
var buffer = new ArrayBuffer(kMinHeapSize);
|
|
var module = new Module(this, {}, buffer);
|
|
assertTrue(%IsAsmWasmCode(Module));
|
|
new Int32Array(buffer)[42] = 23;
|
|
assertEquals(23, module.f(42));
|
|
})();
|
|
|
|
(function TestRightRight() {
|
|
function Module(stdlib, foreign, heap) {
|
|
"use asm";
|
|
var HEAP32 = new stdlib.Int32Array(heap);
|
|
function f(i) {
|
|
i = i | 0;
|
|
return HEAP32[i >> 2 >> 2] | 0;
|
|
}
|
|
return { f:f }
|
|
}
|
|
var buffer = new ArrayBuffer(kMinHeapSize);
|
|
var module = new Module(this, {}, buffer)
|
|
assertTrue(%IsAsmWasmCode(Module));
|
|
new Int32Array(buffer)[42 >> 4] = 23;
|
|
assertEquals(23, module.f(42));
|
|
})();
|
|
|
|
(function TestRightLeft() {
|
|
function Module(stdlib, foreign, heap) {
|
|
"use asm";
|
|
var HEAP32 = new stdlib.Int32Array(heap);
|
|
function f(i) {
|
|
i = i | 0;
|
|
return HEAP32[i >> 2 << 2] | 0;
|
|
}
|
|
return { f:f }
|
|
}
|
|
var buffer = new ArrayBuffer(kMinHeapSize);
|
|
var module = new Module(this, {}, buffer)
|
|
assertFalse(%IsAsmWasmCode(Module));
|
|
new Int32Array(buffer)[42 & 0xfc] = 23;
|
|
assertEquals(23, module.f(42));
|
|
})();
|
|
|
|
(function TestRightButNotImmediate() {
|
|
function Module(stdlib, foreign, heap) {
|
|
"use asm";
|
|
var HEAP32 = new stdlib.Int32Array(heap);
|
|
function f(i) {
|
|
i = i | 0;
|
|
return HEAP32[i >> 2 + 1] | 0;
|
|
}
|
|
return { f:f }
|
|
}
|
|
var buffer = new ArrayBuffer(kMinHeapSize);
|
|
var module = new Module(this, {}, buffer)
|
|
assertFalse(%IsAsmWasmCode(Module));
|
|
new Int32Array(buffer)[42 >> 3] = 23;
|
|
assertEquals(23, module.f(42));
|
|
})();
|
|
|
|
(function TestLeftOnly() {
|
|
function Module(stdlib, foreign, heap) {
|
|
"use asm";
|
|
var HEAP32 = new stdlib.Int32Array(heap);
|
|
function f(i) {
|
|
i = i | 0;
|
|
return HEAP32[i << 2] | 0;
|
|
}
|
|
return { f:f }
|
|
}
|
|
var buffer = new ArrayBuffer(kMinHeapSize);
|
|
var module = new Module(this, {}, buffer)
|
|
assertFalse(%IsAsmWasmCode(Module));
|
|
new Int32Array(buffer)[42 << 2] = 23;
|
|
assertEquals(23, module.f(42));
|
|
})();
|