7467f16d73
The new NewUnmappedArgumentsElements node now takes two inputs: - the frame holding the arguments (current frame or arguments adaptor frame) - the length of the suffix of passed arguments to be copied into the backing store These inputs are computed with two new node types: ArgumentsFrame() ArgumentsLength[formal_parameter_count,is_rest_length](Node* arguments_frame) The node type NewRestParameterElements can now be expressed with NewUnmappedArgumentsElements and an appropriate length and is thus not needed anymore. In escape analysis, we lower loads from the length field of NewUnmappedArgumentsElements with its length input and if we find out that no write access to the arguments elements exists, we replace element loads with direct stack access and replace the NewUnmappedArgumentsElements node with a node of the new node type ArgumentsElementsState. This corresponds to an ObjectState node and gets translated into a deoptimizer instruction to allocate the backing store. Together with the already existing deoptimizer support for the actual arguments object/rest parameters, this allows to remove all allocations for arguments objects/rest parameters in this case. In the deoptimizer, we read the actual parameters from the stack while transforming the static deopt info into TranslatedValue objects. If escape analysis cannot remove the backing store allocation, NewUnmappedArgumentsElements gets lo BUG=v8:5726 Review-Url: https://codereview.chromium.org/2692753004 Cr-Commit-Position: refs/heads/master@{#43475}
170 lines
3.7 KiB
JavaScript
170 lines
3.7 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --turbo
|
|
|
|
(function MaterializeStrictArguments() {
|
|
"use strict"
|
|
|
|
function f(x, y) {
|
|
return x + y;
|
|
}
|
|
|
|
function test1() {
|
|
%DeoptimizeNow();
|
|
return f.apply(null, arguments);
|
|
}
|
|
|
|
assertEquals(test1(1, 2), 3);
|
|
assertEquals(test1(1, 2, 3), 3);
|
|
|
|
%OptimizeFunctionOnNextCall(test1);
|
|
assertEquals(test1(1, 2), 3);
|
|
%OptimizeFunctionOnNextCall(test1);
|
|
assertEquals(test1(1, 2, 3), 3);
|
|
})();
|
|
|
|
(function MaterializeSloppyArguments() {
|
|
function f(x, y) {
|
|
return x + y;
|
|
}
|
|
|
|
function test2() {
|
|
%DeoptimizeNow();
|
|
return f.apply(null, arguments);
|
|
}
|
|
|
|
assertEquals(test2(1, 2), 3);
|
|
assertEquals(test2(1, 2, 3), 3);
|
|
|
|
%OptimizeFunctionOnNextCall(test2);
|
|
assertEquals(test2(1, 2), 3);
|
|
%OptimizeFunctionOnNextCall(test2);
|
|
assertEquals(test2(1, 2, 3), 3);
|
|
})();
|
|
|
|
(function MaterializeStrictOverwrittenArguments() {
|
|
"use strict"
|
|
|
|
function f(x, y) {
|
|
return x + y;
|
|
}
|
|
|
|
function test3(a, b) {
|
|
a = 4;
|
|
%DeoptimizeNow();
|
|
return f.apply(null, arguments);
|
|
}
|
|
|
|
assertEquals(test3(1, 2), 3);
|
|
assertEquals(test3(1, 2, 3), 3);
|
|
|
|
%OptimizeFunctionOnNextCall(test3);
|
|
assertEquals(test3(11, 12), 23);
|
|
%OptimizeFunctionOnNextCall(test3);
|
|
assertEquals(test3(11, 12, 13), 23);
|
|
})();
|
|
|
|
(function MaterializeSloppyOverwrittenArguments() {
|
|
function f(x, y) {
|
|
return x + y;
|
|
}
|
|
|
|
function test4(a, b) {
|
|
a = 4;
|
|
%DeoptimizeNow();
|
|
return f.apply(null, arguments);
|
|
}
|
|
|
|
test4(1, 2);
|
|
test4(3, 4, 5);
|
|
|
|
assertEquals(test4(1, 2), 6);
|
|
assertEquals(test4(1, 2, 3), 6);
|
|
|
|
%OptimizeFunctionOnNextCall(test4);
|
|
assertEquals(test4(1, 2), 6);
|
|
%OptimizeFunctionOnNextCall(test4);
|
|
assertEquals(test4(1, 2, 3), 6);
|
|
})();
|
|
|
|
(function ArgumentsAccessStrict () {
|
|
"use strict"
|
|
function sum1(a,b,c) {
|
|
var sum = 0;
|
|
var rest = arguments;
|
|
for (var i = 0; i < rest.length; ++i) {
|
|
var j = i;
|
|
if (rest.length % 15 == 0 && i == 10) j += rest.length;
|
|
sum += rest[j] || rest[j-rest.length];
|
|
}
|
|
return sum;
|
|
};
|
|
|
|
var args = []
|
|
for (var i = 1; i < 30; ++i) {
|
|
args.push(i);
|
|
if (i%10 == 0) %OptimizeFunctionOnNextCall(sum1);
|
|
assertEquals(i*(i+1)/2, sum1(...args));
|
|
}
|
|
})();
|
|
|
|
(function ArgumentsAccessSloppy () {
|
|
function sum2(a,b,c) {
|
|
var sum = 0;
|
|
var rest = arguments;
|
|
for (var i = 0; i < rest.length; ++i) {
|
|
var j = i;
|
|
if (rest.length % 15 == 0 && i == 10) j += rest.length;
|
|
sum += rest[j] || rest[j-rest.length];
|
|
}
|
|
return sum;
|
|
};
|
|
|
|
var args = []
|
|
for (var i = 1; i < 30; ++i) {
|
|
args.push(i);
|
|
if (i%10 == 0) %OptimizeFunctionOnNextCall(sum2);
|
|
assertEquals(i*(i+1)/2, sum2(...args));
|
|
}
|
|
})();
|
|
|
|
(function RestAccess0 () {
|
|
function sum3(...rest) {
|
|
var sum = 0;
|
|
for (var i = 0; i < rest.length; ++i) {
|
|
var j = i;
|
|
if (rest.length % 15 == 0 && i == 10) j += rest.length;
|
|
sum += rest[j] || rest[j-rest.length];
|
|
}
|
|
return sum;
|
|
};
|
|
|
|
var args = []
|
|
for (var i = 1; i < 30; ++i) {
|
|
args.push(i);
|
|
if (i%10 == 0) %OptimizeFunctionOnNextCall(sum3);
|
|
assertEquals(i*(i+1)/2, sum3(...args));
|
|
}
|
|
})();
|
|
|
|
(function RestAccess1 () {
|
|
function sum4(a,...rest) {
|
|
var sum = 0;
|
|
for (var i = 0; i < rest.length; ++i) {
|
|
var j = i;
|
|
if (rest.length % 15 == 0 && i == 10) j += rest.length;
|
|
sum += rest[j] || rest[j-rest.length];
|
|
}
|
|
return sum;
|
|
};
|
|
|
|
var args = []
|
|
for (var i = 1; i < 30; ++i) {
|
|
args.push(i);
|
|
if (i%10 == 0) %OptimizeFunctionOnNextCall(sum4);
|
|
assertEquals(i*(i+1)/2-1, sum4(...args));
|
|
}
|
|
})();
|