539979f4a9
Promise.{all,allSettled,any,race} should check resolve is a function before
opening their iteratable.
PR: https://github.com/tc39/ecma262/pull/1912
PR for Promise.any: https://github.com/tc39/proposal-promise-any/pull/65
This CL includes the following cleanup changes:
- Made it more explicit that the constructor is a Constructor.
- Removed unnecessary nested try blocks (a try can have both a catch and a label).
- Moved commonly used definitions out of promise-race.tq where they don't belong.
- Made the parameter order of PerformPromiseAll match the spec.
Bug: v8:10578
Change-Id: I9deb5d5106db7350a0d0ad52f165ff2469e7074b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232544
Commit-Queue: Marja Hölttä <marja@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68260}
27 lines
666 B
JavaScript
27 lines
666 B
JavaScript
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
load('test/mjsunit/test-async.js');
|
|
|
|
// Promise.race should not call GetIterator if Promise.resolve is not callable.
|
|
|
|
let getIteratorCount = 0;
|
|
let iter = {
|
|
get [Symbol.iterator]() {
|
|
++getIteratorCount;
|
|
}
|
|
};
|
|
|
|
Promise.resolve = "certainly not callable";
|
|
|
|
testAsync(assert => {
|
|
assert.plan(2);
|
|
Promise.race(iter).then(assert.unreachable, reason => {
|
|
assert.equals(true, reason instanceof TypeError);
|
|
assert.equals(0, getIteratorCount);
|
|
});
|
|
});
|