v8/test
Clemens Backes d1462a56ec Revert "[wasm] Prevent breakpoints on nonbreakable positions"
This reverts commit 3c98a2a36a.

Reason for revert: Fails on arm: https://ci.chromium.org/p/v8/builders/ci/V8%20Arm%20-%20debug/12134

Original change's description:
> [wasm] Prevent breakpoints on nonbreakable positions
> 
> If a breakpoint is set on a non-breakable position, the wasm interpreter
> just stores the value 0xFF (kInternalBreakpoint) in the function body
> (actually, a copy of the function body). This might overwrite immediates
> and cause subsequent failures in the wasm interpreter.
> 
> In JavaScript, breakpoints are just forwarded to the next breakable
> position. This CL implements the same for WebAssembly.
> A cctest tests this behavior, and the existing
> wasm-stepping-byte-offsets.js inspector test is extended to also set the
> breakpoint within an i32 constant immediate.
> 
> R=​leese@chromium.org, mstarzinger@chromium.org
> CC=​​bmeurer@chromium.org
> 
> Bug: chromium:1025184
> Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152
> Commit-Queue: Clemens Backes <clemensb@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#65070}

TBR=mstarzinger@chromium.org,clemensb@chromium.org,bmeurer@chromium.org,leese@chromium.org

Change-Id: I7468ea3b15fecccdea521308325cf4851e0a0396
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1025184
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926032
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65074}
2019-11-20 15:51:41 +00:00
..
benchmarks Remove 'embedded_builtins' variant 2019-10-22 12:58:02 +00:00
cctest Revert "[wasm] Prevent breakpoints on nonbreakable positions" 2019-11-20 15:51:41 +00:00
common [codegen] Reduce kMinimalBufferSize and add kDefaultBufferSize 2019-11-14 15:05:31 +00:00
debugger [wasm] Support stepping into Wasm from Javascript 2019-11-18 19:59:32 +00:00
fuzzer [wasm] Remove one {NewNativeModule} method 2019-11-07 18:07:29 +00:00
inspector Revert "[wasm] Prevent breakpoints on nonbreakable positions" 2019-11-20 15:51:41 +00:00
intl [Intl] Prototype Intl.DisplayNames 2019-11-18 21:48:22 +00:00
js-perf-test [js-perf-tests] Adds performance tests for BigInt subtraction 2019-10-22 13:32:09 +00:00
memory [owners] Remove redundant OWNERS files in test/ 2019-06-24 12:44:32 +00:00
message V8 Wasm locations should always be based on byte offsets 2019-11-05 14:53:45 +00:00
mjsunit [wasm][bulk-memory] Change bounds checks behavior 2019-11-20 15:07:17 +00:00
mkgrokdump [heap] Enable Verify for RO_SPACE when it is shared 2019-11-04 09:55:45 +00:00
mozilla Un-marking tests that were marked SLOW due to TNodification 2019-11-04 13:30:30 +00:00
test262 [class] Remove local test262 private class field tests 2019-11-19 00:34:46 +00:00
torque [torque] fix formatting of union types 2019-10-24 10:05:25 +00:00
unittests [objects] rename kSize to kHeaderSize for JSObject subclasses 2019-11-18 15:17:52 +00:00
wasm-api-tests Remove 'embedded_builtins' variant 2019-10-22 12:58:02 +00:00
wasm-js [wasm] Update spec tests 2019-11-18 12:55:02 +00:00
wasm-spec-tests [wasm][bulk-memory] Change bounds checks behavior 2019-11-20 15:07:17 +00:00
webkit [builtins] Port %TypedArray%.prototype.set to Torque 2019-11-06 12:51:21 +00:00
BUILD.gn [preparser] deprecate stand-alone "preparser" test-suite 2019-11-20 08:52:59 +00:00
OWNERS Use relative paths to OWNERS files 2019-08-12 13:52:52 +00:00