a81e8d16f4
Previously the `Debugger.CallFrame`s in `Debugger.paused` events would report locations relative to the surrounding document in case of inline scripts with `//@ sourceURL` annotations (while `Runtime.CallFrame` was already fixed previously as part of crrev.com/c/3069289). With this CL the locations in `Debugger.CallFrame` are also appropriately adjusted. Drive-by-fix: Several inspector tests were (incorrectly) relying on this wrong treatment, and were also unnecessarily using //# sourceURL annotations. So part of this CL also addresses that problem and makes the tests more robust, using addInlineScript() helper. Fixed: chromium:1283049 Bug: chromium:1183990, chromium:578269 Change-Id: I6e3b215d951c3453c0a9cfc9bccf3dc3d5e92fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359619 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78450}
69 lines
2.0 KiB
JavaScript
69 lines
2.0 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start('Checks async instrumentation enabled in the middle.');
|
|
|
|
contextGroup.addInlineScript(
|
|
`
|
|
function foo() {
|
|
// asyncTaskStarted
|
|
debugger;
|
|
// asyncTaskFinished
|
|
debugger;
|
|
}
|
|
|
|
function test() {
|
|
debugger;
|
|
var resolve1;
|
|
var p1 = new Promise(resolve => resolve1 = resolve);
|
|
var p2 = p1.then(foo);
|
|
resolve1(); // asyncTaskScheduled
|
|
debugger;
|
|
return p2;
|
|
}`,
|
|
'test.js');
|
|
|
|
session.setupScriptMap();
|
|
Protocol.Debugger.onPaused(message => {
|
|
if (enableOnPause-- === 0)
|
|
Protocol.Debugger.setAsyncCallStackDepth({ maxDepth: 128 });
|
|
session.logCallFrames(message.params.callFrames);
|
|
var asyncStackTrace = message.params.asyncStackTrace;
|
|
while (asyncStackTrace) {
|
|
InspectorTest.log(`-- ${asyncStackTrace.description} --`);
|
|
session.logCallFrames(asyncStackTrace.callFrames);
|
|
asyncStackTrace = asyncStackTrace.parent;
|
|
}
|
|
InspectorTest.log('');
|
|
Protocol.Debugger.resume();
|
|
});
|
|
|
|
Protocol.Debugger.enable();
|
|
var enableOnPause = 0;
|
|
InspectorTest.runTestSuite([
|
|
function beforeAsyncTaskScheduled(next) {
|
|
enableOnPause = 0;
|
|
Protocol.Runtime.evaluate({ expression: 'test()//# sourceURL=expr1.js',
|
|
awaitPromise: true })
|
|
.then(() => Protocol.Debugger.setAsyncCallStackDepth({ maxDepth: 0 }))
|
|
.then(next);
|
|
},
|
|
|
|
function afterAsyncTaskScheduled(next) {
|
|
enableOnPause = 2;
|
|
Protocol.Runtime.evaluate({ expression: 'test()//# sourceURL=expr1.js',
|
|
awaitPromise: true })
|
|
.then(() => Protocol.Debugger.setAsyncCallStackDepth({ maxDepth: 0 }))
|
|
.then(next);
|
|
},
|
|
|
|
function afterAsyncTaskStarted(next) {
|
|
enableOnPause = 3;
|
|
Protocol.Runtime.evaluate({ expression: 'test()//# sourceURL=expr1.js',
|
|
awaitPromise: true })
|
|
.then(() => Protocol.Debugger.setAsyncCallStackDepth({ maxDepth: 0 }))
|
|
.then(next);
|
|
}
|
|
]);
|