7d844bdbb0
LiftoffCompiler::ProcessParameter assumed that by processing parameters in the order of their index, register parameters get processed first, and that for processing stack parameters it can already use all registers as temp registers. This is not true with reference type parameters, because registers always first get assigned to value type parameters even when there is a reference type parameter with a lower index. Because of this incorrect assumption register parameters were overwritten by reference type parameters on the stack that got processed first. With this CL, only those registers get used as temp registers for reference type parameters that are not used for parameters. CC=jkummerow@chromium.org, clemensb@chromium.org R=thibaudm@chromium.org Bug: v8:11596 Change-Id: I30ed7f073147df0bd81b9ef4d2b2a54d7badc937 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784560 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73635} |
||
---|---|---|
.. | ||
DIR_METADATA | ||
OWNERS | ||
test-backing-store.cc | ||
test-c-wasm-entry.cc | ||
test-compilation-cache.cc | ||
test-gc.cc | ||
test-grow-memory.cc | ||
test-jump-table-assembler.cc | ||
test-liftoff-inspection.cc | ||
test-run-wasm-64.cc | ||
test-run-wasm-asmjs.cc | ||
test-run-wasm-atomics64.cc | ||
test-run-wasm-atomics.cc | ||
test-run-wasm-bulk-memory.cc | ||
test-run-wasm-exceptions.cc | ||
test-run-wasm-interpreter.cc | ||
test-run-wasm-js.cc | ||
test-run-wasm-memory64.cc | ||
test-run-wasm-module.cc | ||
test-run-wasm-relaxed-simd.cc | ||
test-run-wasm-sign-extension.cc | ||
test-run-wasm-simd-liftoff.cc | ||
test-run-wasm-simd-scalar-lowering.cc | ||
test-run-wasm-simd.cc | ||
test-run-wasm-wrappers.cc | ||
test-run-wasm.cc | ||
test-streaming-compilation.cc | ||
test-wasm-breakpoints.cc | ||
test-wasm-codegen.cc | ||
test-wasm-import-wrapper-cache.cc | ||
test-wasm-metrics.cc | ||
test-wasm-serialization.cc | ||
test-wasm-shared-engine.cc | ||
test-wasm-stack.cc | ||
test-wasm-trap-position.cc | ||
wasm-atomics-utils.h | ||
wasm-run-utils.cc | ||
wasm-run-utils.h | ||
wasm-simd-utils.cc | ||
wasm-simd-utils.h |