90da6284ba
Fix delegation to the specific slow-path bailout. Note: This was not an issue in Blink production code but only when using `cppgc_enable_object_names = true`. Bug: chromium:1056170 Change-Id: I00db63f015b60ac2ccd9f80eca80728bc78e9187 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144911 Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#76692}
157 lines
8.1 KiB
C++
157 lines
8.1 KiB
C++
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef INCLUDE_CPPGC_INTERNAL_GC_INFO_H_
|
|
#define INCLUDE_CPPGC_INTERNAL_GC_INFO_H_
|
|
|
|
#include <atomic>
|
|
#include <cstdint>
|
|
#include <type_traits>
|
|
|
|
#include "cppgc/internal/finalizer-trait.h"
|
|
#include "cppgc/internal/name-trait.h"
|
|
#include "cppgc/trace-trait.h"
|
|
#include "v8config.h" // NOLINT(build/include_directory)
|
|
|
|
namespace cppgc {
|
|
namespace internal {
|
|
|
|
using GCInfoIndex = uint16_t;
|
|
|
|
struct V8_EXPORT EnsureGCInfoIndexTrait final {
|
|
// Acquires a new GC info object and returns the index. In addition, also
|
|
// updates `registered_index` atomically.
|
|
template <typename T>
|
|
V8_INLINE static GCInfoIndex EnsureIndex(
|
|
std::atomic<GCInfoIndex>& registered_index) {
|
|
return EnsureGCInfoIndexTraitDispatch<T>{}(registered_index);
|
|
}
|
|
|
|
private:
|
|
template <typename T, bool = std::is_polymorphic<T>::value,
|
|
bool = FinalizerTrait<T>::HasFinalizer(),
|
|
bool = NameTrait<T>::HasNonHiddenName()>
|
|
struct EnsureGCInfoIndexTraitDispatch;
|
|
|
|
static GCInfoIndex EnsureGCInfoIndexPolymorphic(std::atomic<GCInfoIndex>&,
|
|
TraceCallback,
|
|
FinalizationCallback,
|
|
NameCallback);
|
|
static GCInfoIndex EnsureGCInfoIndexPolymorphic(std::atomic<GCInfoIndex>&,
|
|
TraceCallback,
|
|
FinalizationCallback);
|
|
static GCInfoIndex EnsureGCInfoIndexPolymorphic(std::atomic<GCInfoIndex>&,
|
|
TraceCallback, NameCallback);
|
|
static GCInfoIndex EnsureGCInfoIndexPolymorphic(std::atomic<GCInfoIndex>&,
|
|
TraceCallback);
|
|
static GCInfoIndex EnsureGCInfoIndexNonPolymorphic(std::atomic<GCInfoIndex>&,
|
|
TraceCallback,
|
|
FinalizationCallback,
|
|
|
|
NameCallback);
|
|
static GCInfoIndex EnsureGCInfoIndexNonPolymorphic(std::atomic<GCInfoIndex>&,
|
|
TraceCallback,
|
|
FinalizationCallback);
|
|
static GCInfoIndex EnsureGCInfoIndexNonPolymorphic(std::atomic<GCInfoIndex>&,
|
|
TraceCallback,
|
|
NameCallback);
|
|
static GCInfoIndex EnsureGCInfoIndexNonPolymorphic(std::atomic<GCInfoIndex>&,
|
|
TraceCallback);
|
|
};
|
|
|
|
#define DISPATCH(is_polymorphic, has_finalizer, has_non_hidden_name, function) \
|
|
template <typename T> \
|
|
struct EnsureGCInfoIndexTrait::EnsureGCInfoIndexTraitDispatch< \
|
|
T, is_polymorphic, has_finalizer, has_non_hidden_name> { \
|
|
V8_INLINE GCInfoIndex \
|
|
operator()(std::atomic<GCInfoIndex>& registered_index) { \
|
|
return function; \
|
|
} \
|
|
};
|
|
|
|
// --------------------------------------------------------------------- //
|
|
// DISPATCH(is_polymorphic, has_finalizer, has_non_hidden_name, function)
|
|
// --------------------------------------------------------------------- //
|
|
DISPATCH(true, true, true, //
|
|
EnsureGCInfoIndexPolymorphic(registered_index, //
|
|
TraceTrait<T>::Trace, //
|
|
FinalizerTrait<T>::kCallback, //
|
|
NameTrait<T>::GetName)) //
|
|
DISPATCH(true, true, false, //
|
|
EnsureGCInfoIndexPolymorphic(registered_index, //
|
|
TraceTrait<T>::Trace, //
|
|
FinalizerTrait<T>::kCallback)) //
|
|
DISPATCH(true, false, true, //
|
|
EnsureGCInfoIndexPolymorphic(registered_index, //
|
|
TraceTrait<T>::Trace, //
|
|
NameTrait<T>::GetName)) //
|
|
DISPATCH(true, false, false, //
|
|
EnsureGCInfoIndexPolymorphic(registered_index, //
|
|
TraceTrait<T>::Trace)) //
|
|
DISPATCH(false, true, true, //
|
|
EnsureGCInfoIndexNonPolymorphic(registered_index, //
|
|
TraceTrait<T>::Trace, //
|
|
FinalizerTrait<T>::kCallback, //
|
|
NameTrait<T>::GetName)) //
|
|
DISPATCH(false, true, false, //
|
|
EnsureGCInfoIndexNonPolymorphic(registered_index, //
|
|
TraceTrait<T>::Trace, //
|
|
FinalizerTrait<T>::kCallback)) //
|
|
DISPATCH(false, false, true, //
|
|
EnsureGCInfoIndexNonPolymorphic(registered_index, //
|
|
TraceTrait<T>::Trace, //
|
|
NameTrait<T>::GetName)) //
|
|
DISPATCH(false, false, false, //
|
|
EnsureGCInfoIndexNonPolymorphic(registered_index, //
|
|
TraceTrait<T>::Trace)) //
|
|
|
|
#undef DISPATCH
|
|
|
|
// Fold types based on finalizer behavior. Note that finalizer characteristics
|
|
// align with trace behavior, i.e., destructors are virtual when trace methods
|
|
// are and vice versa.
|
|
template <typename T, typename ParentMostGarbageCollectedType>
|
|
struct GCInfoFolding {
|
|
static constexpr bool kHasVirtualDestructorAtBase =
|
|
std::has_virtual_destructor<ParentMostGarbageCollectedType>::value;
|
|
static constexpr bool kBothTypesAreTriviallyDestructible =
|
|
std::is_trivially_destructible<ParentMostGarbageCollectedType>::value &&
|
|
std::is_trivially_destructible<T>::value;
|
|
static constexpr bool kHasCustomFinalizerDispatchAtBase =
|
|
internal::HasFinalizeGarbageCollectedObject<
|
|
ParentMostGarbageCollectedType>::value;
|
|
#ifdef CPPGC_SUPPORTS_OBJECT_NAMES
|
|
static constexpr bool kWantsDetailedObjectNames = true;
|
|
#else // !CPPGC_SUPPORTS_OBJECT_NAMES
|
|
static constexpr bool kWantsDetailedObjectNames = false;
|
|
#endif // !CPPGC_SUPPORTS_OBJECT_NAMES
|
|
|
|
// Folding would regresses name resolution when deriving names from C++
|
|
// class names as it would just folds a name to the base class name.
|
|
using ResultType = std::conditional_t<(kHasVirtualDestructorAtBase ||
|
|
kBothTypesAreTriviallyDestructible ||
|
|
kHasCustomFinalizerDispatchAtBase) &&
|
|
!kWantsDetailedObjectNames,
|
|
ParentMostGarbageCollectedType, T>;
|
|
};
|
|
|
|
// Trait determines how the garbage collector treats objects wrt. to traversing,
|
|
// finalization, and naming.
|
|
template <typename T>
|
|
struct GCInfoTrait final {
|
|
V8_INLINE static GCInfoIndex Index() {
|
|
static_assert(sizeof(T), "T must be fully defined");
|
|
static std::atomic<GCInfoIndex>
|
|
registered_index; // Uses zero initialization.
|
|
const GCInfoIndex index = registered_index.load(std::memory_order_acquire);
|
|
return index ? index
|
|
: EnsureGCInfoIndexTrait::EnsureIndex<T>(registered_index);
|
|
}
|
|
};
|
|
|
|
} // namespace internal
|
|
} // namespace cppgc
|
|
|
|
#endif // INCLUDE_CPPGC_INTERNAL_GC_INFO_H_
|