7fa12e2a4f
This patch implements https://github.com/tc39/proposal-class-fields/pull/269 and makes sure we always throw TypeError when there is invalid private name access in computed property keys. Before this patch, private name variables of private fields and methods are initialized together with computed property keys in the order they are declared. Accessing undefined private names in the computed property keys thus fail silently. After this patch, we initialize the private name variables of private fields before we initialize the computed property keys, so that invalid access to private fields in the computed keys can be checked in the IC. We now also initialize the brand early, so that invalid access to private methods or accessors in the computed keys throw TypeError during brand checks - and since these accesses are guarded by brand checks, we can create the private methods and accessors after the class is defined, and merge the home object setting with the creation of the closures. Bug: v8:8330, v8:9611 Change-Id: I01363f7befac6cf9dd28ec229b99a99102bcf012 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1846571 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#64225}
232 lines
5.9 KiB
Plaintext
232 lines
5.9 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
private methods: yes
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A {
|
|
static #a() { return 1; }
|
|
}
|
|
}
|
|
"
|
|
frame size: 6
|
|
parameter count: 1
|
|
bytecode array length: 41
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(1),
|
|
B(LdaTheHole),
|
|
B(Star), R(5),
|
|
B(CreateClosure), U8(2), U8(0), U8(2),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(3),
|
|
B(Mov), R(2), R(4),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(3),
|
|
B(Star), R(3),
|
|
B(CreateClosure), U8(3), U8(1), U8(2),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(PopContext), R(1),
|
|
B(Mov), R(4), R(0),
|
|
B(LdaUndefined),
|
|
/* 84 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A {
|
|
static get #a() { return 1; }
|
|
}
|
|
}
|
|
"
|
|
frame size: 6
|
|
parameter count: 1
|
|
bytecode array length: 51
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(1),
|
|
B(LdaTheHole),
|
|
B(Star), R(5),
|
|
B(CreateClosure), U8(2), U8(0), U8(2),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(3),
|
|
B(Mov), R(2), R(4),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(3),
|
|
B(Star), R(3),
|
|
B(CreateClosure), U8(3), U8(1), U8(2),
|
|
B(Star), R(4),
|
|
B(LdaNull),
|
|
B(Star), R(5),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateAccessors), R(4), U8(2),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(PopContext), R(1),
|
|
B(Mov), R(2), R(0),
|
|
B(LdaUndefined),
|
|
/* 88 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A {
|
|
static set #a(val) { }
|
|
}
|
|
}
|
|
"
|
|
frame size: 6
|
|
parameter count: 1
|
|
bytecode array length: 51
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(1),
|
|
B(LdaTheHole),
|
|
B(Star), R(5),
|
|
B(CreateClosure), U8(2), U8(0), U8(2),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(3),
|
|
B(Mov), R(2), R(4),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(3),
|
|
B(Star), R(3),
|
|
B(LdaNull),
|
|
B(Star), R(4),
|
|
B(CreateClosure), U8(3), U8(1), U8(2),
|
|
B(Star), R(5),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateAccessors), R(4), U8(2),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(PopContext), R(1),
|
|
B(Mov), R(2), R(0),
|
|
B(LdaUndefined),
|
|
/* 81 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A {
|
|
static get #a() { return 1; }
|
|
static set #a(val) { }
|
|
}
|
|
}
|
|
"
|
|
frame size: 6
|
|
parameter count: 1
|
|
bytecode array length: 54
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(1),
|
|
B(LdaTheHole),
|
|
B(Star), R(5),
|
|
B(CreateClosure), U8(2), U8(0), U8(2),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(3),
|
|
B(Mov), R(2), R(4),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(3),
|
|
B(Star), R(3),
|
|
B(CreateClosure), U8(3), U8(1), U8(2),
|
|
B(Star), R(4),
|
|
B(CreateClosure), U8(4), U8(2), U8(2),
|
|
B(Star), R(5),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateAccessors), R(4), U8(2),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(PopContext), R(1),
|
|
B(Mov), R(2), R(0),
|
|
B(LdaUndefined),
|
|
/* 115 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A {
|
|
static #a() { }
|
|
#b() { }
|
|
}
|
|
}
|
|
"
|
|
frame size: 7
|
|
parameter count: 1
|
|
bytecode array length: 58
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(1),
|
|
B(LdaConstant), U8(2),
|
|
B(Star), R(3),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(3), U8(1),
|
|
B(StaCurrentContextSlot), U8(6),
|
|
B(LdaTheHole),
|
|
B(Star), R(6),
|
|
B(CreateClosure), U8(3), U8(0), U8(2),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(4),
|
|
B(Mov), R(2), R(5),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(3),
|
|
B(Star), R(4),
|
|
B(CreateClosure), U8(4), U8(1), U8(2),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(CreateClosure), U8(5), U8(2), U8(2),
|
|
B(StaCurrentContextSlot), U8(5),
|
|
B(PopContext), R(1),
|
|
B(Mov), R(5), R(0),
|
|
B(LdaUndefined),
|
|
/* 87 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["A"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|