ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
113 lines
3.6 KiB
C++
113 lines
3.6 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Test specific cases of the lazy/eager-parse decision.
|
|
//
|
|
// Note that presently most unit tests for parsing are found in
|
|
// cctest/test-parsing.cc.
|
|
|
|
#include <unordered_map>
|
|
|
|
#include "include/v8-local-handle.h"
|
|
#include "include/v8-primitive.h"
|
|
#include "src/api/api-inl.h"
|
|
#include "src/execution/isolate.h"
|
|
#include "src/handles/handles-inl.h"
|
|
#include "src/objects/objects-inl.h"
|
|
#include "src/objects/shared-function-info-inl.h"
|
|
#include "src/utils/utils.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
namespace {
|
|
|
|
// Record the 'compiled' state of all top level functions.
|
|
void GetTopLevelFunctionInfo(
|
|
v8::Local<v8::Script> script,
|
|
std::unordered_map<std::string, bool>* is_compiled) {
|
|
// Get the v8::internal::Script object from the API v8::Script.
|
|
// The API object 'wraps' the compiled top-level function, not the i::Script.
|
|
Handle<JSFunction> toplevel_fn = v8::Utils::OpenHandle(*script);
|
|
SharedFunctionInfo::ScriptIterator iterator(
|
|
toplevel_fn->GetIsolate(), Script::cast(toplevel_fn->shared().script()));
|
|
|
|
for (SharedFunctionInfo shared = iterator.Next(); !shared.is_null();
|
|
shared = iterator.Next()) {
|
|
std::unique_ptr<char[]> name = String::cast(shared.Name()).ToCString();
|
|
is_compiled->insert(std::make_pair(name.get(), shared.is_compiled()));
|
|
}
|
|
}
|
|
|
|
} // anonymous namespace
|
|
|
|
TEST(GetTopLevelFunctionInfo) {
|
|
if (!FLAG_lazy) return;
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
HandleScope scope(isolate);
|
|
LocalContext env;
|
|
|
|
const char src[] = "function foo() { var a; }\n";
|
|
std::unordered_map<std::string, bool> is_compiled;
|
|
GetTopLevelFunctionInfo(v8_compile(src), &is_compiled);
|
|
|
|
// Test that our helper function GetTopLevelFunctionInfo does what it claims:
|
|
DCHECK(is_compiled.find("foo") != is_compiled.end());
|
|
DCHECK(is_compiled.find("bar") == is_compiled.end());
|
|
}
|
|
|
|
TEST(EagerlyCompileImmediateUseFunctions) {
|
|
if (!FLAG_lazy) return;
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
HandleScope scope(isolate);
|
|
LocalContext env;
|
|
|
|
// Test parenthesized, exclaimed, and regular functions. Make sure these
|
|
// occur both intermixed and after each other, to make sure the 'reset'
|
|
// mechanism works.
|
|
const char src[] =
|
|
"function normal() { var a; }\n" // Normal: Should lazy parse.
|
|
"(function parenthesized() { var b; })()\n" // Parenthesized: Pre-parse.
|
|
"!function exclaimed() { var c; }() \n" // Exclaimed: Pre-parse.
|
|
"function normal2() { var d; }\n"
|
|
"(function parenthesized2() { var e; })()\n"
|
|
"function normal3() { var f; }\n"
|
|
"!function exclaimed2() { var g; }() \n"
|
|
"function normal4() { var h; }\n";
|
|
|
|
std::unordered_map<std::string, bool> is_compiled;
|
|
GetTopLevelFunctionInfo(v8_compile(src), &is_compiled);
|
|
|
|
DCHECK(is_compiled["parenthesized"]);
|
|
DCHECK(is_compiled["parenthesized2"]);
|
|
DCHECK(is_compiled["exclaimed"]);
|
|
DCHECK(is_compiled["exclaimed2"]);
|
|
DCHECK(!is_compiled["normal"]);
|
|
DCHECK(!is_compiled["normal2"]);
|
|
DCHECK(!is_compiled["normal3"]);
|
|
DCHECK(!is_compiled["normal4"]);
|
|
}
|
|
|
|
TEST(CommaFunctionSequence) {
|
|
if (!FLAG_lazy) return;
|
|
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
HandleScope scope(isolate);
|
|
LocalContext env;
|
|
|
|
const char src[] = "!function a(){}(),function b(){}(),function c(){}();";
|
|
std::unordered_map<std::string, bool> is_compiled;
|
|
GetTopLevelFunctionInfo(v8_compile(src), &is_compiled);
|
|
|
|
DCHECK(is_compiled["a"]);
|
|
DCHECK(is_compiled["b"]);
|
|
DCHECK(is_compiled["c"]);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|