7ffdb5194d
Also support patterns in ``for (var p in/of ...)``
This CL extends the rewriting we used to do for ``for (let p in/of...)`` to
``for (var p in/of ...)``. For all for..in/of loop declaring variable,
we rewrite
for (var/let/const pattern in/of e) b
into
for (x' in/of e) { var/let/const pattern = e; b }
This adds a small complication for debugger: for a statement
for (var v in/of e) ...
we used to have
var v;
for (v in/of e) ...
and there was a separate breakpoint on ``var v`` line.
This breakpoint is actually useless since it is immediately followed by
a breakpoint on evaluation of ``e``, so this CL removes that breakpoint
location.
Similiraly, for let, it used to be that
for (let v in/of e) ...
became
for (x' in/of e) { let v; v = x'; ... }
``let v``generetaed a useless breakpoint (with the location at the
loop's head. This CL removes that breakpoint as well.
R=arv@chromium.org,rossberg@chromium.org
BUG=v8:811
LOG=N
Review URL: https://codereview.chromium.org/1149043005
Cr-Commit-Position: refs/heads/master@{#28565}
118 lines
3.1 KiB
JavaScript
118 lines
3.1 KiB
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --expose-debug-as debug --harmony
|
|
|
|
Debug = debug.Debug;
|
|
var break_count = 0
|
|
var exception = null;
|
|
var log = []
|
|
|
|
var s = 0;
|
|
var a = [1, 2, 3];
|
|
var i = 0;
|
|
|
|
function f() {
|
|
"use strict";
|
|
debugger; // Break a
|
|
var j; // Break b
|
|
|
|
for (var i in null) { // Break c
|
|
s += a[i];
|
|
}
|
|
|
|
for (j in null) { // Break d
|
|
s += a[j];
|
|
}
|
|
|
|
for (var i in a) { // Break e
|
|
s += a[i]; // Break E
|
|
}
|
|
|
|
for (j in a) { // Break f
|
|
s += a[j]; // Break F
|
|
}
|
|
|
|
for (let i in a) { // Break g
|
|
s += a[i]; // Break G
|
|
}
|
|
|
|
for (var i of a) { // Break h
|
|
s += i; // Break H
|
|
}
|
|
|
|
for (j of a) { // Break i
|
|
s += j; // Break I
|
|
}
|
|
|
|
for (let i of a) { // Break j
|
|
s += i; // Break J
|
|
}
|
|
|
|
for (var i = 0; i < 3; i++) { // Break k
|
|
s += a[i]; // Break K
|
|
}
|
|
|
|
for (j = 0; j < 3; j++) { // Break l
|
|
s += a[j]; // Break L
|
|
}
|
|
|
|
// TODO(yangguo): add test case for for-let.
|
|
} // Break y
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
var line = exec_state.frame(0).sourceLineText();
|
|
var col = exec_state.frame(0).sourceColumn();
|
|
print(line);
|
|
var match = line.match(/\/\/ Break (\w)$/);
|
|
assertEquals(2, match.length);
|
|
log.push(match[1] + col);
|
|
exec_state.prepareStep(Debug.StepAction.StepNext, 1);
|
|
break_count++;
|
|
} catch (e) {
|
|
exception = e;
|
|
}
|
|
}
|
|
|
|
Debug.setListener(listener);
|
|
f();
|
|
Debug.setListener(null); // Break z
|
|
|
|
print("log:\n"+ JSON.stringify(log));
|
|
// The let declaration differs from var in that the loop variable
|
|
// is declared in every iteration.
|
|
var expected = [
|
|
// Entry
|
|
"a2","b2",
|
|
// Empty for-in-var: get enumerable
|
|
"c16",
|
|
// Empty for-in: get enumerable
|
|
"d12",
|
|
// For-in-var: get enumerable, assign, body, assign, body, ...
|
|
"e16","e11","E4","e11","E4","e11","E4","e11",
|
|
// For-in: get enumerable, assign, body, assign, body, ...
|
|
"f12","f7","F4","f7","F4","f7","F4","f7",
|
|
// For-in-let: get enumerable, next, body, next, ...
|
|
"g16","g11","G4","g11","G4","g11","G4","g11",
|
|
// For-of-var: next(), body, next(), body, ...
|
|
"h16","H4","h16","H4","h16","H4","h16",
|
|
// For-of: next(), body, next(), body, ...
|
|
"i12","I4","i12","I4","i12","I4","i12",
|
|
// For-of-let: next(), body, next(), ...
|
|
"j16","J4","j16","J4","j16","J4","j16",
|
|
// For-var: var decl, condition, body, next, condition, body, ...
|
|
"k7","k20","K4","k23","k20","K4","k23","k20","K4","k23","k20",
|
|
// For: init, condition, body, next, condition, body, ...
|
|
"l11","l16","L4","l19","l16","L4","l19","l16","L4","l19","l16",
|
|
// Exit.
|
|
"y0","z0",
|
|
]
|
|
print("expected:\n"+ JSON.stringify(log));
|
|
|
|
assertArrayEquals(expected, log);
|
|
assertEquals(48, s);
|
|
assertNull(exception);
|