d521a1e261
Change-Id: I7e833c3b06cfb3ff9eda663c2bee4981013744b0 Adding index accessor counter Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ic353c11fa0f430537819387d17eedeec5466d9cc Bug: Reviewed-on: https://chromium-review.googlesource.com/741169 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Natalie Silvanovich <natashenka@google.com> Cr-Commit-Position: refs/heads/master@{#49061}
197 lines
7.7 KiB
C++
197 lines
7.7 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace test_usecounters {
|
|
|
|
int* global_use_counts = nullptr;
|
|
|
|
void MockUseCounterCallback(v8::Isolate* isolate,
|
|
v8::Isolate::UseCounterFeature feature) {
|
|
++global_use_counts[feature];
|
|
}
|
|
|
|
TEST(DefineGetterSetterThrowUseCount) {
|
|
i::FLAG_harmony_strict_legacy_accessor_builtins = false;
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
v8::HandleScope scope(isolate);
|
|
LocalContext env;
|
|
int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
|
|
global_use_counts = use_counts;
|
|
CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
|
|
|
|
// __defineGetter__ and __defineSetter__ do not increment
|
|
// kDefineGetterOrSetterWouldThrow on success
|
|
CompileRun(
|
|
"var a = {};"
|
|
"Object.defineProperty(a, 'b', { value: 0, configurable: true });"
|
|
"a.__defineGetter__('b', ()=>{});");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kDefineGetterOrSetterWouldThrow]);
|
|
CompileRun(
|
|
"var a = {};"
|
|
"Object.defineProperty(a, 'b', { value: 0, configurable: true });"
|
|
"a.__defineSetter__('b', ()=>{});");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kDefineGetterOrSetterWouldThrow]);
|
|
|
|
// __defineGetter__ and __defineSetter__ do not increment
|
|
// kDefineGetterOrSetterWouldThrow on other errors
|
|
v8::Local<v8::Value> resultProxyThrow = CompileRun(
|
|
"var exception;"
|
|
"try {"
|
|
"var a = new Proxy({}, { defineProperty: ()=>{throw new Error;} });"
|
|
"a.__defineGetter__('b', ()=>{});"
|
|
"} catch (e) { exception = e; }"
|
|
"exception");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kDefineGetterOrSetterWouldThrow]);
|
|
CHECK(resultProxyThrow->IsObject());
|
|
resultProxyThrow = CompileRun(
|
|
"var exception;"
|
|
"try {"
|
|
"var a = new Proxy({}, { defineProperty: ()=>{throw new Error;} });"
|
|
"a.__defineSetter__('b', ()=>{});"
|
|
"} catch (e) { exception = e; }"
|
|
"exception");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kDefineGetterOrSetterWouldThrow]);
|
|
CHECK(resultProxyThrow->IsObject());
|
|
|
|
// __defineGetter__ and __defineSetter__ increment
|
|
// kDefineGetterOrSetterWouldThrow when they would throw per spec (B.2.2.2)
|
|
CompileRun(
|
|
"var a = {};"
|
|
"Object.defineProperty(a, 'b', { value: 0, configurable: false });"
|
|
"a.__defineGetter__('b', ()=>{});");
|
|
CHECK_EQ(1, use_counts[v8::Isolate::kDefineGetterOrSetterWouldThrow]);
|
|
CompileRun(
|
|
"var a = {};"
|
|
"Object.defineProperty(a, 'b', { value: 0, configurable: false });"
|
|
"a.__defineSetter__('b', ()=>{});");
|
|
CHECK_EQ(2, use_counts[v8::Isolate::kDefineGetterOrSetterWouldThrow]);
|
|
}
|
|
|
|
TEST(AssigmentExpressionLHSIsCall) {
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
v8::HandleScope scope(isolate);
|
|
LocalContext env;
|
|
int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
|
|
global_use_counts = use_counts;
|
|
CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
|
|
|
|
// AssignmentExpressions whose LHS is not a call do not increment counters
|
|
CompileRun("function f(){ a = 0; a()[b] = 0; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
CompileRun("function f(){ ++a; ++a()[b]; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
CompileRun("function f(){ 'use strict'; a = 0; a()[b] = 0; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
CompileRun("function f(){ 'use strict'; ++a; ++a()[b]; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
|
|
// AssignmentExpressions whose LHS is a call increment appropriate counters
|
|
CompileRun("function f(){ a() = 0; }");
|
|
CHECK_NE(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy] = 0;
|
|
CompileRun("function f(){ 'use strict'; a() = 0; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_NE(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict] = 0;
|
|
|
|
// UpdateExpressions whose LHS is a call increment appropriate counters
|
|
CompileRun("function f(){ ++a(); }");
|
|
CHECK_NE(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy] = 0;
|
|
CompileRun("function f(){ 'use strict'; ++a(); }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_NE(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict] = 0;
|
|
}
|
|
|
|
TEST(LabeledExpressionStatement) {
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
v8::HandleScope scope(isolate);
|
|
LocalContext env;
|
|
int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
|
|
global_use_counts = use_counts;
|
|
CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
|
|
|
|
CompileRun("typeof a");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kLabeledExpressionStatement]);
|
|
|
|
CompileRun("foo: null");
|
|
CHECK_EQ(1, use_counts[v8::Isolate::kLabeledExpressionStatement]);
|
|
|
|
CompileRun("foo: bar: baz: undefined");
|
|
CHECK_EQ(2, use_counts[v8::Isolate::kLabeledExpressionStatement]);
|
|
|
|
CompileRun(
|
|
"foo: if (false);"
|
|
"bar: { }"
|
|
"baz: switch (false) { }"
|
|
"bat: do { } while (false);");
|
|
CHECK_EQ(2, use_counts[v8::Isolate::kLabeledExpressionStatement]);
|
|
}
|
|
|
|
TEST(IndexAccessorUseCount) {
|
|
i::FLAG_harmony_strict_legacy_accessor_builtins = false;
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
v8::HandleScope scope(isolate);
|
|
LocalContext env;
|
|
int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
|
|
global_use_counts = use_counts;
|
|
CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
|
|
|
|
// Adding accessor to named property does not increment kIndexAccessor
|
|
CompileRun(
|
|
"var a = {};"
|
|
"function dummy(){}"
|
|
"Object.defineProperty(a, 'test', { get: dummy, set: dummy });");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kIndexAccessor]);
|
|
|
|
// Setting index to value does not increment kIndexAccessor
|
|
CompileRun(
|
|
"var a = {};"
|
|
"Object.defineProperty(a, '0', { value: 0 });");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kIndexAccessor]);
|
|
|
|
// Non-integer number index not increment kIndexAccessor
|
|
CompileRun(
|
|
"var a = {};"
|
|
"Object.defineProperty(a, '2.5', { value: 0 });");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kIndexAccessor]);
|
|
|
|
// Setting index accessor increments count
|
|
CompileRun(
|
|
"var a = {};"
|
|
"function dummy(){}"
|
|
"Object.defineProperty(a, '0', { get : dummy, set : dummy });");
|
|
CHECK_EQ(1, use_counts[v8::Isolate::kIndexAccessor]);
|
|
|
|
// Setting index accessor on array increments count
|
|
CompileRun(
|
|
"var a = [];"
|
|
"function dummy(){}"
|
|
"Object.defineProperty(a, '0', { get : dummy, set : dummy });");
|
|
CHECK_EQ(2, use_counts[v8::Isolate::kIndexAccessor]);
|
|
|
|
// __defineGetter__ increments count
|
|
CompileRun(
|
|
"var a = [];"
|
|
"function dummy(){}"
|
|
"a.__defineGetter__('0', dummy);");
|
|
CHECK_EQ(3, use_counts[v8::Isolate::kIndexAccessor]);
|
|
}
|
|
} // namespace test_usecounters
|
|
} // namespace internal
|
|
} // namespace v8
|