8efa1719f0
Detach the marking state from the collectors and move them to heap. Also update users to access via heap and reduce dependencies on the collectors. This is a prerequisite for moving sweeper to the heap, which is needed for concurrent sweeping in MinorMC. Bug: v8:12612 Change-Id: Ia0bb2b7566b24eeb0d75c911edbfd626f07dad0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3925548 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#83542}
356 lines
13 KiB
C++
356 lines
13 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/v8-cppgc.h"
|
|
#include "include/v8-traced-handle.h"
|
|
#include "src/api/api-inl.h"
|
|
#include "src/handles/global-handles.h"
|
|
#include "src/heap/cppgc/visitor.h"
|
|
#include "src/heap/marking-state-inl.h"
|
|
#include "test/unittests/heap/heap-utils.h"
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
using TracedReferenceTest = TestWithHeapInternals;
|
|
|
|
TEST_F(TracedReferenceTest, ResetFromLocal) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
v8::TracedReference<v8::Object> ref;
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
ASSERT_TRUE(ref.IsEmpty());
|
|
EXPECT_NE(ref, local);
|
|
ref.Reset(v8_isolate(), local);
|
|
EXPECT_FALSE(ref.IsEmpty());
|
|
EXPECT_EQ(ref, local);
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, ConstructFromLocal) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref(v8_isolate(), local);
|
|
EXPECT_FALSE(ref.IsEmpty());
|
|
EXPECT_EQ(ref, local);
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, Reset) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref(v8_isolate(), local);
|
|
EXPECT_FALSE(ref.IsEmpty());
|
|
EXPECT_EQ(ref, local);
|
|
ref.Reset();
|
|
EXPECT_TRUE(ref.IsEmpty());
|
|
EXPECT_NE(ref, local);
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, Copy) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref(v8_isolate(), local);
|
|
v8::TracedReference<v8::Object> ref_copy1(ref);
|
|
v8::TracedReference<v8::Object> ref_copy2 = ref;
|
|
EXPECT_EQ(ref, local);
|
|
EXPECT_EQ(ref_copy1, local);
|
|
EXPECT_EQ(ref_copy2, local);
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, CopyHeterogenous) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref(v8_isolate(), local);
|
|
v8::TracedReference<v8::Value> ref_copy1(ref);
|
|
v8::TracedReference<v8::Value> ref_copy2 = ref;
|
|
EXPECT_EQ(ref, local);
|
|
EXPECT_EQ(ref_copy1, local);
|
|
EXPECT_EQ(ref_copy2, local);
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, Move) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref(v8_isolate(), local);
|
|
v8::TracedReference<v8::Object> ref_moved1(std::move(ref));
|
|
v8::TracedReference<v8::Object> ref_moved2 = std::move(ref_moved1);
|
|
EXPECT_TRUE(ref.IsEmpty());
|
|
EXPECT_TRUE(ref_moved1.IsEmpty());
|
|
EXPECT_EQ(ref_moved2, local);
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, MoveHeterogenous) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref1(v8_isolate(), local);
|
|
v8::TracedReference<v8::Value> ref_moved1(std::move(ref1));
|
|
v8::TracedReference<v8::Object> ref2(v8_isolate(), local);
|
|
v8::TracedReference<v8::Object> ref_moved2 = std::move(ref2);
|
|
EXPECT_TRUE(ref1.IsEmpty());
|
|
EXPECT_EQ(ref_moved1, local);
|
|
EXPECT_TRUE(ref2.IsEmpty());
|
|
EXPECT_EQ(ref_moved2, local);
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, Equality) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local1 =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref1(v8_isolate(), local1);
|
|
v8::TracedReference<v8::Object> ref2(v8_isolate(), local1);
|
|
EXPECT_EQ(ref1, ref2);
|
|
EXPECT_EQ(ref2, ref1);
|
|
v8::Local<v8::Object> local2 =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref3(v8_isolate(), local2);
|
|
EXPECT_NE(ref2, ref3);
|
|
EXPECT_NE(ref3, ref2);
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, EqualityHeterogenous) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local1 =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref1(v8_isolate(), local1);
|
|
v8::TracedReference<v8::Value> ref2(v8_isolate(), local1);
|
|
EXPECT_EQ(ref1, ref2);
|
|
EXPECT_EQ(ref2, ref1);
|
|
v8::Local<v8::Object> local2 =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref3(v8_isolate(), local2);
|
|
EXPECT_NE(ref2, ref3);
|
|
EXPECT_NE(ref3, ref2);
|
|
}
|
|
}
|
|
|
|
namespace {
|
|
|
|
// Must be used on stack.
|
|
class JSVisitorForTesting final : public JSVisitor {
|
|
public:
|
|
explicit JSVisitorForTesting(v8::Local<v8::Object> expected_object)
|
|
: JSVisitor(cppgc::internal::VisitorFactory::CreateKey()),
|
|
expected_object_(expected_object) {}
|
|
|
|
void Visit(const TracedReferenceBase& ref) final {
|
|
EXPECT_EQ(ref, expected_object_);
|
|
visit_count_++;
|
|
}
|
|
|
|
size_t visit_count() const { return visit_count_; }
|
|
|
|
private:
|
|
v8::Local<v8::Object> expected_object_;
|
|
size_t visit_count_ = 0;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
TEST_F(TracedReferenceTest, TracedReferenceTrace) {
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> js_member(v8_isolate(), local);
|
|
JSVisitorForTesting visitor(local);
|
|
// Cast to cppgc::Visitor to ensure that we dispatch through the base
|
|
// visitor and use traits.
|
|
static_cast<cppgc::Visitor&>(visitor).Trace(js_member);
|
|
EXPECT_EQ(1u, visitor.visit_count());
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, NoWriteBarrierOnConstruction) {
|
|
if (!v8_flags.incremental_marking)
|
|
GTEST_SKIP() << "Write barrier tests require incremental marking";
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
SimulateIncrementalMarking();
|
|
MarkingState state(i_isolate());
|
|
ASSERT_TRUE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
auto ref =
|
|
std::make_unique<v8::TracedReference<v8::Object>>(v8_isolate(), local);
|
|
USE(ref);
|
|
EXPECT_TRUE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, WriteBarrierForOnHeapReset) {
|
|
if (!v8_flags.incremental_marking)
|
|
GTEST_SKIP() << "Write barrier tests require incremental marking";
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
auto ref = std::make_unique<v8::TracedReference<v8::Object>>();
|
|
SimulateIncrementalMarking();
|
|
MarkingState state(i_isolate());
|
|
ASSERT_TRUE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
ref->Reset(v8_isolate(), local);
|
|
EXPECT_FALSE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, WriteBarrierForOnStackReset) {
|
|
if (!v8_flags.incremental_marking)
|
|
GTEST_SKIP() << "Write barrier tests require incremental marking";
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
v8::TracedReference<v8::Object> ref;
|
|
SimulateIncrementalMarking();
|
|
MarkingState state(i_isolate());
|
|
ASSERT_TRUE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
ref.Reset(v8_isolate(), local);
|
|
EXPECT_FALSE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, WriteBarrierOnHeapCopy) {
|
|
if (!v8_flags.incremental_marking)
|
|
GTEST_SKIP() << "Write barrier tests require incremental marking";
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
auto ref_from =
|
|
std::make_unique<v8::TracedReference<v8::Object>>(v8_isolate(), local);
|
|
auto ref_to = std::make_unique<v8::TracedReference<v8::Object>>();
|
|
SimulateIncrementalMarking();
|
|
MarkingState state(i_isolate());
|
|
ASSERT_TRUE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
*ref_to = *ref_from;
|
|
EXPECT_TRUE(!ref_from->IsEmpty());
|
|
EXPECT_FALSE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, WriteBarrierForOnStackCopy) {
|
|
if (!v8_flags.incremental_marking)
|
|
GTEST_SKIP() << "Write barrier tests require incremental marking";
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
auto ref_from =
|
|
std::make_unique<v8::TracedReference<v8::Object>>(v8_isolate(), local);
|
|
v8::TracedReference<v8::Object> ref_to;
|
|
SimulateIncrementalMarking();
|
|
MarkingState state(i_isolate());
|
|
ASSERT_TRUE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
ref_to = *ref_from;
|
|
EXPECT_TRUE(!ref_from->IsEmpty());
|
|
EXPECT_FALSE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, WriteBarrierForOnHeapMove) {
|
|
if (!v8_flags.incremental_marking)
|
|
GTEST_SKIP() << "Write barrier tests require incremental marking";
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
auto ref_from =
|
|
std::make_unique<v8::TracedReference<v8::Object>>(v8_isolate(), local);
|
|
auto ref_to = std::make_unique<v8::TracedReference<v8::Object>>();
|
|
SimulateIncrementalMarking();
|
|
MarkingState state(i_isolate());
|
|
ASSERT_TRUE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
*ref_to = std::move(*ref_from);
|
|
ASSERT_TRUE(ref_from->IsEmpty());
|
|
EXPECT_FALSE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
}
|
|
}
|
|
|
|
TEST_F(TracedReferenceTest, WriteBarrierForOnStackMove) {
|
|
if (!v8_flags.incremental_marking)
|
|
GTEST_SKIP() << "Write barrier tests require incremental marking";
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(v8_isolate());
|
|
v8::Context::Scope context_scope(context);
|
|
{
|
|
v8::HandleScope handles(v8_isolate());
|
|
v8::Local<v8::Object> local =
|
|
v8::Local<v8::Object>::New(v8_isolate(), v8::Object::New(v8_isolate()));
|
|
auto ref_from =
|
|
std::make_unique<v8::TracedReference<v8::Object>>(v8_isolate(), local);
|
|
v8::TracedReference<v8::Object> ref_to;
|
|
SimulateIncrementalMarking();
|
|
MarkingState state(i_isolate());
|
|
ASSERT_TRUE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
ref_to = std::move(*ref_from);
|
|
ASSERT_TRUE(ref_from->IsEmpty());
|
|
EXPECT_FALSE(state.IsWhite(HeapObject::cast(*Utils::OpenHandle(*local))));
|
|
}
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|