07011cc4f0
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
and may causes nested Microtasks in a problematic way. E.g. that confuses
v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
respects the microtask suppressions.
As all existing tests don't call RunMicrotasks() in the suppressed situation
(like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
not affect to these tests.
Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
Reviewed-on: https://chromium-review.googlesource.com/c/1360095
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58068}
24 lines
848 B
JavaScript
24 lines
848 B
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
//
|
|
// Flags: --allow-natives-syntax
|
|
|
|
var log = "";
|
|
var result;
|
|
Promise.resolve()
|
|
.then(() => log += "|turn1")
|
|
.then(() => log += "|turn2")
|
|
.then(() => log += "|turn3")
|
|
.then(() => log += "|turn4")
|
|
.then(() => result = "|start|turn1|fast-resolve|turn2|turn3|slow-resolve|turn4\n"+log)
|
|
.catch(e => print("ERROR", e));
|
|
|
|
Promise.resolve(Promise.resolve()).then(() => log += "|fast-resolve");
|
|
(class extends Promise {}).resolve(Promise.resolve()).then(() => log += "|slow-resolve");
|
|
|
|
log += "|start";
|
|
%PerformMicrotaskCheckpoint();
|
|
assertEquals("|start|turn1|fast-resolve|turn2|turn3|slow-resolve|turn4\n\
|
|
|start|turn1|fast-resolve|turn2|turn3|slow-resolve|turn4", result);
|