cc40fcec6f
This reduces the memory consumption of SourcePositionTable by ca. 2/3. Over Octane, this reduces the source position table memory consumption from ~370kB to ~115kB, which makes it ca. 10% of the total bytecode size (~1.1MB) ---------------- Reland CL in order to relive the glory days, and also fix memory leak w/ ENABLE_SLOW_CHECKS. SourcePositionTableBuilder used to have a no destructor since everything was zone allocated. But if ENABLE_SLOW_CHECKS, it has a heap allocated member and thus needs a proper constructor. ASAN thankfully notices this, and V8 no longer builds since this is called during mksnapshot. Breakge example: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN%20arm64%20-%20debug%20builder/builds/4829 R=jochen@chromium.org, yangguo@chromium.org, rmcilroy@chromium.org BUG=v8:4690 LOG=y Committed: https://crrev.com/a6f41f7b8226555c5900440f6e3092b3545ee0f6 Cr-Commit-Position: refs/heads/master@{#34250} patch from issue 1704943002 at patchset 200001 (http://crrev.com/1704943002#ps200001) Review URL: https://codereview.chromium.org/1731883003 Cr-Commit-Position: refs/heads/master@{#34256}
73 lines
2.1 KiB
C++
73 lines
2.1 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/interpreter/source-position-table.h"
|
|
#include "test/unittests/test-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace interpreter {
|
|
|
|
class SourcePositionTableTest : public TestWithIsolateAndZone {
|
|
public:
|
|
SourcePositionTableTest() {}
|
|
~SourcePositionTableTest() override {}
|
|
};
|
|
|
|
// Some random offsets, mostly at 'suspicious' bit boundaries.
|
|
static int offsets[] = {0, 1, 2, 3, 4, 30, 31, 32,
|
|
33, 62, 63, 64, 65, 126, 127, 128,
|
|
129, 250, 1000, 9999, 12000, 31415926};
|
|
|
|
TEST_F(SourcePositionTableTest, EncodeStatement) {
|
|
SourcePositionTableBuilder builder(isolate(), zone());
|
|
for (int i = 0; i < arraysize(offsets); i++) {
|
|
builder.AddStatementPosition(offsets[i], offsets[i]);
|
|
}
|
|
|
|
// To test correctness, we rely on the assertions in ToSourcePositionTable().
|
|
// (Also below.)
|
|
CHECK(!builder.ToSourcePositionTable().is_null());
|
|
}
|
|
|
|
TEST_F(SourcePositionTableTest, EncodeExpression) {
|
|
SourcePositionTableBuilder builder(isolate(), zone());
|
|
for (int i = 0; i < arraysize(offsets); i++) {
|
|
builder.AddExpressionPosition(offsets[i], offsets[i]);
|
|
}
|
|
CHECK(!builder.ToSourcePositionTable().is_null());
|
|
}
|
|
|
|
TEST_F(SourcePositionTableTest, EncodeAscending) {
|
|
SourcePositionTableBuilder builder(isolate(), zone());
|
|
|
|
int accumulator = 0;
|
|
for (int i = 0; i < arraysize(offsets); i++) {
|
|
accumulator += offsets[i];
|
|
if (i % 2) {
|
|
builder.AddStatementPosition(accumulator, accumulator);
|
|
} else {
|
|
builder.AddExpressionPosition(accumulator, accumulator);
|
|
}
|
|
}
|
|
|
|
// Also test negative offsets:
|
|
for (int i = 0; i < arraysize(offsets); i++) {
|
|
accumulator -= offsets[i];
|
|
if (i % 2) {
|
|
builder.AddStatementPosition(accumulator, accumulator);
|
|
} else {
|
|
builder.AddExpressionPosition(accumulator, accumulator);
|
|
}
|
|
}
|
|
|
|
CHECK(!builder.ToSourcePositionTable().is_null());
|
|
}
|
|
|
|
} // namespace interpreter
|
|
} // namespace internal
|
|
} // namespace v8
|