84dc3679d1
I want to reuse the PassType helper in another CL, thus move it from logging.h to template-utils.h, and rename it to pass_value_or_ref to match other helpers there. Also, add a boolean template parameter to declare whether array dimensions should be removed. The default is to do so, which helps to reduce the number of template instantiations by always passing arrays as pointers. Also, fix the usages in logging.h to actually use that helper when instantiating other template functions. This will reduce the number of instantiations. And finally, we now have unit tests for the template utils, to document what we expect, and test that this works on all architectures. R=ishell@chromium.org, tebbi@chromium.org Change-Id: I1ef5d2a489a5cfc7601c5ab13748674e3aa86cd6 Reviewed-on: https://chromium-review.googlesource.com/594247 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#47191} |
||
|---|---|---|
| .. | ||
| platform | ||
| utils | ||
| atomic-utils-unittest.cc | ||
| bits-unittest.cc | ||
| cpu-unittest.cc | ||
| division-by-constant-unittest.cc | ||
| flags-unittest.cc | ||
| functional-unittest.cc | ||
| ieee754-unittest.cc | ||
| iterator-unittest.cc | ||
| logging-unittest.cc | ||
| macros-unittest.cc | ||
| ostreams-unittest.cc | ||
| sys-info-unittest.cc | ||
| template-utils-unittest.cc | ||