f0d69fc913
This CL changes the usage pattern from
FOR_XXX_VALUES(i) { Use(*i); }
to
FOR_XXX_VALUES(i) { Use(i); }
which is way more intuitive.
Note that the replacement in the uses was done via regular expression,
so it's purely mechanical. In two locations I removed unneeded braces
around the macro, because they confused clang-format.
I plan to do more cleanups (remove redundant assignments within the
FOR_XXX_VALUES body) in a follow-up CL.
R=mstarzinger@chromium.org
Bug: v8:8562
Change-Id: I4329bfcf34e5b077d19b50f4204ceb3b4340fe61
Reviewed-on: https://chromium-review.googlesource.com/c/1449615
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59287}
201 lines
6.0 KiB
C++
201 lines
6.0 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <stdint.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include "src/assembler-inl.h"
|
|
#include "src/base/platform/elapsed-timer.h"
|
|
|
|
#include "test/cctest/cctest.h"
|
|
#include "test/cctest/compiler/value-helper.h"
|
|
#include "test/cctest/wasm/wasm-run-utils.h"
|
|
#include "test/common/wasm/test-signatures.h"
|
|
#include "test/common/wasm/wasm-macro-gen.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace wasm {
|
|
|
|
WASM_EXEC_TEST(Int32AsmjsDivS) {
|
|
WasmRunner<int32_t, int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsDivS, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
|
|
const int32_t kMin = std::numeric_limits<int32_t>::min();
|
|
CHECK_EQ(0, r.Call(0, 100));
|
|
CHECK_EQ(0, r.Call(100, 0));
|
|
CHECK_EQ(0, r.Call(-1001, 0));
|
|
CHECK_EQ(kMin, r.Call(kMin, -1));
|
|
CHECK_EQ(0, r.Call(kMin, 0));
|
|
}
|
|
|
|
WASM_EXEC_TEST(Int32AsmjsRemS) {
|
|
WasmRunner<int32_t, int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsRemS, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
|
|
const int32_t kMin = std::numeric_limits<int32_t>::min();
|
|
CHECK_EQ(33, r.Call(133, 100));
|
|
CHECK_EQ(0, r.Call(kMin, -1));
|
|
CHECK_EQ(0, r.Call(100, 0));
|
|
CHECK_EQ(0, r.Call(-1001, 0));
|
|
CHECK_EQ(0, r.Call(kMin, 0));
|
|
}
|
|
|
|
WASM_EXEC_TEST(Int32AsmjsDivU) {
|
|
WasmRunner<int32_t, int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsDivU, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
|
|
const int32_t kMin = std::numeric_limits<int32_t>::min();
|
|
CHECK_EQ(0, r.Call(0, 100));
|
|
CHECK_EQ(0, r.Call(kMin, -1));
|
|
CHECK_EQ(0, r.Call(100, 0));
|
|
CHECK_EQ(0, r.Call(-1001, 0));
|
|
CHECK_EQ(0, r.Call(kMin, 0));
|
|
}
|
|
|
|
WASM_EXEC_TEST(Int32AsmjsRemU) {
|
|
WasmRunner<int32_t, int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsRemU, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
|
|
const int32_t kMin = std::numeric_limits<int32_t>::min();
|
|
CHECK_EQ(17, r.Call(217, 100));
|
|
CHECK_EQ(0, r.Call(100, 0));
|
|
CHECK_EQ(0, r.Call(-1001, 0));
|
|
CHECK_EQ(0, r.Call(kMin, 0));
|
|
CHECK_EQ(kMin, r.Call(kMin, -1));
|
|
}
|
|
|
|
WASM_EXEC_TEST(I32AsmjsSConvertF32) {
|
|
WasmRunner<int32_t, float> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsSConvertF32, WASM_GET_LOCAL(0)));
|
|
|
|
FOR_FLOAT32_INPUTS(i) {
|
|
int32_t expected = DoubleToInt32(i);
|
|
CHECK_EQ(expected, r.Call(i));
|
|
}
|
|
}
|
|
|
|
WASM_EXEC_TEST(I32AsmjsSConvertF64) {
|
|
WasmRunner<int32_t, double> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsSConvertF64, WASM_GET_LOCAL(0)));
|
|
|
|
FOR_FLOAT64_INPUTS(i) {
|
|
int32_t expected = DoubleToInt32(i);
|
|
CHECK_EQ(expected, r.Call(i));
|
|
}
|
|
}
|
|
|
|
WASM_EXEC_TEST(I32AsmjsUConvertF32) {
|
|
WasmRunner<uint32_t, float> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsUConvertF32, WASM_GET_LOCAL(0)));
|
|
|
|
FOR_FLOAT32_INPUTS(i) {
|
|
uint32_t expected = DoubleToUint32(i);
|
|
CHECK_EQ(expected, r.Call(i));
|
|
}
|
|
}
|
|
|
|
WASM_EXEC_TEST(I32AsmjsUConvertF64) {
|
|
WasmRunner<uint32_t, double> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsUConvertF64, WASM_GET_LOCAL(0)));
|
|
|
|
FOR_FLOAT64_INPUTS(i) {
|
|
uint32_t expected = DoubleToUint32(i);
|
|
CHECK_EQ(expected, r.Call(i));
|
|
}
|
|
}
|
|
|
|
WASM_EXEC_TEST(LoadMemI32_oob_asm) {
|
|
WasmRunner<int32_t, uint32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
int32_t* memory = r.builder().AddMemoryElems<int32_t>(8);
|
|
r.builder().RandomizeMemory(1112);
|
|
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsLoadMem, WASM_GET_LOCAL(0)));
|
|
|
|
memory[0] = 999999;
|
|
CHECK_EQ(999999, r.Call(0u));
|
|
// TODO(titzer): offset 29-31 should also be OOB.
|
|
for (uint32_t offset = 32; offset < 40; offset++) {
|
|
CHECK_EQ(0, r.Call(offset));
|
|
}
|
|
|
|
for (uint32_t offset = 0x80000000; offset < 0x80000010; offset++) {
|
|
CHECK_EQ(0, r.Call(offset));
|
|
}
|
|
}
|
|
|
|
WASM_EXEC_TEST(LoadMemF32_oob_asm) {
|
|
WasmRunner<float, uint32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
float* memory = r.builder().AddMemoryElems<float>(8);
|
|
r.builder().RandomizeMemory(1112);
|
|
|
|
BUILD(r, WASM_UNOP(kExprF32AsmjsLoadMem, WASM_GET_LOCAL(0)));
|
|
|
|
memory[0] = 9999.5f;
|
|
CHECK_EQ(9999.5f, r.Call(0u));
|
|
// TODO(titzer): offset 29-31 should also be OOB.
|
|
for (uint32_t offset = 32; offset < 40; offset++) {
|
|
CHECK(std::isnan(r.Call(offset)));
|
|
}
|
|
|
|
for (uint32_t offset = 0x80000000; offset < 0x80000010; offset++) {
|
|
CHECK(std::isnan(r.Call(offset)));
|
|
}
|
|
}
|
|
|
|
WASM_EXEC_TEST(LoadMemF64_oob_asm) {
|
|
WasmRunner<double, uint32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
double* memory = r.builder().AddMemoryElems<double>(8);
|
|
r.builder().RandomizeMemory(1112);
|
|
|
|
BUILD(r, WASM_UNOP(kExprF64AsmjsLoadMem, WASM_GET_LOCAL(0)));
|
|
|
|
memory[0] = 9799.5;
|
|
CHECK_EQ(9799.5, r.Call(0u));
|
|
memory[1] = 11799.25;
|
|
CHECK_EQ(11799.25, r.Call(8u));
|
|
// TODO(titzer): offset 57-63 should also be OOB.
|
|
for (uint32_t offset = 64; offset < 80; offset++) {
|
|
CHECK(std::isnan(r.Call(offset)));
|
|
}
|
|
|
|
for (uint32_t offset = 0x80000000; offset < 0x80000010; offset++) {
|
|
CHECK(std::isnan(r.Call(offset)));
|
|
}
|
|
}
|
|
|
|
WASM_EXEC_TEST(StoreMemI32_oob_asm) {
|
|
WasmRunner<int32_t, uint32_t, uint32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
int32_t* memory = r.builder().AddMemoryElems<int32_t>(8);
|
|
r.builder().RandomizeMemory(1112);
|
|
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsStoreMem, WASM_GET_LOCAL(0),
|
|
WASM_GET_LOCAL(1)));
|
|
|
|
memory[0] = 7777;
|
|
CHECK_EQ(999999, r.Call(0u, 999999));
|
|
CHECK_EQ(999999, memory[0]);
|
|
// TODO(titzer): offset 29-31 should also be OOB.
|
|
for (uint32_t offset = 32; offset < 40; offset++) {
|
|
CHECK_EQ(8888, r.Call(offset, 8888));
|
|
}
|
|
|
|
for (uint32_t offset = 0x10000000; offset < 0xF0000000; offset += 0x1000000) {
|
|
CHECK_EQ(7777, r.Call(offset, 7777));
|
|
}
|
|
}
|
|
|
|
} // namespace wasm
|
|
} // namespace internal
|
|
} // namespace v8
|