851a395fb5
This fixes issues with replacing the return address of deeper (non-top) wasm frames, i.e. frames which are at a call position. The replaced address should also point after the call in the new code, so we don't execute the same call again. This is achieved by using slightly different encodings for breakpoint positions and other (wasm instruction) positions. Breakpoints set {is_instruction} to {false} in the source position table entry, whereas usual wasm instruction set it to {true}. Also, during stack walking for OSR, we remember whether we want to OSR to the position before the instruction (if it's the top frame), or after the call instruction (if it's deeper in the stack). We then use the {is_instruction} predicate to find the right location. R=thibaudm@chromium.org Bug: v8:10321 Change-Id: I73212a7532c6ecf4c82bde76fe4059c8203e422c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116206 Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66850} |
||
---|---|---|
.. | ||
console | ||
cpu-profiler | ||
debugger | ||
heap-profiler | ||
runtime | ||
runtime-call-stats | ||
sessions | ||
type-profiler | ||
BUILD.gn | ||
DEPS | ||
inspector-test.cc | ||
inspector.status | ||
isolate-data.cc | ||
isolate-data.h | ||
json-parse-expected.txt | ||
json-parse.js | ||
OWNERS | ||
print-method-not-found-expected.txt | ||
print-method-not-found.js | ||
protocol-test.js | ||
task-runner.cc | ||
task-runner.h | ||
testcfg.py |