852a20b08c
Reason for revert:
Breaks:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/12920
and
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/10281
Original issue's description:
> [builtins] DeleteProperty: Handle last-added fast properties
>
> In general, deleting a property from a fast-properties object
> requires transitioning the object to dictionary mode. However,
> when the most-recently-added property is deleted, we can simply
> roll back the last map transition that the object went through.
>
> This is a performance experiment: it should make things faster,
> but if it turns out to have more negative than positive impact,
> we will have to revert it.
>
> TBR=bmeurer@chromium.org (just adding a comment)
>
> Review-Url: https://codereview.chromium.org/2830093002
> Cr-Commit-Position: refs/heads/master@{#44799}
> Committed: 98acfb36e1
TBR=ishell@chromium.org,jkummerow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2843473002
Cr-Commit-Position: refs/heads/master@{#44806}
64 lines
2.6 KiB
JavaScript
64 lines
2.6 KiB
JavaScript
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --allow-natives-syntax --crankshaft
|
|
|
|
// The type feedback oracle had a bug when retrieving the map from an IC
|
|
// starting with a negative lookup.
|
|
|
|
// Create a holder in fast mode.
|
|
var holder = Object.create({}, {
|
|
holderMethod: {value: function() {}}
|
|
});
|
|
assertTrue(%HasFastProperties(holder));
|
|
|
|
// We assume dict usage for null prototype.
|
|
var holder = Object.create(null, {
|
|
holderMethod: {value: function() {}}
|
|
});
|
|
assertFalse(%HasFastProperties(holder));
|
|
|
|
// Create a receiver into dictionary mode.
|
|
var receiver = Object.create(holder, {
|
|
killMe: {value: 0, configurable: true},
|
|
});
|
|
delete receiver.killMe;
|
|
assertFalse(%HasFastProperties(receiver));
|
|
|
|
// The actual function to test, triggering the retrieval of the wrong map.
|
|
function callConstantFunctionOnPrototype(obj) {
|
|
obj.holderMethod();
|
|
}
|
|
|
|
callConstantFunctionOnPrototype(receiver);
|
|
callConstantFunctionOnPrototype(receiver);
|
|
%OptimizeFunctionOnNextCall(callConstantFunctionOnPrototype);
|
|
callConstantFunctionOnPrototype(receiver);
|
|
|
|
// Make sure that the function is still optimized.
|
|
assertOptimized(callConstantFunctionOnPrototype);
|