089edbfa97
Debug-evaluate used to resolve stack variables that shadow context variables incorrectly, since the stack variable is not visible in the context chain. To fix this, we limit local variables accessible by debug- evaluate to the ones directly referenced inside the function. What is not referenced by the function itself, is considered optimized out and not accessible by debug-evaluate. To achieve this, we duplicate the entire context chain up to the native context, and write back changes after debug- evaluate. Changes to the original context chain will however be overwritten. This already happens for catch and block scopes though. Also fix a crash caused by declaring variables inside debug- evaluate. R=mstarzinger@chromium.org BUG=v8:4593 LOG=N Review URL: https://codereview.chromium.org/1500933002 Cr-Commit-Position: refs/heads/master@{#32828}
45 lines
1.3 KiB
JavaScript
45 lines
1.3 KiB
JavaScript
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --expose-debug-as debug
|
|
|
|
// Test that debug-evaluate only resolves variables that are used by
|
|
// the function inside which we debug-evaluate. This is to avoid
|
|
// incorrect variable resolution when a context-allocated variable is
|
|
// shadowed by a stack-allocated variable.
|
|
|
|
"use strict";
|
|
|
|
var Debug = debug.Debug
|
|
|
|
var exception = null;
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
exec_state.frame(0).evaluate("var x = 2");
|
|
exec_state.frame(0).evaluate("'use strict'; let y = 3");
|
|
exec_state.frame(0).evaluate("var z = 4");
|
|
exec_state.frame(0).evaluate("function bar() { return 5; }");
|
|
} catch (e) {
|
|
exception = e;
|
|
print(e + e.stack);
|
|
}
|
|
}
|
|
|
|
Debug.setListener(listener);
|
|
|
|
var z = 1;
|
|
|
|
(function() {
|
|
debugger;
|
|
})();
|
|
|
|
assertEquals(2, x); // declaration
|
|
assertThrows(() => y, ReferenceError); // let-declaration does not stick
|
|
assertEquals(4, z); // re-declaration
|
|
assertEquals(5, bar()); // function declaration
|
|
|
|
Debug.setListener(null);
|
|
assertNull(exception);
|