b54f1360b7
Compiling Sparkplug on the heap saved 10% of the CompileBaseline RCS metric, but that came with too much code complexity. Since in the end that corresponds to < 1% of the entire compilation time, we decided to revert this project. This reverts: commite29b2ae48acommitd1f2a83b7dcommit4666e18206commita1147408e4commite0d4254f97commit9ab8422da7commita3b24ecc51commit1eb8770691commitfe5c9dfd90commit7ac3b55a20commit7e95f30ec9commit323b596212commit6bf0b70490commite82b368b67commit5020d83e05commit642a467338commitec7b99d5c6commitfb4f89aedecommit208854bb14commit63be6dde31Bug: v8:12158 Change-Id: I9f2539be6c7d80c6e243c9ab173e3c5bb0dff97d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3136453 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77319}
74 lines
2.0 KiB
JavaScript
74 lines
2.0 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --sparkplug --no-always-sparkplug --sparkplug-filter="test*"
|
|
// Flags: --allow-natives-syntax --expose-gc --no-always-opt
|
|
// Flags: --baseline-batch-compilation --baseline-batch-compilation-threshold=200
|
|
// Flags: --scale-factor-for-feedback-allocation=4
|
|
|
|
// Flags to drive Fuzzers into the right direction
|
|
// TODO(v8:11853): Remove these flags once fuzzers handle flag implications
|
|
// better.
|
|
// Flags: --lazy-feedback-allocation --no-stress-concurrent-inlining
|
|
|
|
// Basic test
|
|
(function() {
|
|
// Bytecode length 24 -> estimated instruction size 120 - 168.
|
|
function test1 (a,b) {
|
|
return (a + b + 11) * 42 / a % b;
|
|
}
|
|
|
|
// Bytecode length 24 -> estimated instruction size 120 - 168.
|
|
function test2 (a,b) {
|
|
return (a + b + 11) * 42 / a % b;
|
|
}
|
|
|
|
%NeverOptimizeFunction(test1);
|
|
// Trigger bytecode budget interrupt for test1.
|
|
for (let i=0; i<5; ++i) {
|
|
test1(i,4711);
|
|
}
|
|
// Shouldn't be compiled because of batch compilation.
|
|
assertFalse(isBaseline(test1));
|
|
|
|
%NeverOptimizeFunction(test2);
|
|
// Trigger bytecode budget interrupt for test2.
|
|
for (let i=0; i<5; ++i) {
|
|
test2(i,4711);
|
|
}
|
|
|
|
// Call test1 again so baseline code gets installed on the function.
|
|
test1(1,2);
|
|
|
|
// Both functions should be compiled with baseline now.
|
|
assertTrue(isBaseline(test1));
|
|
assertTrue(isBaseline(test2));
|
|
})();
|
|
|
|
// Test function weak handle.
|
|
(function() {
|
|
function test_weak (a,b) {
|
|
return (a + b + 11) * 42 / a % b;
|
|
}
|
|
|
|
function test2 (a,b) {
|
|
return (a + b + 11) * 42 / a % b;
|
|
}
|
|
|
|
%NeverOptimizeFunction(test_weak);
|
|
for (let i=0; i<5; ++i) {
|
|
test_weak(i,4711);
|
|
}
|
|
|
|
gc(); // GC should cause the handle to test_weak to be freed.
|
|
|
|
%NeverOptimizeFunction(test2);
|
|
// Trigger bytecode budget interrupt for test2.
|
|
for (let i=0; i<5; ++i) {
|
|
test2(i,4711);
|
|
}
|
|
|
|
assertTrue(isBaseline(test2));
|
|
})();
|