8844cfd925
This reverts commit 0c459ff52b
.
Reason for revert: breaks build on M1 (where W^X flag is RO) https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release%20builder/6999/overview
Original change's description:
> [baseline] Concurrent Sparkplug n-thread with synchronised queue
>
> Installation in the main thread.
> Design doc: https://docs.google.com/document/d/1GmEiEt2VDmhY_Ag0PiIcGWKtvQupKgNcMZUvgpfQksk/edit?resourcekey=0-seYa-QJsx1ZbjelluPG1iQ
>
> Change-Id: Ifc6eccd44efdf377320c64cf9957c6060334e543
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186831
> Commit-Queue: Victor Gomes <victorgomes@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#77431}
Change-Id: I45a952aacf0ad29ebb703a742fdc6da7b0b7c826
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3229378
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Owners-Override: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77433}
85 lines
2.0 KiB
JavaScript
85 lines
2.0 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --expose-gc --stress-flush-code --allow-natives-syntax
|
|
// Flags: --baseline-batch-compilation-threshold=0 --sparkplug
|
|
// Flags: --no-always-sparkplug --lazy-feedback-allocation
|
|
// Flags: --flush-baseline-code --flush-bytecode --no-opt
|
|
// Flags: --no-stress-concurrent-inlining
|
|
|
|
function HasBaselineCode(f) {
|
|
let opt_status = %GetOptimizationStatus(f);
|
|
return (opt_status & V8OptimizationStatus.kBaseline) !== 0;
|
|
}
|
|
|
|
function HasByteCode(f) {
|
|
let opt_status = %GetOptimizationStatus(f);
|
|
return (opt_status & V8OptimizationStatus.kInterpreted) !== 0;
|
|
}
|
|
|
|
var x = {b:20, c:30};
|
|
function f() {
|
|
return x.b + 10;
|
|
}
|
|
|
|
// Test bytecode gets flushed
|
|
f();
|
|
assertTrue(HasByteCode(f));
|
|
gc();
|
|
assertFalse(HasByteCode(f));
|
|
|
|
// Test baseline code and bytecode gets flushed
|
|
for (i = 1; i < 50; i++) {
|
|
f();
|
|
}
|
|
assertTrue(HasBaselineCode(f));
|
|
gc();
|
|
assertFalse(HasBaselineCode(f));
|
|
assertFalse(HasByteCode(f));
|
|
|
|
// Check bytecode isn't flushed if it's held strongly from somewhere but
|
|
// baseline code is flushed.
|
|
function f1(should_recurse) {
|
|
if (should_recurse) {
|
|
assertTrue(HasByteCode(f1));
|
|
for (i = 1; i < 50; i++) {
|
|
f1(false);
|
|
}
|
|
assertTrue(HasBaselineCode(f1));
|
|
gc();
|
|
assertFalse(HasBaselineCode(f1));
|
|
assertTrue(HasByteCode(f1));
|
|
}
|
|
return x.b + 10;
|
|
}
|
|
|
|
f1(false);
|
|
// Recurse first time so we have bytecode array on the stack that keeps
|
|
// bytecode alive.
|
|
f1(true);
|
|
|
|
// Flush bytecode
|
|
gc();
|
|
assertFalse(HasBaselineCode(f1));
|
|
assertFalse(HasByteCode(f1));
|
|
|
|
// Check baseline code and bytecode aren't flushed if baseline code is on
|
|
// stack.
|
|
function f2(should_recurse) {
|
|
if (should_recurse) {
|
|
assertTrue(HasBaselineCode(f2));
|
|
f2(false);
|
|
gc();
|
|
assertTrue(HasBaselineCode(f2));
|
|
}
|
|
return x.b + 10;
|
|
}
|
|
|
|
for (i = 1; i < 50; i++) {
|
|
f2(false);
|
|
}
|
|
assertTrue(HasBaselineCode(f2));
|
|
// Recurse with baseline code on stack
|
|
f2(true);
|