v8/test/inspector
Benedikt Meurer b141fedfed [inspector] Improve class name inference.
Previously having a `Symbol.toStringTag` property holding a string
somewhere in the prototype chain would always take predence over trying
to determine a reasonable name from the "constructor" (in case of
subclassing). This would lead to confusing behavior when diagnosing
objects in DevTools, for example

```js
class A extends URLSearchParams {};
new A()
```

would show `URLSearchParam` as class name for the instance rather than
`A`.

With this CL, we change the lookup logic to explicitly check for
`Symbol.toStringTag` and "constructor" along each step of the prototype
chain (skipping the "constructor" for the leaf object) and pick the
first one that yields a string (that is the function debug name in case
of "constructor").

Fixed: chromium:980018
Change-Id: Ic920b4bae02f965bc383c711f8de89c0de55fcac
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231078
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77453}
2021-10-19 11:40:06 +00:00
..
console Reland 2 ScriptContext CLs 2020-01-22 15:40:06 +00:00
cpu-profiler [compiler][test] Remove --block-concurrent-recompilation 2021-08-16 10:15:53 +00:00
debugger [inspector] Properly catch side effecting iterators. 2021-10-15 12:29:09 +00:00
heap-profiler heap-snapshot: Add detachedness field 2020-09-09 14:42:41 +00:00
regress [inspector] Improve class name inference. 2021-10-19 11:40:06 +00:00
runtime [inspector] Mark Intl builtins as side-effect free. 2021-10-01 05:31:16 +00:00
sessions [inspector] Add executionContextId to Runtime.inspectRequested. 2021-07-23 08:41:03 +00:00
type-profiler [tests] Filter out non-existent methods in inspector tests 2020-01-17 12:21:29 +00:00
BUILD.gn Include test/inspector/regress to swarming 2021-07-29 08:00:47 +00:00
DEPS [inspector][fuzzer] Extract functionality for reuse 2020-10-28 08:37:25 +00:00
DIR_METADATA Add DIR_METADATA files to v8. 2020-10-20 22:12:28 +00:00
frontend-channel.h Fix name collision of v8::internal::IsolateData 2021-08-25 08:45:53 +00:00
inspector-test.cc [sandbox] Disallow ArrayBuffers outside the VM Cage 2021-08-25 09:52:38 +00:00
inspector.status [inspector] Mark Intl builtins as side-effect free. 2021-10-01 05:31:16 +00:00
isolate-data.cc Fix name collision of v8::internal::IsolateData 2021-08-25 08:45:53 +00:00
isolate-data.h Fix name collision of v8::internal::IsolateData 2021-08-25 08:45:53 +00:00
json-parse-expected.txt [inspector] Refactor protocol-test.js 2017-05-19 00:35:45 +00:00
json-parse.js [inspector] Refactor protocol-test.js 2017-05-19 00:35:45 +00:00
OWNERS Add DIR_METADATA files to v8. 2020-10-20 22:12:28 +00:00
print-method-not-found-expected.txt [tests] Filter out non-existent methods in inspector tests 2020-01-17 12:21:29 +00:00
print-method-not-found.js [tests] Filter out non-existent methods in inspector tests 2020-01-17 12:21:29 +00:00
protocol-test.js [inspector] Remove unused formatAccessorsAsProperties(). 2021-08-10 06:48:59 +00:00
task-runner.cc Fix name collision of v8::internal::IsolateData 2021-08-25 08:45:53 +00:00
task-runner.h Fix name collision of v8::internal::IsolateData 2021-08-25 08:45:53 +00:00
tasks.cc Fix name collision of v8::internal::IsolateData 2021-08-25 08:45:53 +00:00
tasks.h Fix name collision of v8::internal::IsolateData 2021-08-25 08:45:53 +00:00
testcfg.py [test] Load missing file to Android devices for inspector test suite 2020-07-21 14:11:11 +00:00
utils.cc Reland "[include] Split out v8.h" 2021-08-24 13:08:55 +00:00
utils.h Reland "[include] Split out v8.h" 2021-08-24 13:08:55 +00:00
wasm-inspector-test.js [wasm][debug] Provide WebAssembly Table entries to DevTools 2021-05-20 09:59:09 +00:00