f3568ca400
test262 "negative" test expectations list which exception is thrown. The ES2017 draft specification is very specific about which exception class is thrown from which path, and V8 works hard to be correct with respect to that spec. Previously, the test262 test runner would accept any nonzero status code, such as from a crash, or a FAIL printed out, for a negative test. This patch makes negative tests check for the right answer using a quick-and-dirty parsing of the exception printing from d8 to find the exception class. It invokes d8 in a way to get a status code of 0 from thrown exceptions so that 'negative' tests aren't actually implemented by negating the output. Amazingly, this didn't catch any test262 failures, but I verified the extra checking interactively by changing a negative test to expect a different type and saw it fail. BUG=v8:4803 R=machenbach LOG=Y Review URL: https://codereview.chromium.org/1766503002 Cr-Commit-Position: refs/heads/master@{#34763}
127 lines
5.0 KiB
Python
127 lines
5.0 KiB
Python
# Copyright 2008 the V8 project authors. All rights reserved.
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions are
|
|
# met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above
|
|
# copyright notice, this list of conditions and the following
|
|
# disclaimer in the documentation and/or other materials provided
|
|
# with the distribution.
|
|
# * Neither the name of Google Inc. nor the names of its
|
|
# contributors may be used to endorse or promote products derived
|
|
# from this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
import itertools
|
|
import os
|
|
import re
|
|
|
|
from testrunner.local import testsuite
|
|
from testrunner.local import utils
|
|
from testrunner.objects import testcase
|
|
|
|
|
|
FLAGS_PATTERN = re.compile(r"//\s+Flags:(.*)")
|
|
INVALID_FLAGS = ["--enable-slow-asserts"]
|
|
MODULE_PATTERN = re.compile(r"^// MODULE$", flags=re.MULTILINE)
|
|
|
|
|
|
class MessageTestSuite(testsuite.TestSuite):
|
|
def __init__(self, name, root):
|
|
super(MessageTestSuite, self).__init__(name, root)
|
|
|
|
def ListTests(self, context):
|
|
tests = []
|
|
for dirname, dirs, files in os.walk(self.root):
|
|
for dotted in [x for x in dirs if x.startswith('.')]:
|
|
dirs.remove(dotted)
|
|
dirs.sort()
|
|
files.sort()
|
|
for filename in files:
|
|
if filename.endswith(".js"):
|
|
fullpath = os.path.join(dirname, filename)
|
|
relpath = fullpath[len(self.root) + 1 : -3]
|
|
testname = relpath.replace(os.path.sep, "/")
|
|
test = testcase.TestCase(self, testname)
|
|
tests.append(test)
|
|
return tests
|
|
|
|
def CreateVariantGenerator(self, variants):
|
|
return super(MessageTestSuite, self).CreateVariantGenerator(
|
|
variants + ["preparser"])
|
|
|
|
def GetFlagsForTestCase(self, testcase, context):
|
|
source = self.GetSourceForTest(testcase)
|
|
result = []
|
|
flags_match = re.findall(FLAGS_PATTERN, source)
|
|
for match in flags_match:
|
|
result += match.strip().split()
|
|
result += context.mode_flags
|
|
if MODULE_PATTERN.search(source):
|
|
result.append("--module")
|
|
result = [x for x in result if x not in INVALID_FLAGS]
|
|
result.append(os.path.join(self.root, testcase.path + ".js"))
|
|
return testcase.flags + result
|
|
|
|
def GetSourceForTest(self, testcase):
|
|
filename = os.path.join(self.root, testcase.path + self.suffix())
|
|
with open(filename) as f:
|
|
return f.read()
|
|
|
|
def _IgnoreLine(self, string):
|
|
"""Ignore empty lines, valgrind output, Android output."""
|
|
if not string: return True
|
|
if not string.strip(): return True
|
|
return (string.startswith("==") or string.startswith("**") or
|
|
string.startswith("ANDROID") or
|
|
# These five patterns appear in normal Native Client output.
|
|
string.startswith("DEBUG MODE ENABLED") or
|
|
string.startswith("tools/nacl-run.py") or
|
|
string.find("BYPASSING ALL ACL CHECKS") > 0 or
|
|
string.find("Native Client module will be loaded") > 0 or
|
|
string.find("NaClHostDescOpen:") > 0)
|
|
|
|
def IsFailureOutput(self, testcase):
|
|
output = testcase.output
|
|
testpath = testcase.path
|
|
expected_path = os.path.join(self.root, testpath + ".out")
|
|
expected_lines = []
|
|
# Can't use utils.ReadLinesFrom() here because it strips whitespace.
|
|
with open(expected_path) as f:
|
|
for line in f:
|
|
if line.startswith("#") or not line.strip(): continue
|
|
expected_lines.append(line)
|
|
raw_lines = output.stdout.splitlines()
|
|
actual_lines = [ s for s in raw_lines if not self._IgnoreLine(s) ]
|
|
env = { "basename": os.path.basename(testpath + ".js") }
|
|
if len(expected_lines) != len(actual_lines):
|
|
return True
|
|
for (expected, actual) in itertools.izip_longest(
|
|
expected_lines, actual_lines, fillvalue=''):
|
|
pattern = re.escape(expected.rstrip() % env)
|
|
pattern = pattern.replace("\\*", ".*")
|
|
pattern = "^%s$" % pattern
|
|
if not re.match(pattern, actual):
|
|
return True
|
|
return False
|
|
|
|
def StripOutputForTransmit(self, testcase):
|
|
pass
|
|
|
|
|
|
def GetSuite(name, root):
|
|
return MessageTestSuite(name, root)
|