8b1a5681de
Bill kindly pointed out to me that v8windbg was not handling bit_field2 correctly. The issue was that the constexpr type for ElementsKind was, somewhat unsurprisingly, "ElementsKind", but v8windbg expected a fully- qualified type name like "v8::internal::ElementsKind". This change addresses the problem in two ways: 1. Update v8windbg's type resolution logic to resolve type names as if they were used in the v8::internal namespace. This makes it more consistent with how those type names are used in other generated Torque code, reducing surprises and the number of times we have to write `v8::internal::` in .tq files. 2. Add compile-time verification that any constexpr type name used as a string in class-debug-readers-tq.cc can also resolve as a type name. Bug: v8:9376 Change-Id: I349cd6ab586fd8345a1fa8bfc3989bb8e6376ab8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2063769 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#66633}
66 lines
1.9 KiB
C++
66 lines
1.9 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "debug-helper-internal.h"
|
|
#include "src/common/ptr-compr-inl.h"
|
|
#include "torque-generated/class-debug-readers-tq.h"
|
|
|
|
namespace i = v8::internal;
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace debug_helper_internal {
|
|
|
|
bool IsPointerCompressed(uintptr_t address) {
|
|
#if COMPRESS_POINTERS_BOOL
|
|
return address < i::kPtrComprHeapReservationSize;
|
|
#else
|
|
return false;
|
|
#endif
|
|
}
|
|
|
|
uintptr_t EnsureDecompressed(uintptr_t address,
|
|
uintptr_t any_uncompressed_ptr) {
|
|
if (!COMPRESS_POINTERS_BOOL || !IsPointerCompressed(address)) return address;
|
|
return i::DecompressTaggedAny(any_uncompressed_ptr,
|
|
static_cast<i::Tagged_t>(address));
|
|
}
|
|
|
|
d::PropertyKind GetArrayKind(d::MemoryAccessResult mem_result) {
|
|
d::PropertyKind indexed_field_kind{};
|
|
switch (mem_result) {
|
|
case d::MemoryAccessResult::kOk:
|
|
indexed_field_kind = d::PropertyKind::kArrayOfKnownSize;
|
|
break;
|
|
case d::MemoryAccessResult::kAddressNotValid:
|
|
indexed_field_kind =
|
|
d::PropertyKind::kArrayOfUnknownSizeDueToInvalidMemory;
|
|
break;
|
|
default:
|
|
indexed_field_kind =
|
|
d::PropertyKind::kArrayOfUnknownSizeDueToValidButInaccessibleMemory;
|
|
break;
|
|
}
|
|
return indexed_field_kind;
|
|
}
|
|
|
|
std::vector<std::unique_ptr<ObjectProperty>> TqObject::GetProperties(
|
|
d::MemoryAccessor accessor) const {
|
|
return std::vector<std::unique_ptr<ObjectProperty>>();
|
|
}
|
|
|
|
const char* TqObject::GetName() const { return "v8::internal::Object"; }
|
|
|
|
void TqObject::Visit(TqObjectVisitor* visitor) const {
|
|
visitor->VisitObject(this);
|
|
}
|
|
|
|
bool TqObject::IsSuperclassOf(const TqObject* other) const {
|
|
return GetName() != other->GetName();
|
|
}
|
|
|
|
} // namespace debug_helper_internal
|
|
} // namespace internal
|
|
} // namespace v8
|