c0c3b20782
This fixes a non-determinism issue caused by the cache being full. Depending on the non-deterministic value of the handles in HeapConstant nodes, different cache entries would be overwritten in this case. The old implementation of NodeCache had a fixed limit, overwriting entries when the cache is full. This behavior didn't really make sense, but the hand-written hash map implementation couldn't handle arbitrary numbers of hash collisions, so removing the limit wasn't an option either. Thus this CL just replaces the custom hash map with a normal std::unordered_map, that is, a ZoneUnorderedMap. Bug: chromium:1046815 Change-Id: I95269f2b1068eb9dfe3ee2ab5cca1cb460bc8fa3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2087405 Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66592}
162 lines
4.2 KiB
C++
162 lines
4.2 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/compiler/node-cache.h"
|
|
#include "test/unittests/compiler/graph-unittest.h"
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gmock-support.h"
|
|
|
|
using testing::Contains;
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
namespace node_cache_unittest {
|
|
|
|
using NodeCacheTest = GraphTest;
|
|
|
|
TEST_F(NodeCacheTest, Int32Constant_back_to_back) {
|
|
Int32NodeCache cache(zone());
|
|
|
|
for (int i = -2000000000; i < 2000000000; i += 3315177) {
|
|
Node** pos = cache.Find(i);
|
|
ASSERT_TRUE(pos != nullptr);
|
|
for (int j = 0; j < 3; j++) {
|
|
Node** npos = cache.Find(i);
|
|
EXPECT_EQ(pos, npos);
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
TEST_F(NodeCacheTest, Int32Constant_five) {
|
|
Int32NodeCache cache(zone());
|
|
int32_t constants[] = {static_cast<int32_t>(0x80000000), -77, 0, 1, -1};
|
|
Node* nodes[arraysize(constants)];
|
|
|
|
for (size_t i = 0; i < arraysize(constants); i++) {
|
|
int32_t k = constants[i];
|
|
Node* node = graph()->NewNode(common()->Int32Constant(k));
|
|
*cache.Find(k) = nodes[i] = node;
|
|
}
|
|
|
|
for (size_t i = 0; i < arraysize(constants); i++) {
|
|
int32_t k = constants[i];
|
|
EXPECT_EQ(nodes[i], *cache.Find(k));
|
|
}
|
|
}
|
|
|
|
|
|
TEST_F(NodeCacheTest, Int32Constant_hits) {
|
|
Int32NodeCache cache(zone());
|
|
const int32_t kSize = 1500;
|
|
Node** nodes = zone()->NewArray<Node*>(kSize);
|
|
|
|
for (int i = 0; i < kSize; i++) {
|
|
int32_t v = i * -55;
|
|
nodes[i] = graph()->NewNode(common()->Int32Constant(v));
|
|
*cache.Find(v) = nodes[i];
|
|
}
|
|
|
|
int hits = 0;
|
|
for (int i = 0; i < kSize; i++) {
|
|
int32_t v = i * -55;
|
|
Node** pos = cache.Find(v);
|
|
if (*pos != nullptr) {
|
|
EXPECT_EQ(nodes[i], *pos);
|
|
hits++;
|
|
}
|
|
}
|
|
EXPECT_LT(4, hits);
|
|
}
|
|
|
|
|
|
TEST_F(NodeCacheTest, Int64Constant_back_to_back) {
|
|
Int64NodeCache cache(zone());
|
|
|
|
for (int64_t i = -2000000000; i < 2000000000; i += 3315177) {
|
|
Node** pos = cache.Find(i);
|
|
ASSERT_TRUE(pos != nullptr);
|
|
for (int j = 0; j < 3; j++) {
|
|
Node** npos = cache.Find(i);
|
|
EXPECT_EQ(pos, npos);
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
TEST_F(NodeCacheTest, Int64Constant_hits) {
|
|
Int64NodeCache cache(zone());
|
|
const int32_t kSize = 1500;
|
|
Node** nodes = zone()->NewArray<Node*>(kSize);
|
|
|
|
for (int i = 0; i < kSize; i++) {
|
|
int64_t v = static_cast<int64_t>(i) * static_cast<int64_t>(5003001);
|
|
nodes[i] = graph()->NewNode(common()->Int32Constant(i));
|
|
*cache.Find(v) = nodes[i];
|
|
}
|
|
|
|
int hits = 0;
|
|
for (int i = 0; i < kSize; i++) {
|
|
int64_t v = static_cast<int64_t>(i) * static_cast<int64_t>(5003001);
|
|
Node** pos = cache.Find(v);
|
|
if (*pos != nullptr) {
|
|
EXPECT_EQ(nodes[i], *pos);
|
|
hits++;
|
|
}
|
|
}
|
|
EXPECT_LT(4, hits);
|
|
}
|
|
|
|
|
|
TEST_F(NodeCacheTest, GetCachedNodes_int32) {
|
|
Int32NodeCache cache(zone());
|
|
int32_t constants[] = {0, 311, 12, 13, 14, 555, -555, -44, -33, -22, -11,
|
|
0, 311, 311, 412, 412, 11, 11, -33, -33, -22, -11};
|
|
|
|
for (size_t i = 0; i < arraysize(constants); i++) {
|
|
int32_t k = constants[i];
|
|
Node** pos = cache.Find(k);
|
|
if (*pos != nullptr) {
|
|
ZoneVector<Node*> nodes(zone());
|
|
cache.GetCachedNodes(&nodes);
|
|
EXPECT_THAT(nodes, Contains(*pos));
|
|
} else {
|
|
ZoneVector<Node*> nodes(zone());
|
|
Node* n = graph()->NewNode(common()->Int32Constant(k));
|
|
*pos = n;
|
|
cache.GetCachedNodes(&nodes);
|
|
EXPECT_THAT(nodes, Contains(n));
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
TEST_F(NodeCacheTest, GetCachedNodes_int64) {
|
|
Int64NodeCache cache(zone());
|
|
int64_t constants[] = {0, 311, 12, 13, 14, 555, -555, -44, -33, -22, -11,
|
|
0, 311, 311, 412, 412, 11, 11, -33, -33, -22, -11};
|
|
|
|
for (size_t i = 0; i < arraysize(constants); i++) {
|
|
int64_t k = constants[i];
|
|
Node** pos = cache.Find(k);
|
|
if (*pos != nullptr) {
|
|
ZoneVector<Node*> nodes(zone());
|
|
cache.GetCachedNodes(&nodes);
|
|
EXPECT_THAT(nodes, Contains(*pos));
|
|
} else {
|
|
ZoneVector<Node*> nodes(zone());
|
|
Node* n = graph()->NewNode(common()->Int64Constant(k));
|
|
*pos = n;
|
|
cache.GetCachedNodes(&nodes);
|
|
EXPECT_THAT(nodes, Contains(n));
|
|
}
|
|
}
|
|
}
|
|
|
|
} // namespace node_cache_unittest
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|