cbc352983e
This removes two default switch cases for unsupported opcodes, and replaces them by explicit lists. This makes it easy to see what is currently not supported in Liftoff. In a follow-up CL, each bailout will be associated with a category to track which features currently cause Liftoff to bailout. This change also makes Liftoff crash (in UNREACHABLE) if invoked with asm.js code. Hence, change the asm.js tests to not test Liftoff. In production, we do not invoke Liftoff for asm.js anyway. R=mstarzinger@chromium.org Change-Id: I971c6146ed325103d14008c0e67a973a47a35bc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1634909 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61911}
247 lines
7.8 KiB
C++
247 lines
7.8 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <stdint.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include "src/base/platform/elapsed-timer.h"
|
|
#include "src/codegen/assembler-inl.h"
|
|
|
|
#include "test/cctest/cctest.h"
|
|
#include "test/cctest/compiler/value-helper.h"
|
|
#include "test/cctest/wasm/wasm-run-utils.h"
|
|
#include "test/common/wasm/test-signatures.h"
|
|
#include "test/common/wasm/wasm-macro-gen.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace wasm {
|
|
|
|
// Liftoff does not support asm.js, and is never invoked with asm.js code in
|
|
// production. Hence test asm.js with TurboFan and Interpreter only.
|
|
#define ASMJS_EXEC_TEST(name) \
|
|
void RunWasm_##name(ExecutionTier execution_tier); \
|
|
TEST(RunWasmTurbofan_##name) { RunWasm_##name(ExecutionTier::kTurbofan); } \
|
|
TEST(RunWasmInterpreter_##name) { \
|
|
RunWasm_##name(ExecutionTier::kInterpreter); \
|
|
} \
|
|
void RunWasm_##name(ExecutionTier execution_tier)
|
|
|
|
ASMJS_EXEC_TEST(Int32AsmjsDivS) {
|
|
WasmRunner<int32_t, int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsDivS, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
|
|
const int32_t kMin = std::numeric_limits<int32_t>::min();
|
|
CHECK_EQ(0, r.Call(0, 100));
|
|
CHECK_EQ(0, r.Call(100, 0));
|
|
CHECK_EQ(0, r.Call(-1001, 0));
|
|
CHECK_EQ(kMin, r.Call(kMin, -1));
|
|
CHECK_EQ(0, r.Call(kMin, 0));
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(Int32AsmjsRemS) {
|
|
WasmRunner<int32_t, int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsRemS, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
|
|
const int32_t kMin = std::numeric_limits<int32_t>::min();
|
|
CHECK_EQ(33, r.Call(133, 100));
|
|
CHECK_EQ(0, r.Call(kMin, -1));
|
|
CHECK_EQ(0, r.Call(100, 0));
|
|
CHECK_EQ(0, r.Call(-1001, 0));
|
|
CHECK_EQ(0, r.Call(kMin, 0));
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(Int32AsmjsDivU) {
|
|
WasmRunner<int32_t, int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsDivU, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
|
|
const int32_t kMin = std::numeric_limits<int32_t>::min();
|
|
CHECK_EQ(0, r.Call(0, 100));
|
|
CHECK_EQ(0, r.Call(kMin, -1));
|
|
CHECK_EQ(0, r.Call(100, 0));
|
|
CHECK_EQ(0, r.Call(-1001, 0));
|
|
CHECK_EQ(0, r.Call(kMin, 0));
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(Int32AsmjsRemU) {
|
|
WasmRunner<int32_t, int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsRemU, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
|
|
const int32_t kMin = std::numeric_limits<int32_t>::min();
|
|
CHECK_EQ(17, r.Call(217, 100));
|
|
CHECK_EQ(0, r.Call(100, 0));
|
|
CHECK_EQ(0, r.Call(-1001, 0));
|
|
CHECK_EQ(0, r.Call(kMin, 0));
|
|
CHECK_EQ(kMin, r.Call(kMin, -1));
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(I32AsmjsSConvertF32) {
|
|
WasmRunner<int32_t, float> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsSConvertF32, WASM_GET_LOCAL(0)));
|
|
|
|
FOR_FLOAT32_INPUTS(i) {
|
|
int32_t expected = DoubleToInt32(i);
|
|
CHECK_EQ(expected, r.Call(i));
|
|
}
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(I32AsmjsSConvertF64) {
|
|
WasmRunner<int32_t, double> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsSConvertF64, WASM_GET_LOCAL(0)));
|
|
|
|
FOR_FLOAT64_INPUTS(i) {
|
|
int32_t expected = DoubleToInt32(i);
|
|
CHECK_EQ(expected, r.Call(i));
|
|
}
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(I32AsmjsUConvertF32) {
|
|
WasmRunner<uint32_t, float> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsUConvertF32, WASM_GET_LOCAL(0)));
|
|
|
|
FOR_FLOAT32_INPUTS(i) {
|
|
uint32_t expected = DoubleToUint32(i);
|
|
CHECK_EQ(expected, r.Call(i));
|
|
}
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(I32AsmjsUConvertF64) {
|
|
WasmRunner<uint32_t, double> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsUConvertF64, WASM_GET_LOCAL(0)));
|
|
|
|
FOR_FLOAT64_INPUTS(i) {
|
|
uint32_t expected = DoubleToUint32(i);
|
|
CHECK_EQ(expected, r.Call(i));
|
|
}
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(LoadMemI32_oob_asm) {
|
|
WasmRunner<int32_t, uint32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
int32_t* memory = r.builder().AddMemoryElems<int32_t>(8);
|
|
r.builder().RandomizeMemory(1112);
|
|
|
|
BUILD(r, WASM_UNOP(kExprI32AsmjsLoadMem, WASM_GET_LOCAL(0)));
|
|
|
|
memory[0] = 999999;
|
|
CHECK_EQ(999999, r.Call(0u));
|
|
// TODO(titzer): offset 29-31 should also be OOB.
|
|
for (uint32_t offset = 32; offset < 40; offset++) {
|
|
CHECK_EQ(0, r.Call(offset));
|
|
}
|
|
|
|
for (uint32_t offset = 0x80000000; offset < 0x80000010; offset++) {
|
|
CHECK_EQ(0, r.Call(offset));
|
|
}
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(LoadMemF32_oob_asm) {
|
|
WasmRunner<float, uint32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
float* memory = r.builder().AddMemoryElems<float>(8);
|
|
r.builder().RandomizeMemory(1112);
|
|
|
|
BUILD(r, WASM_UNOP(kExprF32AsmjsLoadMem, WASM_GET_LOCAL(0)));
|
|
|
|
memory[0] = 9999.5f;
|
|
CHECK_EQ(9999.5f, r.Call(0u));
|
|
// TODO(titzer): offset 29-31 should also be OOB.
|
|
for (uint32_t offset = 32; offset < 40; offset++) {
|
|
CHECK(std::isnan(r.Call(offset)));
|
|
}
|
|
|
|
for (uint32_t offset = 0x80000000; offset < 0x80000010; offset++) {
|
|
CHECK(std::isnan(r.Call(offset)));
|
|
}
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(LoadMemF64_oob_asm) {
|
|
WasmRunner<double, uint32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
double* memory = r.builder().AddMemoryElems<double>(8);
|
|
r.builder().RandomizeMemory(1112);
|
|
|
|
BUILD(r, WASM_UNOP(kExprF64AsmjsLoadMem, WASM_GET_LOCAL(0)));
|
|
|
|
memory[0] = 9799.5;
|
|
CHECK_EQ(9799.5, r.Call(0u));
|
|
memory[1] = 11799.25;
|
|
CHECK_EQ(11799.25, r.Call(8u));
|
|
// TODO(titzer): offset 57-63 should also be OOB.
|
|
for (uint32_t offset = 64; offset < 80; offset++) {
|
|
CHECK(std::isnan(r.Call(offset)));
|
|
}
|
|
|
|
for (uint32_t offset = 0x80000000; offset < 0x80000010; offset++) {
|
|
CHECK(std::isnan(r.Call(offset)));
|
|
}
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(StoreMemI32_oob_asm) {
|
|
WasmRunner<int32_t, uint32_t, uint32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
int32_t* memory = r.builder().AddMemoryElems<int32_t>(8);
|
|
r.builder().RandomizeMemory(1112);
|
|
|
|
BUILD(r, WASM_BINOP(kExprI32AsmjsStoreMem, WASM_GET_LOCAL(0),
|
|
WASM_GET_LOCAL(1)));
|
|
|
|
memory[0] = 7777;
|
|
CHECK_EQ(999999, r.Call(0u, 999999));
|
|
CHECK_EQ(999999, memory[0]);
|
|
// TODO(titzer): offset 29-31 should also be OOB.
|
|
for (uint32_t offset = 32; offset < 40; offset++) {
|
|
CHECK_EQ(8888, r.Call(offset, 8888));
|
|
}
|
|
|
|
for (uint32_t offset = 0x10000000; offset < 0xF0000000; offset += 0x1000000) {
|
|
CHECK_EQ(7777, r.Call(offset, 7777));
|
|
}
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(Int32AsmjsDivS_byzero_const) {
|
|
for (int8_t denom = -2; denom < 8; ++denom) {
|
|
WasmRunner<int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_I32_ASMJS_DIVS(WASM_GET_LOCAL(0), WASM_I32V_1(denom)));
|
|
FOR_INT32_INPUTS(i) {
|
|
if (denom == 0) {
|
|
CHECK_EQ(0, r.Call(i));
|
|
} else if (denom == -1 && i == std::numeric_limits<int32_t>::min()) {
|
|
CHECK_EQ(std::numeric_limits<int32_t>::min(), r.Call(i));
|
|
} else {
|
|
CHECK_EQ(i / denom, r.Call(i));
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
ASMJS_EXEC_TEST(Int32AsmjsRemS_byzero_const) {
|
|
for (int8_t denom = -2; denom < 8; ++denom) {
|
|
WasmRunner<int32_t, int32_t> r(execution_tier);
|
|
r.builder().ChangeOriginToAsmjs();
|
|
BUILD(r, WASM_I32_ASMJS_REMS(WASM_GET_LOCAL(0), WASM_I32V_1(denom)));
|
|
FOR_INT32_INPUTS(i) {
|
|
if (denom == 0) {
|
|
CHECK_EQ(0, r.Call(i));
|
|
} else if (denom == -1 && i == std::numeric_limits<int32_t>::min()) {
|
|
CHECK_EQ(0, r.Call(i));
|
|
} else {
|
|
CHECK_EQ(i % denom, r.Call(i));
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
#undef ASMJS_EXEC_TEST
|
|
|
|
} // namespace wasm
|
|
} // namespace internal
|
|
} // namespace v8
|