3f47c63ded
Previously, when restarting a frame, we would rewrite all frames between the debugger activation and the frame to restart to squash them, and replace the return address with that of a builtin to leave that rewritten frame, and restart the function by calling it. We now simply remember the frame to drop to, and upon returning from the debugger, we check whether to drop the frame, load the new FP, and restart the function. R=jgruber@chromium.org, mstarzinger@chromium.org BUG=v8:5587 Review-Url: https://codereview.chromium.org/2636913002 Cr-Commit-Position: refs/heads/master@{#42725}
82 lines
1.9 KiB
JavaScript
82 lines
1.9 KiB
JavaScript
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
|
|
// Test that live-editing a frame to introduce new.target fails.
|
|
|
|
Debug = debug.Debug
|
|
var calls = 0;
|
|
var exceptions = 0;
|
|
var results = [];
|
|
var replace_again;
|
|
|
|
eval(`
|
|
function LogNewTarget() {
|
|
calls++;
|
|
ReplaceOnce();
|
|
results.push(true);
|
|
}
|
|
`);
|
|
|
|
function ExecuteInDebugContext(f) {
|
|
var result;
|
|
var exception = null;
|
|
Debug.setListener(function(event) {
|
|
if (event == Debug.DebugEvent.Break) {
|
|
try {
|
|
result = f();
|
|
} catch (e) {
|
|
// Rethrow this exception later.
|
|
exception = e;
|
|
}
|
|
}
|
|
});
|
|
debugger;
|
|
Debug.setListener(null);
|
|
if (exception !== null) throw exception;
|
|
return result;
|
|
}
|
|
|
|
function Replace(fun, original, patch) {
|
|
ExecuteInDebugContext(function() {
|
|
var change_log = [];
|
|
try {
|
|
var script = Debug.findScript(fun);
|
|
var patch_pos = script.source.indexOf(original);
|
|
Debug.LiveEdit.TestApi.ApplySingleChunkPatch(
|
|
script, patch_pos, original.length, patch, change_log);
|
|
} catch (e) {
|
|
assertEquals("BLOCKED_NO_NEW_TARGET_ON_RESTART",
|
|
change_log[0].functions_on_stack[0].replace_problem);
|
|
assertInstanceof(e, Debug.LiveEdit.Failure);
|
|
exceptions++;
|
|
}
|
|
});
|
|
}
|
|
|
|
function ReplaceOnce(x) {
|
|
if (replace_again) {
|
|
replace_again = false;
|
|
Replace(LogNewTarget, "true", "new.target");
|
|
}
|
|
}
|
|
|
|
function Revert() {
|
|
Replace(LogNewTarget, "new.target", "true");
|
|
}
|
|
|
|
replace_again = true;
|
|
ReplaceOnce();
|
|
new LogNewTarget();
|
|
Revert();
|
|
assertEquals(1, calls);
|
|
assertEquals(0, exceptions);
|
|
assertEquals([LogNewTarget], results);
|
|
|
|
replace_again = true;
|
|
new LogNewTarget();
|
|
assertEquals(2, calls); // No restarts
|
|
assertEquals(1, exceptions); // Replace failed.
|
|
assertEquals([LogNewTarget, true], results);
|