118c376fcb
This is basically the minimum viable signal handler for Wasm bounds checks. It includes the TLS check and the fine grained instructions checks. These two checks provide most of the safety for the signal handler. Future CLs will add code range and data range checks for more robustness. The trap handling code and data structures are all in src/trap-handler, with the code that actually runs in the signal handler confined to src/trap-handler/signal-handler.cc. This changes adds a new V8 API that the embedder should call from a signal handler that will give V8 the chance to handle the fault first. For hosts that do not want to implement their own signal handler, we include the option to install a simple one. This simple handler is also used for the tests. When a Wasm module is instantiated, information about each function is passed to the trap handler, which is used to classify faults. These are removed during the instance finalizer. Several future enhancements are planned before turning this on by default. Obviously, the additional checks will be added to MaybeHandleFault. We are also planning to add a two-level CodeObjectData table that is grouped by isolates to make cleanup easier and also reduce potential for contending on a single data structure. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5277 Review-Url: https://codereview.chromium.org/2371833007 Cr-Original-Original-Commit-Position: refs/heads/master@{#43523} Committed:a5af7fe9ee
Review-Url: https://codereview.chromium.org/2371833007 Cr-Original-Commit-Position: refs/heads/master@{#43755} Committed:338622d7ca
Review-Url: https://codereview.chromium.org/2371833007 Cr-Commit-Position: refs/heads/master@{#43759}
343 lines
11 KiB
C++
343 lines
11 KiB
C++
// Copyright 2008 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#include "include/v8.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
#include "include/libplatform/libplatform.h"
|
|
#include "src/debug/debug.h"
|
|
#include "src/objects-inl.h"
|
|
#include "src/trap-handler/trap-handler.h"
|
|
#include "test/cctest/print-extension.h"
|
|
#include "test/cctest/profiler-extension.h"
|
|
#include "test/cctest/trace-extension.h"
|
|
|
|
#if V8_OS_WIN
|
|
#include <windows.h> // NOLINT
|
|
#if V8_CC_MSVC
|
|
#include <crtdbg.h>
|
|
#endif
|
|
#endif
|
|
|
|
enum InitializationState {kUnset, kUnintialized, kInitialized};
|
|
static InitializationState initialization_state_ = kUnset;
|
|
static bool disable_automatic_dispose_ = false;
|
|
|
|
CcTest* CcTest::last_ = NULL;
|
|
bool CcTest::initialize_called_ = false;
|
|
v8::base::Atomic32 CcTest::isolate_used_ = 0;
|
|
v8::ArrayBuffer::Allocator* CcTest::allocator_ = NULL;
|
|
v8::Isolate* CcTest::isolate_ = NULL;
|
|
|
|
CcTest::CcTest(TestFunction* callback, const char* file, const char* name,
|
|
bool enabled, bool initialize)
|
|
: callback_(callback),
|
|
name_(name),
|
|
enabled_(enabled),
|
|
initialize_(initialize),
|
|
prev_(last_) {
|
|
// Find the base name of this test (const_cast required on Windows).
|
|
char *basename = strrchr(const_cast<char *>(file), '/');
|
|
if (!basename) {
|
|
basename = strrchr(const_cast<char *>(file), '\\');
|
|
}
|
|
if (!basename) {
|
|
basename = v8::internal::StrDup(file);
|
|
} else {
|
|
basename = v8::internal::StrDup(basename + 1);
|
|
}
|
|
// Drop the extension, if there is one.
|
|
char *extension = strrchr(basename, '.');
|
|
if (extension) *extension = 0;
|
|
// Install this test in the list of tests
|
|
file_ = basename;
|
|
prev_ = last_;
|
|
last_ = this;
|
|
}
|
|
|
|
|
|
void CcTest::Run() {
|
|
if (!initialize_) {
|
|
CHECK(initialization_state_ != kInitialized);
|
|
initialization_state_ = kUnintialized;
|
|
CHECK(CcTest::isolate_ == NULL);
|
|
} else {
|
|
CHECK(initialization_state_ != kUnintialized);
|
|
initialization_state_ = kInitialized;
|
|
if (isolate_ == NULL) {
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = allocator_;
|
|
isolate_ = v8::Isolate::New(create_params);
|
|
}
|
|
isolate_->Enter();
|
|
}
|
|
callback_();
|
|
if (initialize_) {
|
|
if (v8::Locker::IsActive()) {
|
|
v8::Locker locker(isolate_);
|
|
EmptyMessageQueues(isolate_);
|
|
} else {
|
|
EmptyMessageQueues(isolate_);
|
|
}
|
|
isolate_->Exit();
|
|
}
|
|
}
|
|
|
|
i::Heap* CcTest::heap() { return i_isolate()->heap(); }
|
|
|
|
void CcTest::CollectGarbage(i::AllocationSpace space) {
|
|
heap()->CollectGarbage(space, i::GarbageCollectionReason::kTesting);
|
|
}
|
|
|
|
void CcTest::CollectAllGarbage(int flags) {
|
|
heap()->CollectAllGarbage(flags, i::GarbageCollectionReason::kTesting);
|
|
}
|
|
|
|
void CcTest::CollectAllAvailableGarbage() {
|
|
heap()->CollectAllAvailableGarbage(i::GarbageCollectionReason::kTesting);
|
|
}
|
|
|
|
v8::base::RandomNumberGenerator* CcTest::random_number_generator() {
|
|
return InitIsolateOnce()->random_number_generator();
|
|
}
|
|
|
|
v8::Local<v8::Object> CcTest::global() {
|
|
return isolate()->GetCurrentContext()->Global();
|
|
}
|
|
|
|
void CcTest::InitializeVM() {
|
|
CHECK(!v8::base::NoBarrier_Load(&isolate_used_));
|
|
CHECK(!initialize_called_);
|
|
initialize_called_ = true;
|
|
v8::HandleScope handle_scope(CcTest::isolate());
|
|
v8::Context::New(CcTest::isolate())->Enter();
|
|
}
|
|
|
|
void CcTest::TearDown() {
|
|
if (isolate_ != NULL) isolate_->Dispose();
|
|
}
|
|
|
|
v8::Local<v8::Context> CcTest::NewContext(CcTestExtensionFlags extensions,
|
|
v8::Isolate* isolate) {
|
|
const char* extension_names[kMaxExtensions];
|
|
int extension_count = 0;
|
|
#define CHECK_EXTENSION_FLAG(Name, Id) \
|
|
if (extensions.Contains(Name##_ID)) extension_names[extension_count++] = Id;
|
|
EXTENSION_LIST(CHECK_EXTENSION_FLAG)
|
|
#undef CHECK_EXTENSION_FLAG
|
|
v8::ExtensionConfiguration config(extension_count, extension_names);
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate, &config);
|
|
CHECK(!context.IsEmpty());
|
|
return context;
|
|
}
|
|
|
|
|
|
void CcTest::DisableAutomaticDispose() {
|
|
CHECK_EQ(kUnintialized, initialization_state_);
|
|
disable_automatic_dispose_ = true;
|
|
}
|
|
|
|
LocalContext::~LocalContext() {
|
|
v8::HandleScope scope(isolate_);
|
|
v8::Local<v8::Context>::New(isolate_, context_)->Exit();
|
|
context_.Reset();
|
|
}
|
|
|
|
void LocalContext::Initialize(v8::Isolate* isolate,
|
|
v8::ExtensionConfiguration* extensions,
|
|
v8::Local<v8::ObjectTemplate> global_template,
|
|
v8::Local<v8::Value> global_object) {
|
|
v8::HandleScope scope(isolate);
|
|
v8::Local<v8::Context> context =
|
|
v8::Context::New(isolate, extensions, global_template, global_object);
|
|
context_.Reset(isolate, context);
|
|
context->Enter();
|
|
// We can't do this later perhaps because of a fatal error.
|
|
isolate_ = isolate;
|
|
}
|
|
|
|
// This indirection is needed because HandleScopes cannot be heap-allocated, and
|
|
// we don't want any unnecessary #includes in cctest.h.
|
|
class InitializedHandleScopeImpl {
|
|
public:
|
|
explicit InitializedHandleScopeImpl(i::Isolate* isolate)
|
|
: handle_scope_(isolate) {}
|
|
|
|
private:
|
|
i::HandleScope handle_scope_;
|
|
};
|
|
|
|
InitializedHandleScope::InitializedHandleScope()
|
|
: main_isolate_(CcTest::InitIsolateOnce()),
|
|
initialized_handle_scope_impl_(
|
|
new InitializedHandleScopeImpl(main_isolate_)) {}
|
|
|
|
InitializedHandleScope::~InitializedHandleScope() {}
|
|
|
|
HandleAndZoneScope::HandleAndZoneScope()
|
|
: main_zone_(new i::Zone(&allocator_, ZONE_NAME)) {}
|
|
|
|
HandleAndZoneScope::~HandleAndZoneScope() {}
|
|
|
|
static void PrintTestList(CcTest* current) {
|
|
if (current == NULL) return;
|
|
PrintTestList(current->prev());
|
|
printf("%s/%s\n", current->file(), current->name());
|
|
}
|
|
|
|
|
|
class CcTestArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
|
|
virtual void* Allocate(size_t length) {
|
|
void* data = AllocateUninitialized(length == 0 ? 1 : length);
|
|
return data == NULL ? data : memset(data, 0, length);
|
|
}
|
|
virtual void* AllocateUninitialized(size_t length) {
|
|
return malloc(length == 0 ? 1 : length);
|
|
}
|
|
virtual void Free(void* data, size_t length) { free(data); }
|
|
// TODO(dslomov): Remove when v8:2823 is fixed.
|
|
virtual void Free(void* data) { UNREACHABLE(); }
|
|
};
|
|
|
|
|
|
static void SuggestTestHarness(int tests) {
|
|
if (tests == 0) return;
|
|
printf("Running multiple tests in sequence is deprecated and may cause "
|
|
"bogus failure. Consider using tools/run-tests.py instead.\n");
|
|
}
|
|
|
|
|
|
int main(int argc, char* argv[]) {
|
|
#if V8_OS_WIN
|
|
UINT new_flags =
|
|
SEM_FAILCRITICALERRORS | SEM_NOGPFAULTERRORBOX | SEM_NOOPENFILEERRORBOX;
|
|
UINT existing_flags = SetErrorMode(new_flags);
|
|
SetErrorMode(existing_flags | new_flags);
|
|
#if V8_CC_MSVC
|
|
_CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_DEBUG | _CRTDBG_MODE_FILE);
|
|
_CrtSetReportFile(_CRT_WARN, _CRTDBG_FILE_STDERR);
|
|
_CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_DEBUG | _CRTDBG_MODE_FILE);
|
|
_CrtSetReportFile(_CRT_ASSERT, _CRTDBG_FILE_STDERR);
|
|
_CrtSetReportMode(_CRT_ERROR, _CRTDBG_MODE_DEBUG | _CRTDBG_MODE_FILE);
|
|
_CrtSetReportFile(_CRT_ERROR, _CRTDBG_FILE_STDERR);
|
|
_set_error_mode(_OUT_TO_STDERR);
|
|
#endif // V8_CC_MSVC
|
|
#endif // V8_OS_WIN
|
|
|
|
// hack to print cctest specific flags
|
|
for (int i = 1; i < argc; i++) {
|
|
char* arg = argv[i];
|
|
if ((strcmp(arg, "--help") == 0) || (strcmp(arg, "-h") == 0)) {
|
|
printf("Usage: %s [--list] [[V8_FLAGS] CCTEST]\n", argv[0]);
|
|
printf("\n");
|
|
printf("Options:\n");
|
|
printf(" --list: list all cctests\n");
|
|
printf(" CCTEST: cctest identfier returned by --list\n");
|
|
printf(" D8_FLAGS: see d8 output below\n");
|
|
printf("\n\n");
|
|
}
|
|
}
|
|
|
|
v8::V8::InitializeICUDefaultLocation(argv[0]);
|
|
v8::Platform* platform = v8::platform::CreateDefaultPlatform();
|
|
v8::V8::InitializePlatform(platform);
|
|
v8::internal::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
|
|
v8::V8::Initialize();
|
|
v8::V8::InitializeExternalStartupData(argv[0]);
|
|
|
|
if (i::trap_handler::UseTrapHandler()) {
|
|
v8::V8::RegisterDefaultSignalHandler();
|
|
}
|
|
|
|
CcTestArrayBufferAllocator array_buffer_allocator;
|
|
CcTest::set_array_buffer_allocator(&array_buffer_allocator);
|
|
|
|
i::PrintExtension print_extension;
|
|
v8::RegisterExtension(&print_extension);
|
|
i::ProfilerExtension profiler_extension;
|
|
v8::RegisterExtension(&profiler_extension);
|
|
i::TraceExtension trace_extension;
|
|
v8::RegisterExtension(&trace_extension);
|
|
|
|
int tests_run = 0;
|
|
bool print_run_count = true;
|
|
for (int i = 1; i < argc; i++) {
|
|
char* arg = argv[i];
|
|
if (strcmp(arg, "--list") == 0) {
|
|
PrintTestList(CcTest::last());
|
|
print_run_count = false;
|
|
|
|
} else {
|
|
char* arg_copy = v8::internal::StrDup(arg);
|
|
char* testname = strchr(arg_copy, '/');
|
|
if (testname) {
|
|
// Split the string in two by nulling the slash and then run
|
|
// exact matches.
|
|
*testname = 0;
|
|
char* file = arg_copy;
|
|
char* name = testname + 1;
|
|
CcTest* test = CcTest::last();
|
|
while (test != NULL) {
|
|
if (test->enabled()
|
|
&& strcmp(test->file(), file) == 0
|
|
&& strcmp(test->name(), name) == 0) {
|
|
SuggestTestHarness(tests_run++);
|
|
test->Run();
|
|
}
|
|
test = test->prev();
|
|
}
|
|
|
|
} else {
|
|
// Run all tests with the specified file or test name.
|
|
char* file_or_name = arg_copy;
|
|
CcTest* test = CcTest::last();
|
|
while (test != NULL) {
|
|
if (test->enabled()
|
|
&& (strcmp(test->file(), file_or_name) == 0
|
|
|| strcmp(test->name(), file_or_name) == 0)) {
|
|
SuggestTestHarness(tests_run++);
|
|
test->Run();
|
|
}
|
|
test = test->prev();
|
|
}
|
|
}
|
|
v8::internal::DeleteArray<char>(arg_copy);
|
|
}
|
|
}
|
|
if (print_run_count && tests_run != 1)
|
|
printf("Ran %i tests.\n", tests_run);
|
|
CcTest::TearDown();
|
|
// TODO(svenpanne) See comment above.
|
|
// if (!disable_automatic_dispose_) v8::V8::Dispose();
|
|
v8::V8::ShutdownPlatform();
|
|
delete platform;
|
|
return 0;
|
|
}
|
|
|
|
RegisterThreadedTest *RegisterThreadedTest::first_ = NULL;
|
|
int RegisterThreadedTest::count_ = 0;
|