v8/test/inspector/regress
Benedikt Meurer b141fedfed [inspector] Improve class name inference.
Previously having a `Symbol.toStringTag` property holding a string
somewhere in the prototype chain would always take predence over trying
to determine a reasonable name from the "constructor" (in case of
subclassing). This would lead to confusing behavior when diagnosing
objects in DevTools, for example

```js
class A extends URLSearchParams {};
new A()
```

would show `URLSearchParam` as class name for the instance rather than
`A`.

With this CL, we change the lookup logic to explicitly check for
`Symbol.toStringTag` and "constructor" along each step of the prototype
chain (skipping the "constructor" for the leaf object) and pick the
first one that yields a string (that is the function debug name in case
of "constructor").

Fixed: chromium:980018
Change-Id: Ic920b4bae02f965bc383c711f8de89c0de55fcac
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231078
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77453}
2021-10-19 11:40:06 +00:00
..
regress-crbug-980018-expected.txt [inspector] Improve class name inference. 2021-10-19 11:40:06 +00:00
regress-crbug-980018.js [inspector] Improve class name inference. 2021-10-19 11:40:06 +00:00
regress-crbug-1080638-expected.txt
regress-crbug-1080638.js
regress-crbug-1081162-expected.txt [inspector] Derive breakpoint hint based on resolved location. 2021-05-19 14:46:57 +00:00
regress-crbug-1081162.js [inspector] Derive breakpoint hint based on resolved location. 2021-05-19 14:46:57 +00:00
regress-crbug-1147552-expected.txt
regress-crbug-1147552.js
regress-crbug-1183664-expected.txt [inspector] Properly filter by column number for inline scripts. 2021-03-11 08:52:25 +00:00
regress-crbug-1183664.js [inspector] Properly filter by column number for inline scripts. 2021-03-11 08:52:25 +00:00
regress-crbug-1195927-expected.txt [debug] Disallow LiveEdit of active frames. 2021-04-28 13:00:19 +00:00
regress-crbug-1195927.js [debug] Disallow LiveEdit of active frames. 2021-04-28 13:00:19 +00:00
regress-crbug-1197392-expected.txt [inspector] Validate samplingInterval in HeapProfiler.startSampling 2021-05-12 12:11:31 +00:00
regress-crbug-1197392.js [inspector] Validate samplingInterval in HeapProfiler.startSampling 2021-05-12 12:11:31 +00:00
regress-crbug-1199919-expected.txt [debugger] Don't attach source positions to implicit returns. 2021-04-30 12:33:29 +00:00
regress-crbug-1199919.js [debugger] Don't attach source positions to implicit returns. 2021-04-30 12:33:29 +00:00
regress-crbug-1207867-expected.txt [inspector] Side-effect free FunctionMirror descriptions. 2021-05-12 09:30:37 +00:00
regress-crbug-1207867.js [inspector] Side-effect free FunctionMirror descriptions. 2021-05-12 09:30:37 +00:00
regress-crbug-1222065-expected.txt [debug] Default to last break index. 2021-06-22 05:06:31 +00:00
regress-crbug-1222065.js [debug] Default to last break index. 2021-06-22 05:06:31 +00:00
regress-crbug-1233401-expected.txt Fix test expectation for new inspector test 2021-07-28 17:26:16 +00:00
regress-crbug-1233401.js [debug] correctly tier down function for side effect check mode 2021-07-28 15:03:26 +00:00
regress-crbug-1253277-expected.txt [debug] Set breakpoints correctly right after function literals. 2021-10-01 10:11:45 +00:00
regress-crbug-1253277.js [debug] Set breakpoints correctly right after function literals. 2021-10-01 10:11:45 +00:00