b141fedfed
Previously having a `Symbol.toStringTag` property holding a string somewhere in the prototype chain would always take predence over trying to determine a reasonable name from the "constructor" (in case of subclassing). This would lead to confusing behavior when diagnosing objects in DevTools, for example ```js class A extends URLSearchParams {}; new A() ``` would show `URLSearchParam` as class name for the instance rather than `A`. With this CL, we change the lookup logic to explicitly check for `Symbol.toStringTag` and "constructor" along each step of the prototype chain (skipping the "constructor" for the leaf object) and pick the first one that yields a string (that is the function debug name in case of "constructor"). Fixed: chromium:980018 Change-Id: Ic920b4bae02f965bc383c711f8de89c0de55fcac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231078 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#77453} |
||
---|---|---|
.. | ||
regress-crbug-980018-expected.txt | ||
regress-crbug-980018.js | ||
regress-crbug-1080638-expected.txt | ||
regress-crbug-1080638.js | ||
regress-crbug-1081162-expected.txt | ||
regress-crbug-1081162.js | ||
regress-crbug-1147552-expected.txt | ||
regress-crbug-1147552.js | ||
regress-crbug-1183664-expected.txt | ||
regress-crbug-1183664.js | ||
regress-crbug-1195927-expected.txt | ||
regress-crbug-1195927.js | ||
regress-crbug-1197392-expected.txt | ||
regress-crbug-1197392.js | ||
regress-crbug-1199919-expected.txt | ||
regress-crbug-1199919.js | ||
regress-crbug-1207867-expected.txt | ||
regress-crbug-1207867.js | ||
regress-crbug-1222065-expected.txt | ||
regress-crbug-1222065.js | ||
regress-crbug-1233401-expected.txt | ||
regress-crbug-1233401.js | ||
regress-crbug-1253277-expected.txt | ||
regress-crbug-1253277.js |