v8/test/unittests/compiler
Clemens Hammacher bf92fbf4c8 Revert "[arraybuffer] Rearchitect backing store ownership"
This reverts commit 31cd5d83d3.

Reason for revert: It breaks my heart to revert this, but it fails differently on several bots, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/26671.

Original change's description:
> [arraybuffer] Rearchitect backing store ownership
> 
> This CL completely rearchitects the ownership of array buffer backing stores,
> consolidating ownership into a {BackingStore} C++ object that is tracked
> throughout V8 using unique_ptr and shared_ptr where appropriate.
> 
> Overall, lifetime management is simpler and more explicit. The numerous
> ways that array buffers were initialized have been streamlined to one
> Attach() method on JSArrayBuffer. The array buffer tracker in the
> GC implementation now manages std::shared_ptr<BackingStore> pointers,
> and the construction and destruction of the BackingStore object itself
> handles the underlying page or embedder-allocated memory.
> 
> The embedder API remains unchanged for now. We use the
> v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to
> keep the backing store alive properly, even in the case of aliases
> from live heap objects. Thus the embedder has a lower chance of making
> a mistake. Long-term, we should move the embedder to a model where they
> manage backing stores using shared_ptr to an opaque backing store object.
> 
> R=​mlippautz@chromium.org
> BUG=v8:9380,v8:9221
> 
> Change-Id: I48fae5ac85dcf6172a83f252439e77e7c1a16ccd
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584323
> Commit-Queue: Ben Titzer <titzer@chromium.org>
> Reviewed-by: Ben Titzer <titzer@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#62572}

TBR=ulan@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,titzer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org

Change-Id: Ib35788ba8c31192d90cbc72df3dbc41030f109de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:9380, v8:9221
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691034
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62578}
2019-07-08 17:20:51 +00:00
..
arm [cleanup] Replace function typedefs by using declarations 2019-05-28 08:35:08 +00:00
arm64 Enable cpplint 'runtime/references' warning 2019-07-08 09:59:36 +00:00
backend [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
ia32 [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
mips Move architecture dependent files 2019-05-28 14:02:15 +00:00
mips64 Move architecture dependent files 2019-05-28 14:02:15 +00:00
ppc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
regalloc [regalloc] Rename --trace-alloc to --trace-turbo-alloc 2019-07-05 12:47:41 +00:00
s390 Move architecture dependent files 2019-05-28 14:02:15 +00:00
x64 [cleanup] Replace function typedefs by using declarations 2019-05-28 08:35:08 +00:00
branch-elimination-unittest.cc Revert "[TurboFan] Diagnostic code to track down bug in representation selection" 2017-11-14 09:26:51 +00:00
bytecode-analysis-unittest.cc Move remaining files in src/ 2019-05-24 18:24:36 +00:00
checkpoint-elimination-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
code-assembler-unittest.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
code-assembler-unittest.h [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
common-operator-reducer-unittest.cc [turbofan] Disentangle header include chains 2019-07-05 14:26:05 +00:00
common-operator-unittest.cc test: Replace _TEST_CASE_ with _TEST_SUITE_. 2019-02-18 21:36:56 +00:00
compiler-test-utils.h [turbofan] Drop V8_TURBOFAN_BACKEND and V8_TURBOFAN_TARGET defines. 2015-08-10 07:17:34 +00:00
constant-folding-reducer-unittest.cc [turbofan] Disentangle header include chains 2019-07-05 14:26:05 +00:00
control-equivalence-unittest.cc Move utility code to src/utils 2019-05-23 14:13:34 +00:00
control-flow-optimizer-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
dead-code-elimination-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
decompression-elimination-unittest.cc [cleanup][ptr-compr][turbofan] DecompressionElimination test cleanup 2019-06-24 21:35:06 +00:00
diamond-unittest.cc [cleanup] [compiler] Fix (D)CHECK macros 2017-09-25 10:21:34 +00:00
effect-control-linearizer-unittest.cc [ptr-compr][cleanup] Removing the optimized map checks 2019-05-28 09:39:23 +00:00
graph-reducer-unittest.cc [cleanup] Replace 0 and NULL with nullptr for compiler files. 2018-09-14 16:20:29 +00:00
graph-reducer-unittest.h [turbofan] Add AdvancedReducer::ReplaceWithValue() method and convert JSInlining to an AdvancedReducer. 2015-05-12 12:41:36 +00:00
graph-trimmer-unittest.cc [turbofan] Proper dead code elimination as regular reducer. 2015-06-19 12:07:26 +00:00
graph-unittest.cc [turbofan] Disentangle header include chains 2019-07-05 14:26:05 +00:00
graph-unittest.h [turbofan] Disentangle header include chains 2019-07-05 14:26:05 +00:00
int64-lowering-unittest.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
js-call-reducer-unittest.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
js-create-lowering-unittest.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
js-intrinsic-lowering-unittest.cc [cleanup] Remove unused IsTypedArray runtime function 2019-05-21 07:25:39 +00:00
js-native-context-specialization-unittest.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
js-operator-unittest.cc test: Replace _TEST_CASE_ with _TEST_SUITE_. 2019-02-18 21:36:56 +00:00
js-typed-lowering-unittest.cc Revert "[arraybuffer] Rearchitect backing store ownership" 2019-07-08 17:20:51 +00:00
linkage-tail-call-unittest.cc Reland "[arm64] Preparation for padding of arguments" 2017-12-20 13:50:36 +00:00
load-elimination-unittest.cc Retire PretenureFlag and use AllocationType everywhere. 2019-03-12 08:10:44 +00:00
loop-peeling-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
machine-operator-reducer-unittest.cc [turbofan] Reduce consecutive machine additions with constants 2019-05-24 08:45:59 +00:00
machine-operator-unittest.cc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
node-cache-unittest.cc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
node-matchers-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
node-properties-unittest.cc [jumbo] add unittests jumbo support 2017-09-28 22:19:40 +00:00
node-test-utils.cc Reland "[csa] Tweak CSA pipeline to eliminate more redundant checks" 2019-06-17 09:40:29 +00:00
node-test-utils.h Reland "[csa] Tweak CSA pipeline to eliminate more redundant checks" 2019-06-17 09:40:29 +00:00
node-unittest.cc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
opcodes-unittest.cc [ubsan][compiler] Avoid out-of-range casts to IrOpcode::Value 2019-01-25 20:55:25 +00:00
persistent-unittest.cc [ubsan] Fix numerical overflows in the compiler 2019-01-10 11:17:37 +00:00
redundancy-elimination-unittest.cc Revert recent ConsString-related changes 2019-04-18 12:24:53 +00:00
schedule-unittest.cc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
scheduler-rpo-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
scheduler-unittest.cc Reland "Introduce StdoutStream which prints to Android log or stdout" 2018-06-14 13:29:01 +00:00
simplified-lowering-unittest.cc [turbofan] Rename "js_heap_broker" to "broker". 2018-10-15 08:17:17 +00:00
simplified-operator-reducer-unittest.cc [turbofan] Disentangle header include chains 2019-07-05 14:26:05 +00:00
simplified-operator-unittest.cc [ptr-compr] Specialize CompressedSigned -> Word32 conversion 2019-07-08 12:21:58 +00:00
state-values-utils-unittest.cc Move utility code to src/utils 2019-05-23 14:13:34 +00:00
typed-optimization-unittest.cc Move relevant files to src/execution 2019-05-22 08:36:33 +00:00
typer-unittest.cc [turbofan] Disentangle header include chains 2019-07-05 14:26:05 +00:00
value-numbering-reducer-unittest.cc [jumbo] fix another set of unittest compilation errors 2017-10-19 09:15:44 +00:00
zone-stats-unittest.cc [cleanup] Don't use virtual inheritance in gtest fixtures 2018-10-30 06:28:42 +00:00