7eded3003a
This reverts commit ba735dde20.
Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21991
Original change's description:
> [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery.
>
> Bug: chromium:845409
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b
> Reviewed-on: https://chromium-review.googlesource.com/1160162
> Commit-Queue: Rodrigo Bruno <rfbpb@google.com>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55128}
TBR=ulan@chromium.org,mlippautz@chromium.org,rfbpb@google.com
Change-Id: Iaf65227c65c11effa11662ac7d7bd7736f4d7846
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:845409
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1174858
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55129}
121 lines
4.7 KiB
C++
121 lines
4.7 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <cmath>
|
|
#include <iostream>
|
|
#include <limits>
|
|
|
|
#include "src/objects-inl.h"
|
|
#include "src/objects.h"
|
|
|
|
#include "src/handles-inl.h"
|
|
#include "src/handles.h"
|
|
|
|
#include "src/heap/heap-controller.h"
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
typedef TestWithIsolate HeapControllerTest;
|
|
|
|
double Round(double x) {
|
|
// Round to three digits.
|
|
return floor(x * 1000 + 0.5) / 1000;
|
|
}
|
|
|
|
void CheckEqualRounded(double expected, double actual) {
|
|
expected = Round(expected);
|
|
actual = Round(actual);
|
|
EXPECT_DOUBLE_EQ(expected, actual);
|
|
}
|
|
|
|
TEST_F(HeapControllerTest, HeapGrowingFactor) {
|
|
HeapController heap_controller(i_isolate()->heap());
|
|
double min_factor = heap_controller.kMinGrowingFactor;
|
|
double max_factor = heap_controller.kMaxGrowingFactor;
|
|
|
|
CheckEqualRounded(max_factor, heap_controller.GrowingFactor(34, 1, 4.0));
|
|
CheckEqualRounded(3.553, heap_controller.GrowingFactor(45, 1, 4.0));
|
|
CheckEqualRounded(2.830, heap_controller.GrowingFactor(50, 1, 4.0));
|
|
CheckEqualRounded(1.478, heap_controller.GrowingFactor(100, 1, 4.0));
|
|
CheckEqualRounded(1.193, heap_controller.GrowingFactor(200, 1, 4.0));
|
|
CheckEqualRounded(1.121, heap_controller.GrowingFactor(300, 1, 4.0));
|
|
CheckEqualRounded(heap_controller.GrowingFactor(300, 1, 4.0),
|
|
heap_controller.GrowingFactor(600, 2, 4.0));
|
|
CheckEqualRounded(min_factor, heap_controller.GrowingFactor(400, 1, 4.0));
|
|
}
|
|
|
|
TEST_F(HeapControllerTest, MaxHeapGrowingFactor) {
|
|
HeapController heap_controller(i_isolate()->heap());
|
|
CheckEqualRounded(
|
|
1.3, heap_controller.MaxGrowingFactor(heap_controller.kMinSize * MB));
|
|
CheckEqualRounded(1.600, heap_controller.MaxGrowingFactor(
|
|
heap_controller.kMaxSize / 2 * MB));
|
|
CheckEqualRounded(
|
|
1.999, heap_controller.MaxGrowingFactor(
|
|
(heap_controller.kMaxSize - Heap::kPointerMultiplier) * MB));
|
|
CheckEqualRounded(4.0,
|
|
heap_controller.MaxGrowingFactor(
|
|
static_cast<size_t>(heap_controller.kMaxSize) * MB));
|
|
}
|
|
|
|
TEST_F(HeapControllerTest, OldGenerationAllocationLimit) {
|
|
Heap* heap = i_isolate()->heap();
|
|
HeapController heap_controller(heap);
|
|
size_t old_gen_size = 128 * MB;
|
|
size_t max_old_generation_size = 512 * MB;
|
|
double gc_speed = 100;
|
|
double mutator_speed = 1;
|
|
size_t new_space_capacity = 16 * MB;
|
|
|
|
double max_factor = heap_controller.MaxGrowingFactor(max_old_generation_size);
|
|
double factor =
|
|
heap_controller.GrowingFactor(gc_speed, mutator_speed, max_factor);
|
|
|
|
EXPECT_EQ(static_cast<size_t>(old_gen_size * factor + new_space_capacity),
|
|
heap->heap_controller()->CalculateAllocationLimit(
|
|
old_gen_size, max_old_generation_size, gc_speed, mutator_speed,
|
|
new_space_capacity, Heap::HeapGrowingMode::kDefault));
|
|
|
|
factor = Min(factor, heap_controller.kConservativeGrowingFactor);
|
|
EXPECT_EQ(static_cast<size_t>(old_gen_size * factor + new_space_capacity),
|
|
heap->heap_controller()->CalculateAllocationLimit(
|
|
old_gen_size, max_old_generation_size, gc_speed, mutator_speed,
|
|
new_space_capacity, Heap::HeapGrowingMode::kSlow));
|
|
|
|
factor = Min(factor, heap_controller.kConservativeGrowingFactor);
|
|
EXPECT_EQ(static_cast<size_t>(old_gen_size * factor + new_space_capacity),
|
|
heap->heap_controller()->CalculateAllocationLimit(
|
|
old_gen_size, max_old_generation_size, gc_speed, mutator_speed,
|
|
new_space_capacity, Heap::HeapGrowingMode::kConservative));
|
|
|
|
factor = heap_controller.kMinGrowingFactor;
|
|
EXPECT_EQ(static_cast<size_t>(old_gen_size * factor + new_space_capacity),
|
|
heap->heap_controller()->CalculateAllocationLimit(
|
|
old_gen_size, max_old_generation_size, gc_speed, mutator_speed,
|
|
new_space_capacity, Heap::HeapGrowingMode::kMinimal));
|
|
}
|
|
|
|
TEST_F(HeapControllerTest, MaxOldGenerationSize) {
|
|
HeapController heap_controller(i_isolate()->heap());
|
|
uint64_t configurations[][2] = {
|
|
{0, heap_controller.kMinSize},
|
|
{512, heap_controller.kMinSize},
|
|
{1 * GB, 256 * Heap::kPointerMultiplier},
|
|
{2 * static_cast<uint64_t>(GB), 512 * Heap::kPointerMultiplier},
|
|
{4 * static_cast<uint64_t>(GB), heap_controller.kMaxSize},
|
|
{8 * static_cast<uint64_t>(GB), heap_controller.kMaxSize}};
|
|
|
|
for (auto configuration : configurations) {
|
|
ASSERT_EQ(configuration[1],
|
|
static_cast<uint64_t>(
|
|
Heap::ComputeMaxOldGenerationSize(configuration[0])));
|
|
}
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|