93fc3841c3
Instead of using runtime calls to generate the Array Literal passed to %reflect_call / %reflect_construct, we create an ArrayLiteral from the list of arguments, and perform spreads using the interpreter mechanism for spreading in ArrayLiterals (thus, the spreading becomes inline). This array literal is still passed to %reflect_call / %reflect_construct as before. This cuts the runtime for bench-spread-call.js -> testSpread roughly in half, and will likely improve further once https://chromium-review.googlesource.com/c/v8/v8/+/915364 has landed. BUG=v8:7446 R=neis@chromium.org, adamk@chromium.org Change-Id: I74a6acd3a60aad422e4ac575275c7b567659d8ad Reviewed-on: https://chromium-review.googlesource.com/939587 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51678}
123 lines
3.5 KiB
Plaintext
123 lines
3.5 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
Math.max(...[1, 2, 3]);
|
|
"
|
|
frame size: 3
|
|
parameter count: 1
|
|
bytecode array length: 25
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 34 S> */ B(LdaGlobal), U8(0), U8(0),
|
|
B(Star), R(1),
|
|
/* 39 E> */ B(LdaNamedProperty), R(1), U8(1), U8(2),
|
|
B(Star), R(0),
|
|
B(CreateArrayLiteral), U8(2), U8(4), U8(37),
|
|
B(Star), R(2),
|
|
/* 39 E> */ B(CallWithSpread), R(0), R(1), U8(2), U8(5),
|
|
B(LdaUndefined),
|
|
/* 58 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["Math"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["max"],
|
|
TUPLE2_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
Math.max(0, ...[1, 2, 3]);
|
|
"
|
|
frame size: 4
|
|
parameter count: 1
|
|
bytecode array length: 28
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 34 S> */ B(LdaGlobal), U8(0), U8(0),
|
|
B(Star), R(1),
|
|
/* 39 E> */ B(LdaNamedProperty), R(1), U8(1), U8(2),
|
|
B(Star), R(0),
|
|
B(LdaZero),
|
|
B(Star), R(2),
|
|
B(CreateArrayLiteral), U8(2), U8(4), U8(37),
|
|
B(Star), R(3),
|
|
/* 39 E> */ B(CallWithSpread), R(0), R(1), U8(3), U8(5),
|
|
B(LdaUndefined),
|
|
/* 61 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["Math"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["max"],
|
|
TUPLE2_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
Math.max(0, ...[1, 2, 3], 4);
|
|
"
|
|
frame size: 11
|
|
parameter count: 1
|
|
bytecode array length: 109
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 34 S> */ B(LdaGlobal), U8(0), U8(0),
|
|
B(Star), R(0),
|
|
B(LdaNamedProperty), R(0), U8(1), U8(2),
|
|
B(Star), R(1),
|
|
B(CreateArrayLiteral), U8(2), U8(4), U8(37),
|
|
B(Star), R(4),
|
|
/* 49 S> */ B(CreateArrayLiteral), U8(3), U8(5), U8(37),
|
|
B(Star), R(9),
|
|
B(LdaNamedProperty), R(9), U8(4), U8(6),
|
|
B(Star), R(10),
|
|
B(CallProperty0), R(10), R(9), U8(8),
|
|
B(Mov), R(0), R(2),
|
|
B(Mov), R(4), R(5),
|
|
B(JumpIfJSReceiver), U8(7),
|
|
B(CallRuntime), U16(Runtime::kThrowSymbolIteratorInvalid), R(0), U8(0),
|
|
B(Star), R(8),
|
|
B(LdaNamedProperty), R(8), U8(5), U8(10),
|
|
B(Star), R(7),
|
|
B(CallProperty0), R(7), R(8), U8(12),
|
|
B(Star), R(6),
|
|
B(JumpIfJSReceiver), U8(7),
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(6), U8(1),
|
|
B(LdaNamedProperty), R(6), U8(6), U8(14),
|
|
B(JumpIfToBooleanTrue), U8(16),
|
|
B(LdaNamedProperty), R(6), U8(7), U8(16),
|
|
B(Star), R(6),
|
|
B(CallRuntime), U16(Runtime::kAppendElement), R(5), U8(2),
|
|
B(JumpLoop), U8(30), I8(0),
|
|
B(LdaSmi), I8(4),
|
|
B(Star), R(6),
|
|
B(Mov), R(4), R(5),
|
|
B(CallRuntime), U16(Runtime::kAppendElement), R(5), U8(2),
|
|
B(Mov), R(5), R(3),
|
|
B(CallJSRuntime), U8(%reflect_apply), R(1), U8(3),
|
|
B(LdaUndefined),
|
|
/* 64 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["Math"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["max"],
|
|
TUPLE2_TYPE,
|
|
TUPLE2_TYPE,
|
|
SYMBOL_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|