v8/test/unittests/compiler
Georg Schmid 94ae207bc7 [ptr-compr] Revisit transformed Phis in Decompression Elimination
Currently, decompression elimination may reduce phis by pushing decompressions in the value inputs of the phi "down" and replacing it by a single decompression following the phi node. Because of the way that the replacement is currently done, other reducers in the same phase will not generally get a chance to revisit the modified phi.

In the specific case of v8:9335 this blocked an additional optimization in CommonOperatorReducer from being applied, causing the overall load elimination test to fail.

This CL fixes the replacement behavior in decompression elimination to also allow for revisitations of the modified phi node.

Bug: v8:9335 v8:9336
Change-Id: I3ca5686dacb41a525160b08456905ba77cf28b39

Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng
Change-Id: I3ca5686dacb41a525160b08456905ba77cf28b39
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648238
Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Georg Schmid <gsps@google.com>
Cr-Commit-Position: refs/heads/master@{#62054}
2019-06-07 15:52:48 +00:00
..
arm [cleanup] Replace function typedefs by using declarations 2019-05-28 08:35:08 +00:00
arm64 [arm64][windows] Ensure 64-bit values in unittest 2019-06-04 16:30:12 +00:00
backend [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
ia32 [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
mips Move architecture dependent files 2019-05-28 14:02:15 +00:00
mips64 Move architecture dependent files 2019-05-28 14:02:15 +00:00
ppc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
regalloc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
s390 Move architecture dependent files 2019-05-28 14:02:15 +00:00
x64 [cleanup] Replace function typedefs by using declarations 2019-05-28 08:35:08 +00:00
branch-elimination-unittest.cc Revert "[TurboFan] Diagnostic code to track down bug in representation selection" 2017-11-14 09:26:51 +00:00
bytecode-analysis-unittest.cc Move remaining files in src/ 2019-05-24 18:24:36 +00:00
checkpoint-elimination-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
code-assembler-unittest.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
code-assembler-unittest.h [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
common-operator-reducer-unittest.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
common-operator-unittest.cc test: Replace _TEST_CASE_ with _TEST_SUITE_. 2019-02-18 21:36:56 +00:00
compiler-test-utils.h [turbofan] Drop V8_TURBOFAN_BACKEND and V8_TURBOFAN_TARGET defines. 2015-08-10 07:17:34 +00:00
constant-folding-reducer-unittest.cc Move relevant files to src/execution 2019-05-22 08:36:33 +00:00
control-equivalence-unittest.cc Move utility code to src/utils 2019-05-23 14:13:34 +00:00
control-flow-optimizer-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
dead-code-elimination-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
decompression-elimination-unittest.cc [ptr-compr] Revisit transformed Phis in Decompression Elimination 2019-06-07 15:52:48 +00:00
diamond-unittest.cc [cleanup] [compiler] Fix (D)CHECK macros 2017-09-25 10:21:34 +00:00
effect-control-linearizer-unittest.cc [ptr-compr][cleanup] Removing the optimized map checks 2019-05-28 09:39:23 +00:00
graph-reducer-unittest.cc [cleanup] Replace 0 and NULL with nullptr for compiler files. 2018-09-14 16:20:29 +00:00
graph-reducer-unittest.h [turbofan] Add AdvancedReducer::ReplaceWithValue() method and convert JSInlining to an AdvancedReducer. 2015-05-12 12:41:36 +00:00
graph-trimmer-unittest.cc [turbofan] Proper dead code elimination as regular reducer. 2015-06-19 12:07:26 +00:00
graph-unittest.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
graph-unittest.h Move handles-related files to src/handles 2019-05-23 06:00:15 +00:00
int64-lowering-unittest.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
js-call-reducer-unittest.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
js-create-lowering-unittest.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
js-intrinsic-lowering-unittest.cc [cleanup] Remove unused IsTypedArray runtime function 2019-05-21 07:25:39 +00:00
js-native-context-specialization-unittest.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
js-operator-unittest.cc test: Replace _TEST_CASE_ with _TEST_SUITE_. 2019-02-18 21:36:56 +00:00
js-typed-lowering-unittest.cc Move relevant files to src/execution 2019-05-22 08:36:33 +00:00
linkage-tail-call-unittest.cc Reland "[arm64] Preparation for padding of arguments" 2017-12-20 13:50:36 +00:00
load-elimination-unittest.cc Retire PretenureFlag and use AllocationType everywhere. 2019-03-12 08:10:44 +00:00
loop-peeling-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
machine-operator-reducer-unittest.cc [turbofan] Reduce consecutive machine additions with constants 2019-05-24 08:45:59 +00:00
machine-operator-unittest.cc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
node-cache-unittest.cc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
node-matchers-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
node-properties-unittest.cc [jumbo] add unittests jumbo support 2017-09-28 22:19:40 +00:00
node-test-utils.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
node-test-utils.h Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
node-unittest.cc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
opcodes-unittest.cc [ubsan][compiler] Avoid out-of-range casts to IrOpcode::Value 2019-01-25 20:55:25 +00:00
persistent-unittest.cc [ubsan] Fix numerical overflows in the compiler 2019-01-10 11:17:37 +00:00
redundancy-elimination-unittest.cc Revert recent ConsString-related changes 2019-04-18 12:24:53 +00:00
schedule-unittest.cc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
scheduler-rpo-unittest.cc [cleanup] Refactor compiler to use default members. 2018-09-17 12:12:21 +00:00
scheduler-unittest.cc Reland "Introduce StdoutStream which prints to Android log or stdout" 2018-06-14 13:29:01 +00:00
simplified-lowering-unittest.cc [turbofan] Rename "js_heap_broker" to "broker". 2018-10-15 08:17:17 +00:00
simplified-operator-reducer-unittest.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
simplified-operator-unittest.cc Reland "[typedarray] Move external/data pointer to JSTypedArray." 2019-05-27 17:44:06 +00:00
state-values-utils-unittest.cc Move utility code to src/utils 2019-05-23 14:13:34 +00:00
typed-optimization-unittest.cc Move relevant files to src/execution 2019-05-22 08:36:33 +00:00
typer-unittest.cc [cleanup] Replace simple typedefs by using 2019-05-27 12:39:49 +00:00
value-numbering-reducer-unittest.cc [jumbo] fix another set of unittest compilation errors 2017-10-19 09:15:44 +00:00
zone-stats-unittest.cc [cleanup] Don't use virtual inheritance in gtest fixtures 2018-10-30 06:28:42 +00:00