2257f6b145
- Remove flag --block-concurrent-recompilation and its implementation, including %UnblockConcurrentCompilation. - Rewrite tests that used it in terms of the primitives introduced in my previous CL: https://chromium-review.googlesource.com/c/v8/v8/+/3071400/ - Remove "sync"/"no sync" arguments from %GetOptimizationStatus, assertOptimized, etc. These are now always "no sync": they don't do any magic. - Remove "if %IsConcurrentRecompilationSupported then quit" from some tests in favor of --concurrent-recompilation in their Flags line. Bug: v8:12041, v8:7790 Change-Id: I966aae4fec85e6f9e7aeed2ba2c12e9198a3991f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3077149 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#76298}
74 lines
2.9 KiB
JavaScript
74 lines
2.9 KiB
JavaScript
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --allow-natives-syntax --concurrent-recompilation --no-always-opt
|
|
|
|
if (!%IsConcurrentRecompilationSupported()) {
|
|
print("Concurrent recompilation is disabled. Skipping this test.");
|
|
quit();
|
|
}
|
|
|
|
function new_object() {
|
|
var o = {};
|
|
o.a = 1;
|
|
o.b = 2;
|
|
return o;
|
|
}
|
|
|
|
function add_field(obj) {
|
|
// Assign twice to make the field non-constant.
|
|
obj.c = 0;
|
|
obj.c = 3;
|
|
}
|
|
%PrepareFunctionForOptimization(add_field);
|
|
var obj1 = new_object();
|
|
var obj2 = new_object();
|
|
add_field(obj1);
|
|
add_field(obj2);
|
|
%DisableOptimizationFinalization();
|
|
%OptimizeFunctionOnNextCall(add_field, "concurrent");
|
|
|
|
var o = new_object();
|
|
// Kick off recompilation.
|
|
add_field(o);
|
|
// Invalidate transition map after compile graph has been created.
|
|
%WaitForBackgroundOptimization();
|
|
o.c = 2.2;
|
|
assertUnoptimized(add_field);
|
|
// Sync with background thread to conclude optimization that bailed out.
|
|
%FinalizeOptimization();
|
|
if (!%IsDictPropertyConstTrackingEnabled()) {
|
|
// TODO(v8:11457) Currently, we cannot inline property stores if there is a
|
|
// dictionary mode prototype on the prototype chain. Therefore, if
|
|
// v8_dict_property_const_tracking is enabled, the optimized code only
|
|
// contains a call to the IC handler and doesn't get invalidated when the
|
|
// transition map changes.
|
|
assertUnoptimized(add_field);
|
|
}
|
|
// Clear type info for stress runs.
|
|
%ClearFunctionFeedback(add_field);
|