b38bf5b0b1
The current API returns a Handle<NativeContext> which can be optionally null and all the users of this API never actually checked for this null value. Previously, this wasn't a problem as all the possible JSObjects that were user visible would return a valid NativeContext but now there are wasm objects that don't have a valid constructor so don't have a NativeContext. Bug: v8:11451, chromium:1166077 Change-Id: I4fd5edf8f1a750e6f0abb931fd41358e5ae4dfcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692695 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#72769}
103 lines
3.7 KiB
C++
103 lines
3.7 KiB
C++
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
#include "include/v8.h"
|
|
#include "src/api/api-inl.h"
|
|
#include "src/handles/handles.h"
|
|
#include "src/objects/objects-inl.h"
|
|
#include "test/unittests/test-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace remote_object_unittest {
|
|
|
|
using RemoteObjectTest = TestWithIsolate;
|
|
|
|
namespace {
|
|
|
|
bool AccessCheck(Local<Context> accessing_context,
|
|
Local<Object> accessed_object, Local<Value> data) {
|
|
return false;
|
|
}
|
|
|
|
void NamedGetter(Local<Name> property,
|
|
const PropertyCallbackInfo<Value>& info) {}
|
|
|
|
void Constructor(const FunctionCallbackInfo<Value>& info) {
|
|
ASSERT_TRUE(info.IsConstructCall());
|
|
}
|
|
|
|
} // namespace
|
|
|
|
TEST_F(RemoteObjectTest, CreationContextOfRemoteContext) {
|
|
Local<ObjectTemplate> global_template = ObjectTemplate::New(isolate());
|
|
global_template->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
|
|
Local<Object> remote_context =
|
|
Context::NewRemoteContext(isolate(), global_template).ToLocalChecked();
|
|
EXPECT_TRUE(remote_context->GetCreationContext().IsEmpty());
|
|
}
|
|
|
|
TEST_F(RemoteObjectTest, CreationContextOfRemoteObject) {
|
|
Local<FunctionTemplate> constructor_template =
|
|
FunctionTemplate::New(isolate(), Constructor);
|
|
constructor_template->InstanceTemplate()->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
|
|
Local<Object> remote_object =
|
|
constructor_template->NewRemoteInstance().ToLocalChecked();
|
|
EXPECT_TRUE(remote_object->GetCreationContext().IsEmpty());
|
|
}
|
|
|
|
TEST_F(RemoteObjectTest, RemoteContextInstanceChecks) {
|
|
Local<FunctionTemplate> parent_template =
|
|
FunctionTemplate::New(isolate(), Constructor);
|
|
|
|
Local<FunctionTemplate> constructor_template =
|
|
FunctionTemplate::New(isolate(), Constructor);
|
|
constructor_template->InstanceTemplate()->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
constructor_template->Inherit(parent_template);
|
|
|
|
Local<Object> remote_context =
|
|
Context::NewRemoteContext(isolate(),
|
|
constructor_template->InstanceTemplate())
|
|
.ToLocalChecked();
|
|
EXPECT_TRUE(parent_template->HasInstance(remote_context));
|
|
EXPECT_TRUE(constructor_template->HasInstance(remote_context));
|
|
}
|
|
|
|
TEST_F(RemoteObjectTest, TypeOfRemoteContext) {
|
|
Local<ObjectTemplate> global_template = ObjectTemplate::New(isolate());
|
|
global_template->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
|
|
Local<Object> remote_context =
|
|
Context::NewRemoteContext(isolate(), global_template).ToLocalChecked();
|
|
String::Utf8Value result(isolate(), remote_context->TypeOf(isolate()));
|
|
EXPECT_STREQ("object", *result);
|
|
}
|
|
|
|
TEST_F(RemoteObjectTest, TypeOfRemoteObject) {
|
|
Local<FunctionTemplate> constructor_template =
|
|
FunctionTemplate::New(isolate(), Constructor);
|
|
constructor_template->InstanceTemplate()->SetAccessCheckCallbackAndHandler(
|
|
AccessCheck, NamedPropertyHandlerConfiguration(NamedGetter),
|
|
IndexedPropertyHandlerConfiguration());
|
|
|
|
Local<Object> remote_object =
|
|
constructor_template->NewRemoteInstance().ToLocalChecked();
|
|
String::Utf8Value result(isolate(), remote_object->TypeOf(isolate()));
|
|
EXPECT_STREQ("object", *result);
|
|
}
|
|
|
|
} // namespace remote_object_unittest
|
|
} // namespace v8
|