93f85699e2
The "Restart frame" feature was implemented as part of LiveEdit and primarily used to support LiveEdit of active functions, but that was previously disabled as part of https://crrev.com/c/2846892 because it's too brittle and causes crashes when using seemingly unrelated features. The "Restart frame" feature was also available as a context menu item separately in the DevTools front-end, but that was also already removed as part of https://crrev.com/c/2854681 earlier. So all uses are gone now. This change works by marking Debugger.restartFrame as deprecated and having it respond with a ServerError all the time. It thus allows us to remove a whole bunch of machinery that was essentially just put in various places to support the restart_fp_ magic. In particular the debugger no longer needs any machine specific builtins now. Bug: chromium:1195927 Change-Id: I1153ba6b00e979620af57dd9f58aa1c035ec4484 Fixed: chromium:1203606 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854750 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#74276}
25 lines
934 B
JavaScript
25 lines
934 B
JavaScript
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
const {session, Protocol} =
|
|
InspectorTest.start('Checks that Debugger.restartFrame returns an error');
|
|
|
|
session.setupScriptMap();
|
|
|
|
(async function test() {
|
|
Protocol.Debugger.enable();
|
|
const evalPromise = Protocol.Runtime.evaluate({
|
|
expression: 'function foo() { debugger; }; foo();'
|
|
});
|
|
InspectorTest.log('Paused at debugger:');
|
|
const { params: { callFrames: before } } =
|
|
await Protocol.Debugger.oncePaused();
|
|
await session.logSourceLocation(before[0].location);
|
|
const result = await Protocol.Debugger.restartFrame({ callFrameId: before[0].callFrameId });
|
|
InspectorTest.log('restartFrame result:');
|
|
InspectorTest.logMessage(result);
|
|
await Promise.all([Protocol.Debugger.resume(), evalPromise]);
|
|
InspectorTest.completeTest();
|
|
})()
|