bdd9eba094
This CL includes: 1) Using 1 full GC instead of 2 young GCs to force object promotion. 2) A couple of needed bailouts. 3) Using manual evacuation candidates in old space to ensure an object is evacuted (moved to a different address) instead of relying on Scavenger. And some other minor tweaks Bug: v8:12612 Change-Id: Idfd925ccdf30215998ab6e7cc632ce750fa2077a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3816661 Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82327}
112 lines
4.2 KiB
C++
112 lines
4.2 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#include "src/execution/isolate.h"
|
|
#include "src/heap/factory.h"
|
|
#include "src/heap/heap-inl.h"
|
|
#include "src/objects/objects-inl.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
static void SetUpNewSpaceWithPoisonedMementoAtTop() {
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Heap* heap = isolate->heap();
|
|
NewSpace* new_space = heap->new_space();
|
|
|
|
// Make sure we can allocate some objects without causing a GC later.
|
|
CcTest::CollectAllGarbage();
|
|
|
|
// Allocate a string, the GC may suspect a memento behind the string.
|
|
Handle<SeqOneByteString> string =
|
|
isolate->factory()->NewRawOneByteString(12).ToHandleChecked();
|
|
CHECK(!string->is_null());
|
|
|
|
// Create an allocation memento behind the string with a garbage allocation
|
|
// site pointer.
|
|
AllocationMemento memento = AllocationMemento::unchecked_cast(
|
|
Object(new_space->top() + kHeapObjectTag));
|
|
memento.set_map_after_allocation(ReadOnlyRoots(heap).allocation_memento_map(),
|
|
SKIP_WRITE_BARRIER);
|
|
memento.set_allocation_site(
|
|
AllocationSite::unchecked_cast(Object(kHeapObjectTag)),
|
|
SKIP_WRITE_BARRIER);
|
|
}
|
|
|
|
|
|
TEST(Regress340063) {
|
|
CcTest::InitializeVM();
|
|
if (!i::FLAG_allocation_site_pretenuring || FLAG_single_generation) return;
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
SetUpNewSpaceWithPoisonedMementoAtTop();
|
|
|
|
// Call GC to see if we can handle a poisonous memento right after the
|
|
// current new space top pointer.
|
|
CcTest::PreciseCollectAllGarbage();
|
|
}
|
|
|
|
|
|
TEST(Regress470390) {
|
|
#ifdef VERIFY_HEAP
|
|
// With MinorMC, we may have object allocated after `new_space->top()`. If the
|
|
// next object after `new_space->top()` is an invalid memento, heap
|
|
// verification should fail.
|
|
if (FLAG_minor_mc) return;
|
|
#endif // VERIFY_HEAP
|
|
|
|
CcTest::InitializeVM();
|
|
if (!i::FLAG_allocation_site_pretenuring || FLAG_single_generation) return;
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
SetUpNewSpaceWithPoisonedMementoAtTop();
|
|
|
|
// Set the new space limit to be equal to the top.
|
|
Address top = CcTest::i_isolate()->heap()->new_space()->top();
|
|
*(CcTest::i_isolate()->heap()->new_space()->allocation_limit_address()) = top;
|
|
|
|
// Call GC to see if we can handle a poisonous memento right after the
|
|
// current new space top pointer.
|
|
CcTest::PreciseCollectAllGarbage();
|
|
}
|
|
|
|
|
|
TEST(BadMementoAfterTopForceScavenge) {
|
|
CcTest::InitializeVM();
|
|
if (!i::FLAG_allocation_site_pretenuring || FLAG_single_generation) return;
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
|
|
SetUpNewSpaceWithPoisonedMementoAtTop();
|
|
|
|
// Force GC to test the poisoned memento handling
|
|
CcTest::CollectGarbage(i::NEW_SPACE);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|