be5808bff8
CallSite::IsConstructor() was unable to recognize builtin construct stubs (NumberConstructor_ConstructStub and StringConstructor_ConstructStub) as constructors, and thus these frames were not formatted correctly in stack traces. Fix this by explicitly marking their Code objects as construct stubs and passing along a special receiver value when we encounter such cases in CaptureSimpleStackTrace. R=mstarzinger@chromium.org, yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2125163004 Cr-Commit-Position: refs/heads/master@{#37631}
52 lines
2.0 KiB
JavaScript
52 lines
2.0 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
var thrower = { [Symbol.toPrimitive]: () => FAIL };
|
|
|
|
// Tests that a native conversion function is included in the
|
|
// stack trace.
|
|
function testTraceNativeConversion(nativeFunc) {
|
|
var nativeFuncName = nativeFunc.name;
|
|
try {
|
|
nativeFunc(thrower);
|
|
assertUnreachable(nativeFuncName);
|
|
} catch (e) {
|
|
assertTrue(e.stack.indexOf(nativeFuncName) >= 0, nativeFuncName);
|
|
}
|
|
}
|
|
|
|
testTraceNativeConversion(Math.max);
|
|
testTraceNativeConversion(Math.min);
|
|
|
|
function testBuiltinInStackTrace(script, expectedString) {
|
|
try {
|
|
eval(script);
|
|
assertUnreachable(expectedString);
|
|
} catch (e) {
|
|
assertTrue(e.stack.indexOf(expectedString) >= 0, expectedString);
|
|
}
|
|
}
|
|
|
|
testBuiltinInStackTrace("Date.prototype.getDate.call('')", "at String.getDate");
|
|
testBuiltinInStackTrace("Date.prototype.getUTCDate.call('')",
|
|
"at String.getUTCDate");
|
|
testBuiltinInStackTrace("Date.prototype.getTime.call('')", "at String.getTime");
|
|
|
|
testBuiltinInStackTrace("Number(thrower);", "at Number");
|
|
testBuiltinInStackTrace("new Number(thrower);", "at new Number");
|
|
testBuiltinInStackTrace("String(thrower);", "at String");
|
|
testBuiltinInStackTrace("new String(thrower);", "at new String");
|
|
|
|
// Ensure we correctly pick up the receiver's string tag.
|
|
testBuiltinInStackTrace("Math.acos(thrower);", "at Math.acos");
|
|
testBuiltinInStackTrace("Math.asin(thrower);", "at Math.asin");
|
|
testBuiltinInStackTrace("Math.fround(thrower);", "at Math.fround");
|
|
testBuiltinInStackTrace("Math.imul(thrower);", "at Math.imul");
|
|
|
|
// As above, but function passed as an argument and then called.
|
|
testBuiltinInStackTrace("((f, x) => f(x))(Math.acos, thrower);", "at acos");
|
|
testBuiltinInStackTrace("((f, x) => f(x))(Math.asin, thrower);", "at asin");
|
|
testBuiltinInStackTrace("((f, x) => f(x))(Math.fround, thrower);", "at fround");
|
|
testBuiltinInStackTrace("((f, x) => f(x))(Math.imul, thrower);", "at imul");
|