c9b4f3c4a7
This CL is part of a series that implements Turbofan support for property accesses satisfying the following conditions: 1. The holder is a dictionary mode object. 2. The holder is a prototype. 3. The access is a load. This feature will only be enabled if the build flag v8_dict_property_const_tracking is set. This particular CL modifies existing mjsunit tests whose assumptions don't hold if v8_dict_property_const_tracking is enabled. This is done by adding special handling for the case that %IsDictPropertyConstTrackingEnabled() holds. Bug: v8:11248 Change-Id: Ia36be73e4659a988b2471f0c8151b0442f3a98f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2780292 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73745}
47 lines
1.8 KiB
JavaScript
47 lines
1.8 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
function TestBuiltinSubclassing(Builtin) {
|
|
if (!%IsDictPropertyConstTrackingEnabled()) {
|
|
// TODO(v8:11248) In the current implementation of
|
|
// v8_dict_property_const_tracking, prototypes are converted to dictionary
|
|
// mode in many places, but we don't guarantee that they are *created* as
|
|
// dictionary mode objects, yet. This will be fixed in the future. Until
|
|
// then, if v8_dict_property_const_tracking is enabled, we cannot always
|
|
// know for sure if a builtin has been converted already or not.
|
|
assertTrue(%HasFastProperties(Builtin));
|
|
}
|
|
assertTrue(%HasFastProperties(Builtin.prototype));
|
|
assertEquals(!%IsDictPropertyConstTrackingEnabled(),
|
|
%HasFastProperties(Builtin.prototype.__proto__));
|
|
|
|
class SubClass extends Builtin {}
|
|
|
|
assertEquals(!%IsDictPropertyConstTrackingEnabled(),
|
|
%HasFastProperties(Builtin));
|
|
assertEquals(!%IsDictPropertyConstTrackingEnabled(),
|
|
%HasFastProperties(Builtin.prototype));
|
|
assertEquals(!%IsDictPropertyConstTrackingEnabled(),
|
|
%HasFastProperties(Builtin.prototype.__proto__));
|
|
|
|
}
|
|
|
|
let TypedArray = Uint8Array.__proto__;
|
|
|
|
TestBuiltinSubclassing(RegExp);
|
|
TestBuiltinSubclassing(Promise);
|
|
TestBuiltinSubclassing(Array);
|
|
TestBuiltinSubclassing(TypedArray);
|
|
TestBuiltinSubclassing(Uint8Array);
|
|
TestBuiltinSubclassing(Int8Array);
|
|
TestBuiltinSubclassing(Uint16Array);
|
|
TestBuiltinSubclassing(Int16Array);
|
|
TestBuiltinSubclassing(Uint32Array);
|
|
TestBuiltinSubclassing(Int32Array);
|
|
TestBuiltinSubclassing(Float32Array);
|
|
TestBuiltinSubclassing(Float64Array);
|
|
TestBuiltinSubclassing(Uint8ClampedArray);
|