Set warning level to /W3 and change implicit conversions from size_t to int. Most "fixes" are simply manifesting the implicit casts or using a special strlen replacement that returns int. Review URL: http://codereview.chromium.org/390004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3273 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
293 lines
9.3 KiB
C++
293 lines
9.3 KiB
C++
// Copyright 2009 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include "v8.h"
|
|
|
|
#include "macro-assembler.h"
|
|
#include "factory.h"
|
|
#include "platform.h"
|
|
#include "serialize.h"
|
|
#include "cctest.h"
|
|
|
|
using v8::internal::byte;
|
|
using v8::internal::OS;
|
|
using v8::internal::Assembler;
|
|
using v8::internal::Operand;
|
|
using v8::internal::Immediate;
|
|
using v8::internal::Label;
|
|
using v8::internal::rax;
|
|
using v8::internal::rsi;
|
|
using v8::internal::rdi;
|
|
using v8::internal::rcx;
|
|
using v8::internal::rdx;
|
|
using v8::internal::rbp;
|
|
using v8::internal::rsp;
|
|
using v8::internal::FUNCTION_CAST;
|
|
using v8::internal::CodeDesc;
|
|
using v8::internal::less_equal;
|
|
using v8::internal::not_equal;
|
|
using v8::internal::greater;
|
|
|
|
// Test the x64 assembler by compiling some simple functions into
|
|
// a buffer and executing them. These tests do not initialize the
|
|
// V8 library, create a context, or use any V8 objects.
|
|
// The AMD64 calling convention is used, with the first six arguments
|
|
// in RDI, RSI, RDX, RCX, R8, and R9, and floating point arguments in
|
|
// the XMM registers. The return value is in RAX.
|
|
// This calling convention is used on Linux, with GCC, and on Mac OS,
|
|
// with GCC. A different convention is used on 64-bit windows,
|
|
// where the first four integer arguments are passed in RCX, RDX, R8 and R9.
|
|
|
|
typedef int (*F0)();
|
|
typedef int (*F1)(int64_t x);
|
|
typedef int (*F2)(int64_t x, int64_t y);
|
|
|
|
#ifdef _WIN64
|
|
static const v8::internal::Register arg1 = rcx;
|
|
static const v8::internal::Register arg2 = rdx;
|
|
#else
|
|
static const v8::internal::Register arg1 = rdi;
|
|
static const v8::internal::Register arg2 = rsi;
|
|
#endif
|
|
|
|
#define __ assm.
|
|
|
|
|
|
TEST(AssemblerX64ReturnOperation) {
|
|
// Allocate an executable page of memory.
|
|
size_t actual_size;
|
|
byte* buffer = static_cast<byte*>(OS::Allocate(Assembler::kMinimalBufferSize,
|
|
&actual_size,
|
|
true));
|
|
CHECK(buffer);
|
|
Assembler assm(buffer, static_cast<int>(actual_size));
|
|
|
|
// Assemble a simple function that copies argument 2 and returns it.
|
|
__ movq(rax, arg2);
|
|
__ nop();
|
|
__ ret(0);
|
|
|
|
CodeDesc desc;
|
|
assm.GetCode(&desc);
|
|
// Call the function from C++.
|
|
int result = FUNCTION_CAST<F2>(buffer)(3, 2);
|
|
CHECK_EQ(2, result);
|
|
}
|
|
|
|
TEST(AssemblerX64StackOperations) {
|
|
// Allocate an executable page of memory.
|
|
size_t actual_size;
|
|
byte* buffer = static_cast<byte*>(OS::Allocate(Assembler::kMinimalBufferSize,
|
|
&actual_size,
|
|
true));
|
|
CHECK(buffer);
|
|
Assembler assm(buffer, static_cast<int>(actual_size));
|
|
|
|
// Assemble a simple function that copies argument 2 and returns it.
|
|
// We compile without stack frame pointers, so the gdb debugger shows
|
|
// incorrect stack frames when debugging this function (which has them).
|
|
__ push(rbp);
|
|
__ movq(rbp, rsp);
|
|
__ push(arg2); // Value at (rbp - 8)
|
|
__ push(arg2); // Value at (rbp - 16)
|
|
__ push(arg1); // Value at (rbp - 24)
|
|
__ pop(rax);
|
|
__ pop(rax);
|
|
__ pop(rax);
|
|
__ pop(rbp);
|
|
__ nop();
|
|
__ ret(0);
|
|
|
|
CodeDesc desc;
|
|
assm.GetCode(&desc);
|
|
// Call the function from C++.
|
|
int result = FUNCTION_CAST<F2>(buffer)(3, 2);
|
|
CHECK_EQ(2, result);
|
|
}
|
|
|
|
TEST(AssemblerX64ArithmeticOperations) {
|
|
// Allocate an executable page of memory.
|
|
size_t actual_size;
|
|
byte* buffer = static_cast<byte*>(OS::Allocate(Assembler::kMinimalBufferSize,
|
|
&actual_size,
|
|
true));
|
|
CHECK(buffer);
|
|
Assembler assm(buffer, static_cast<int>(actual_size));
|
|
|
|
// Assemble a simple function that adds arguments returning the sum.
|
|
__ movq(rax, arg2);
|
|
__ addq(rax, arg1);
|
|
__ ret(0);
|
|
|
|
CodeDesc desc;
|
|
assm.GetCode(&desc);
|
|
// Call the function from C++.
|
|
int result = FUNCTION_CAST<F2>(buffer)(3, 2);
|
|
CHECK_EQ(5, result);
|
|
}
|
|
|
|
TEST(AssemblerX64ImulOperation) {
|
|
// Allocate an executable page of memory.
|
|
size_t actual_size;
|
|
byte* buffer = static_cast<byte*>(OS::Allocate(Assembler::kMinimalBufferSize,
|
|
&actual_size,
|
|
true));
|
|
CHECK(buffer);
|
|
Assembler assm(buffer, static_cast<int>(actual_size));
|
|
|
|
// Assemble a simple function that multiplies arguments returning the high
|
|
// word.
|
|
__ movq(rax, arg2);
|
|
__ imul(arg1);
|
|
__ movq(rax, rdx);
|
|
__ ret(0);
|
|
|
|
CodeDesc desc;
|
|
assm.GetCode(&desc);
|
|
// Call the function from C++.
|
|
int result = FUNCTION_CAST<F2>(buffer)(3, 2);
|
|
CHECK_EQ(0, result);
|
|
result = FUNCTION_CAST<F2>(buffer)(0x100000000l, 0x100000000l);
|
|
CHECK_EQ(1, result);
|
|
result = FUNCTION_CAST<F2>(buffer)(-0x100000000l, 0x100000000l);
|
|
CHECK_EQ(-1, result);
|
|
}
|
|
|
|
TEST(AssemblerX64MemoryOperands) {
|
|
// Allocate an executable page of memory.
|
|
size_t actual_size;
|
|
byte* buffer = static_cast<byte*>(OS::Allocate(Assembler::kMinimalBufferSize,
|
|
&actual_size,
|
|
true));
|
|
CHECK(buffer);
|
|
Assembler assm(buffer, static_cast<int>(actual_size));
|
|
|
|
// Assemble a simple function that copies argument 2 and returns it.
|
|
__ push(rbp);
|
|
__ movq(rbp, rsp);
|
|
|
|
__ push(arg2); // Value at (rbp - 8)
|
|
__ push(arg2); // Value at (rbp - 16)
|
|
__ push(arg1); // Value at (rbp - 24)
|
|
|
|
const int kStackElementSize = 8;
|
|
__ movq(rax, Operand(rbp, -3 * kStackElementSize));
|
|
__ pop(arg2);
|
|
__ pop(arg2);
|
|
__ pop(arg2);
|
|
__ pop(rbp);
|
|
__ nop();
|
|
__ ret(0);
|
|
|
|
CodeDesc desc;
|
|
assm.GetCode(&desc);
|
|
// Call the function from C++.
|
|
int result = FUNCTION_CAST<F2>(buffer)(3, 2);
|
|
CHECK_EQ(3, result);
|
|
}
|
|
|
|
TEST(AssemblerX64ControlFlow) {
|
|
// Allocate an executable page of memory.
|
|
size_t actual_size;
|
|
byte* buffer = static_cast<byte*>(OS::Allocate(Assembler::kMinimalBufferSize,
|
|
&actual_size,
|
|
true));
|
|
CHECK(buffer);
|
|
Assembler assm(buffer, static_cast<int>(actual_size));
|
|
|
|
// Assemble a simple function that copies argument 1 and returns it.
|
|
__ push(rbp);
|
|
|
|
__ movq(rbp, rsp);
|
|
__ movq(rax, arg1);
|
|
Label target;
|
|
__ jmp(&target);
|
|
__ movq(rax, arg2);
|
|
__ bind(&target);
|
|
__ pop(rbp);
|
|
__ ret(0);
|
|
|
|
CodeDesc desc;
|
|
assm.GetCode(&desc);
|
|
// Call the function from C++.
|
|
int result = FUNCTION_CAST<F2>(buffer)(3, 2);
|
|
CHECK_EQ(3, result);
|
|
}
|
|
|
|
TEST(AssemblerX64LoopImmediates) {
|
|
// Allocate an executable page of memory.
|
|
size_t actual_size;
|
|
byte* buffer = static_cast<byte*>(OS::Allocate(Assembler::kMinimalBufferSize,
|
|
&actual_size,
|
|
true));
|
|
CHECK(buffer);
|
|
Assembler assm(buffer, static_cast<int>(actual_size));
|
|
// Assemble two loops using rax as counter, and verify the ending counts.
|
|
Label Fail;
|
|
__ movq(rax, Immediate(-3));
|
|
Label Loop1_test;
|
|
Label Loop1_body;
|
|
__ jmp(&Loop1_test);
|
|
__ bind(&Loop1_body);
|
|
__ addq(rax, Immediate(7));
|
|
__ bind(&Loop1_test);
|
|
__ cmpq(rax, Immediate(20));
|
|
__ j(less_equal, &Loop1_body);
|
|
// Did the loop terminate with the expected value?
|
|
__ cmpq(rax, Immediate(25));
|
|
__ j(not_equal, &Fail);
|
|
|
|
Label Loop2_test;
|
|
Label Loop2_body;
|
|
__ movq(rax, Immediate(0x11FEED00));
|
|
__ jmp(&Loop2_test);
|
|
__ bind(&Loop2_body);
|
|
__ addq(rax, Immediate(-0x1100));
|
|
__ bind(&Loop2_test);
|
|
__ cmpq(rax, Immediate(0x11FE8000));
|
|
__ j(greater, &Loop2_body);
|
|
// Did the loop terminate with the expected value?
|
|
__ cmpq(rax, Immediate(0x11FE7600));
|
|
__ j(not_equal, &Fail);
|
|
|
|
__ movq(rax, Immediate(1));
|
|
__ ret(0);
|
|
__ bind(&Fail);
|
|
__ movq(rax, Immediate(0));
|
|
__ ret(0);
|
|
|
|
CodeDesc desc;
|
|
assm.GetCode(&desc);
|
|
// Call the function from C++.
|
|
int result = FUNCTION_CAST<F0>(buffer)();
|
|
CHECK_EQ(1, result);
|
|
}
|
|
|
|
#undef __
|