8fdb23873b
This reverts commit5611f70b3d. Reason for revert: flaky tests: v8:9588, v8:9587 Original change's description: > "Reland x4 [arraybuffer] Rearchitect backing store ownership" > > This is a reland ofbc33f5aeba> > Contributed by titzer@chromium.org > > Original change's description: > > [arraybuffer] Rearchitect backing store ownership > > > > This CL completely rearchitects the ownership of array buffer backing stores, > > consolidating ownership into a {BackingStore} C++ object that is tracked > > throughout V8 using unique_ptr and shared_ptr where appropriate. > > > > Overall, lifetime management is simpler and more explicit. The numerous > > ways that array buffers were initialized have been streamlined to one > > Attach() method on JSArrayBuffer. The array buffer tracker in the > > GC implementation now manages std::shared_ptr<BackingStore> pointers, > > and the construction and destruction of the BackingStore object itself > > handles the underlying page or embedder-allocated memory. > > > > The embedder API remains unchanged for now. We use the > > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to > > keep the backing store alive properly, even in the case of aliases > > from live heap objects. Thus the embedder has a lower chance of making > > a mistake. Long-term, we should move the embedder to a model where they > > manage backing stores using shared_ptr to an opaque backing store object. > > TBR=yangguo@chromium.org > > BUG=v8:9380,v8:9221,chromium:986318 > > Change-Id: If671a4a9ca0476e8f084efae46e0d2bf99ed99ef > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1731005 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63041} TBR=ulan@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9380, v8:9221, chromium:986318 Change-Id: Ic7381239f4e90d0c437b7e47a5ac6e8bce60f882 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1736747 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#63081}
38 lines
1.0 KiB
JavaScript
38 lines
1.0 KiB
JavaScript
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
function AllocMemory(pages, max = pages) {
|
|
let m =
|
|
new WebAssembly.Memory({initial : pages, maximum : max, shared : true});
|
|
let v = new Int32Array(m.buffer);
|
|
return {memory : m, view : v};
|
|
}
|
|
|
|
function RunSomeAllocs(total, retained, pages, max = pages) {
|
|
print(`-------iterations = ${total}, retained = $ { retained } -------`);
|
|
var array = new Array(retained);
|
|
for (var i = 0; i < total; i++) {
|
|
if ((i % 25) == 0)
|
|
print(`iteration $ { i }`);
|
|
let pair = AllocMemory(pages, max);
|
|
// For some iterations, retain the memory, view, or both.
|
|
switch (i % 3) {
|
|
case 0:
|
|
pair.memory = null;
|
|
break;
|
|
case 1:
|
|
pair.view = null;
|
|
break;
|
|
case 2:
|
|
break;
|
|
}
|
|
array[i % retained] = pair;
|
|
}
|
|
}
|
|
|
|
RunSomeAllocs(10, 1, 1, 1);
|
|
RunSomeAllocs(100, 3, 1, 1);
|
|
RunSomeAllocs(1000, 10, 1, 1);
|
|
RunSomeAllocs(10000, 20, 1, 1);
|