ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
102 lines
3.8 KiB
C++
102 lines
3.8 KiB
C++
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "test/unittests/heap/unified-heap-utils.h"
|
|
|
|
#include "include/cppgc/platform.h"
|
|
#include "include/v8-cppgc.h"
|
|
#include "include/v8-function.h"
|
|
#include "src/api/api-inl.h"
|
|
#include "src/heap/cppgc-js/cpp-heap.h"
|
|
#include "src/heap/heap.h"
|
|
#include "src/objects/objects-inl.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
UnifiedHeapTest::UnifiedHeapTest()
|
|
: UnifiedHeapTest(std::vector<std::unique_ptr<cppgc::CustomSpaceBase>>()) {}
|
|
|
|
UnifiedHeapTest::UnifiedHeapTest(
|
|
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces)
|
|
: cpp_heap_(v8::CppHeap::Create(
|
|
V8::GetCurrentPlatform(),
|
|
CppHeapCreateParams{std::move(custom_spaces),
|
|
WrapperHelper::DefaultWrapperDescriptor()})) {
|
|
isolate()->heap()->AttachCppHeap(cpp_heap_.get());
|
|
}
|
|
|
|
void UnifiedHeapTest::CollectGarbageWithEmbedderStack(
|
|
cppgc::Heap::SweepingType sweeping_type) {
|
|
heap()->SetEmbedderStackStateForNextFinalization(
|
|
EmbedderHeapTracer::EmbedderStackState::kMayContainHeapPointers);
|
|
CollectGarbage(OLD_SPACE);
|
|
if (sweeping_type == cppgc::Heap::SweepingType::kAtomic) {
|
|
cpp_heap().AsBase().sweeper().FinishIfRunning();
|
|
}
|
|
}
|
|
|
|
void UnifiedHeapTest::CollectGarbageWithoutEmbedderStack(
|
|
cppgc::Heap::SweepingType sweeping_type) {
|
|
heap()->SetEmbedderStackStateForNextFinalization(
|
|
EmbedderHeapTracer::EmbedderStackState::kNoHeapPointers);
|
|
CollectGarbage(OLD_SPACE);
|
|
if (sweeping_type == cppgc::Heap::SweepingType::kAtomic) {
|
|
cpp_heap().AsBase().sweeper().FinishIfRunning();
|
|
}
|
|
}
|
|
|
|
CppHeap& UnifiedHeapTest::cpp_heap() const {
|
|
return *CppHeap::From(isolate()->heap()->cpp_heap());
|
|
}
|
|
|
|
cppgc::AllocationHandle& UnifiedHeapTest::allocation_handle() {
|
|
return cpp_heap().object_allocator();
|
|
}
|
|
|
|
// static
|
|
v8::Local<v8::Object> WrapperHelper::CreateWrapper(
|
|
v8::Local<v8::Context> context, void* wrappable_type,
|
|
void* wrappable_object, const char* class_name) {
|
|
v8::EscapableHandleScope scope(context->GetIsolate());
|
|
v8::Local<v8::FunctionTemplate> function_t =
|
|
v8::FunctionTemplate::New(context->GetIsolate());
|
|
if (strlen(class_name) != 0) {
|
|
function_t->SetClassName(
|
|
v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), class_name)
|
|
.ToLocalChecked());
|
|
}
|
|
v8::Local<v8::ObjectTemplate> instance_t = function_t->InstanceTemplate();
|
|
instance_t->SetInternalFieldCount(2);
|
|
v8::Local<v8::Function> function =
|
|
function_t->GetFunction(context).ToLocalChecked();
|
|
v8::Local<v8::Object> instance =
|
|
function->NewInstance(context).ToLocalChecked();
|
|
SetWrappableConnection(instance, wrappable_type, wrappable_object);
|
|
CHECK(!instance.IsEmpty());
|
|
i::Handle<i::JSReceiver> js_obj = v8::Utils::OpenHandle(*instance);
|
|
CHECK_EQ(i::JS_API_OBJECT_TYPE, js_obj->map().instance_type());
|
|
return scope.Escape(instance);
|
|
}
|
|
|
|
// static
|
|
void WrapperHelper::ResetWrappableConnection(v8::Local<v8::Object> api_object) {
|
|
api_object->SetAlignedPointerInInternalField(kWrappableTypeEmbedderIndex,
|
|
nullptr);
|
|
api_object->SetAlignedPointerInInternalField(kWrappableInstanceEmbedderIndex,
|
|
nullptr);
|
|
}
|
|
|
|
// static
|
|
void WrapperHelper::SetWrappableConnection(v8::Local<v8::Object> api_object,
|
|
void* type, void* instance) {
|
|
api_object->SetAlignedPointerInInternalField(kWrappableTypeEmbedderIndex,
|
|
type);
|
|
api_object->SetAlignedPointerInInternalField(kWrappableInstanceEmbedderIndex,
|
|
instance);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|