d4266e3035
This CL adds all the necessary {WasmCodeRefScope}s in the code base, or
at least a good approximation. A follow-up CL will enable a check that
a {WasmCodeRefScope} exists whenever a pointer to a {WasmCode} object
is returned from the {NativeModule}. This should flush out any missing
scopes.
R=titzer@chromium.org
Bug: v8:8217
Change-Id: I54c7eb39aeb1acde38273c399396e6b1390a4cb2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533860
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60566}
131 lines
3.9 KiB
C++
131 lines
3.9 KiB
C++
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/compiler/wasm-compiler.h"
|
|
#include "src/wasm/function-compiler.h"
|
|
#include "src/wasm/wasm-code-manager.h"
|
|
#include "src/wasm/wasm-engine.h"
|
|
#include "src/wasm/wasm-import-wrapper-cache.h"
|
|
#include "src/wasm/wasm-module.h"
|
|
|
|
#include "test/cctest/cctest.h"
|
|
#include "test/common/wasm/test-signatures.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace wasm {
|
|
namespace test_wasm_import_wrapper_cache {
|
|
|
|
std::shared_ptr<NativeModule> NewModule(Isolate* isolate) {
|
|
std::shared_ptr<WasmModule> module(new WasmModule);
|
|
bool can_request_more = false;
|
|
size_t size = 16384;
|
|
auto native_module = isolate->wasm_engine()->NewNativeModule(
|
|
isolate, kAllWasmFeatures, size, can_request_more, std::move(module));
|
|
native_module->SetRuntimeStubs(isolate);
|
|
return native_module;
|
|
}
|
|
|
|
TEST(CacheHit) {
|
|
Isolate* isolate = CcTest::InitIsolateOnce();
|
|
auto module = NewModule(isolate);
|
|
TestSignatures sigs;
|
|
WasmCodeRefScope wasm_code_ref_scope;
|
|
|
|
auto kind = compiler::WasmImportCallKind::kJSFunctionArityMatch;
|
|
|
|
WasmCode* c1 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind, sigs.i_i());
|
|
|
|
CHECK_NOT_NULL(c1);
|
|
CHECK_EQ(WasmCode::Kind::kWasmToJsWrapper, c1->kind());
|
|
|
|
WasmCode* c2 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind, sigs.i_i());
|
|
|
|
CHECK_NOT_NULL(c2);
|
|
CHECK_EQ(c1, c2);
|
|
}
|
|
|
|
TEST(CacheMissSig) {
|
|
Isolate* isolate = CcTest::InitIsolateOnce();
|
|
auto module = NewModule(isolate);
|
|
TestSignatures sigs;
|
|
WasmCodeRefScope wasm_code_ref_scope;
|
|
|
|
auto kind = compiler::WasmImportCallKind::kJSFunctionArityMatch;
|
|
|
|
WasmCode* c1 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind, sigs.i_i());
|
|
|
|
CHECK_NOT_NULL(c1);
|
|
CHECK_EQ(WasmCode::Kind::kWasmToJsWrapper, c1->kind());
|
|
|
|
WasmCode* c2 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind, sigs.i_ii());
|
|
|
|
CHECK_NOT_NULL(c2);
|
|
CHECK_NE(c1, c2);
|
|
}
|
|
|
|
TEST(CacheMissKind) {
|
|
Isolate* isolate = CcTest::InitIsolateOnce();
|
|
auto module = NewModule(isolate);
|
|
TestSignatures sigs;
|
|
WasmCodeRefScope wasm_code_ref_scope;
|
|
|
|
auto kind1 = compiler::WasmImportCallKind::kJSFunctionArityMatch;
|
|
auto kind2 = compiler::WasmImportCallKind::kJSFunctionArityMismatch;
|
|
|
|
WasmCode* c1 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind1, sigs.i_i());
|
|
|
|
CHECK_NOT_NULL(c1);
|
|
CHECK_EQ(WasmCode::Kind::kWasmToJsWrapper, c1->kind());
|
|
|
|
WasmCode* c2 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind2, sigs.i_i());
|
|
|
|
CHECK_NOT_NULL(c2);
|
|
CHECK_NE(c1, c2);
|
|
}
|
|
|
|
TEST(CacheHitMissSig) {
|
|
Isolate* isolate = CcTest::InitIsolateOnce();
|
|
auto module = NewModule(isolate);
|
|
TestSignatures sigs;
|
|
WasmCodeRefScope wasm_code_ref_scope;
|
|
|
|
auto kind = compiler::WasmImportCallKind::kJSFunctionArityMatch;
|
|
|
|
WasmCode* c1 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind, sigs.i_i());
|
|
|
|
CHECK_NOT_NULL(c1);
|
|
CHECK_EQ(WasmCode::Kind::kWasmToJsWrapper, c1->kind());
|
|
|
|
WasmCode* c2 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind, sigs.i_ii());
|
|
|
|
CHECK_NOT_NULL(c2);
|
|
CHECK_NE(c1, c2);
|
|
|
|
WasmCode* c3 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind, sigs.i_i());
|
|
|
|
CHECK_NOT_NULL(c3);
|
|
CHECK_EQ(c1, c3);
|
|
|
|
WasmCode* c4 = module->import_wrapper_cache()->GetOrCompile(
|
|
isolate->wasm_engine(), isolate->counters(), kind, sigs.i_ii());
|
|
|
|
CHECK_NOT_NULL(c4);
|
|
CHECK_EQ(c2, c4);
|
|
}
|
|
|
|
} // namespace test_wasm_import_wrapper_cache
|
|
} // namespace wasm
|
|
} // namespace internal
|
|
} // namespace v8
|