d56ee2e3df
Up until now, we cached export wrappers per export index. With the anyref proposal potentially many more functions will need export wrappers, e.g. any function that is stored in a table, and any function accessed by the new ref.func instruction. With this CL, we change the caching scheme an do the caching per signature. Thereby we can guarantee that any export wrapper which potentially exists can be stored in the cache. For cctests which use wasm-run-utils, we don't know the size of the cache anymore ahead of time. However, we assume that no more than 5 signatures will be used in any cctest. If this assumption is not true, we can just adjust the number. The cache is now accessed in all code paths where we need an export wrapper. Bug: chromium:962850 Change-Id: I32df60dfa7801d1e71f7d837da091f388198af1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615247 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61752}
51 lines
1.5 KiB
C++
51 lines
1.5 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_WASM_SIGNATURE_MAP_H_
|
|
#define V8_WASM_SIGNATURE_MAP_H_
|
|
|
|
#include <unordered_map>
|
|
|
|
#include "src/codegen/signature.h"
|
|
#include "src/wasm/value-type.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
namespace wasm {
|
|
|
|
// A signature map canonicalizes signatures into a range of indices so that
|
|
// two different {FunctionSig} instances with the same contents map to the
|
|
// same index.
|
|
class V8_EXPORT_PRIVATE SignatureMap {
|
|
public:
|
|
// Allow default construction and move construction (because we have vectors
|
|
// of objects containing SignatureMaps), but disallow copy or assign. It's
|
|
// too easy to get security bugs by accidentally updating a copy of the map.
|
|
MOVE_ONLY_WITH_DEFAULT_CONSTRUCTORS(SignatureMap);
|
|
|
|
// Gets the index for a signature, assigning a new index if necessary.
|
|
uint32_t FindOrInsert(const FunctionSig& sig);
|
|
|
|
// Gets the index for a signature, returning {-1} if not found.
|
|
int32_t Find(const FunctionSig& sig) const;
|
|
|
|
// Disallows further insertions to this signature map.
|
|
void Freeze() { frozen_ = true; }
|
|
|
|
size_t size() const { return map_.size(); }
|
|
|
|
bool is_frozen() const { return frozen_; }
|
|
|
|
private:
|
|
bool frozen_ = false;
|
|
std::unordered_map<FunctionSig, uint32_t, base::hash<FunctionSig>> map_;
|
|
};
|
|
|
|
} // namespace wasm
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_WASM_SIGNATURE_MAP_H_
|